diff mbox series

[OpenWrt-Devel] uboot-env-tools be safer

Message ID CAA21KT99Eevnj=1eqyT7YbvHYhRp6G+sxd-gEmjpJ=f23UGUmQ@mail.gmail.com
State Accepted
Headers show
Series [OpenWrt-Devel] uboot-env-tools be safer | expand

Commit Message

Imran K Dec. 17, 2019, 1:59 p.m. UTC 
uboot-env-tools: Check for config prior to append

In the rare event a pre-populated fw_env.config exists in the rootfs prior
to firstboot, calling fw_setenv after the system has initialised will
annihilate the devices environment due to two identical lines in
fw_env.config.

Check for existence prior to blind appendage.


Signed-off-by: Imran Khan <gururug at gmail.com>
diff mbox series

Patch

--- a/uboot-envtools.sh
+++ b/uboot-envtools.sh
@@ -31,6 +31,6 @@  ubootenv_add_app_config() {
  config_get envsize "$1" envsize
  config_get secsize "$1" secsize
  config_get numsec "$1" numsec
- echo "$dev $offset $envsize $secsize $numsec" >>/etc/fw_env.config
+ grep -q "$dev $offset $envsize $secsize $numsec" /etc/fw_env.config ||
echo "$dev $offset $envsize $secsize $numsec" >>/etc/fw_env.config
 }