| Message ID | 1319178713-12472-1-git-send-email-tie-fei.zang@freescale.com |
|---|---|
| State | Accepted |
| Commit | afc52db2f76e0215411a916af46c578fcfd02a81 |
| Headers | show |
Dear Roy Zang, In message <1319178713-12472-1-git-send-email-tie-fei.zang@freescale.com> you wrote: > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > So remove the duplicate code on platform Ethernet code. > > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com> > Cc: Andy Fleming <afleming@freescale.com> > Cc: Kumar Gala <galak@kernel.crashing.org> Please change the Subject: so everybody understands what you are doing. "powerpc/fm" is not exactly clear to everybody, and neither is TBIPA. Nor is clear which processors / processor families / boards are affected. Best regards, Wolfgang Denk
> -----Original Message----- > From: Wolfgang Denk [mailto:wd@denx.de] > Sent: Monday, October 24, 2011 3:37 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Roy Zang, > > In message <1319178713-12472-1-git-send-email-tie-fei.zang@freescale.com> you > wrote: > > TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c > > > > So remove the duplicate code on platform Ethernet code. > > > > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com> > > Cc: Andy Fleming <afleming@freescale.com> > > Cc: Kumar Gala <galak@kernel.crashing.org> > > Please change the Subject: so everybody understands what you are > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > TBIPA. > > Nor is clear which processors / processor families / boards are > affected. Per my understand, subject is a summary of the patch. poweper/fm and TBIPA should almost be OK for the subject. I can point out that the code is about the network code in subject. for example, Subject: powerpc/fm: remove the TBIPA setting on platform network related code Then I add more in the patch description to explain fm, TBIPA, processors, processor families/boards affected. Thanks. Roy
Dear Zang Roy-R61911, In message <2239AC579C7D3646A720227A37E02681200AAA@039-SN1MPN1-004.039d.mgd.msft.net> you wrote: > > > Please change the Subject: so everybody understands what you are > > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > > TBIPA. > > > > Nor is clear which processors / processor families / boards are > > affected. > Per my understand, subject is a summary of the patch. poweper/fm and TBIPA should almost be OK for the subject. I can point out that the code is about the network code in subject. > for example, Subject: > powerpc/fm: remove the TBIPA setting on platform network related code No. I have not the lightest idea what FM (Frequency Modulation?) or TBIPA might be. Best regards, Wolfgang Denk
> -----Original Message----- > From: Wolfgang Denk [mailto:wd@denx.de] > Sent: Monday, October 24, 2011 13:24 PM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Zang Roy-R61911, > > In message <2239AC579C7D3646A720227A37E02681200AAA@039-SN1MPN1- > 004.039d.mgd.msft.net> you wrote: > > > > > Please change the Subject: so everybody understands what you are > > > doing. "powerpc/fm" is not exactly clear to everybody, and neither is > > > TBIPA. > > > > > > Nor is clear which processors / processor families / boards are > > > affected. > > Per my understand, subject is a summary of the patch. poweper/fm and TBIPA > should almost be OK for the subject. I can point out that the code is about the > network code in subject. > > for example, Subject: > > powerpc/fm: remove the TBIPA setting on platform network related code > > No. I have not the lightest idea what FM (Frequency Modulation?) or > TBIPA might be. Any way you are the owner. How about this way: Subject: net/frame manager: remove TBI PHY address register setting on platform related code Then I add the other more detailed required information in the description body? Thanks. Roy
Dear Zang Roy-R61911, In message <2239AC579C7D3646A720227A37E02681200C29@039-SN1MPN1-004.039d.mgd.msft.net> you wrote: > > How about this way: > Subject: net/frame manager: remove TBI PHY address register setting on plat= > form related code > > Then I add the other more detailed required information in the description = > body? You are putting too much low level detail into the Subject: line, while leaving out important higher level information, like architecture, SoC, etc. How about something like: QorIQ: fix network frame manager settings Then put all the rest into the commit message. Best regards, Wolfgang Denk
> -----Original Message----- > From: Wolfgang Denk [mailto:wd@denx.de] > Sent: Tuesday, October 25, 2011 3:05 AM > To: Zang Roy-R61911 > Cc: u-boot@lists.denx.de; Fleming Andy-AFLEMING; Kumar Gala > Subject: Re: [U-Boot] [PATCH] powerpc/fm: remove the TBIPA setting on platform > code > > Dear Zang Roy-R61911, > > In message <2239AC579C7D3646A720227A37E02681200C29@039-SN1MPN1- > 004.039d.mgd.msft.net> you wrote: > > > > How about this way: > > Subject: net/frame manager: remove TBI PHY address register setting on plat= > > form related code > > > > Then I add the other more detailed required information in the description = > > body? > > You are putting too much low level detail into the Subject: line, > while leaving out important higher level information, like > architecture, SoC, etc. > > How about something like: > > QorIQ: fix network frame manager settings This subject is too big. What kind of network frame manager setting? It will be hard for someone to find useful information in the subject. Prefer: QorIQ: fix network frame manager TBI PHY address settings Roy
diff --git a/board/freescale/corenet_ds/eth_hydra.c b/board/freescale/corenet_ds/eth_hydra.c index 91b3408..639358d 100644 --- a/board/freescale/corenet_ds/eth_hydra.c +++ b/board/freescale/corenet_ds/eth_hydra.c @@ -395,7 +395,6 @@ void fdt_fixup_board_enet(void *fdt) int board_eth_init(bd_t *bis) { #ifdef CONFIG_FMAN_ENET - struct dtsec *tsec = (void *)CONFIG_SYS_FSL_FM1_DTSEC1_ADDR; struct fsl_pq_mdio_info dtsec_mdio_info; struct tgec_mdio_info tgec_mdio_info; unsigned int i, slot; @@ -405,13 +404,6 @@ int board_eth_init(bd_t *bis) initialize_lane_to_slot(); - /* - * Set TBIPA on FM1@DTSEC1. This is needed for configurations - * where FM1@DTSEC1 isn't used directly, since it provides - * MDIO for other ports. - */ - out_be32(&tsec->tbipa, CONFIG_SYS_TBIPA_VALUE); - /* We want to use the PIXIS to configure MUX routing, not GPIOs. */ setbits_8(&pixis->brdcfg2, BRDCFG2_REG_GPIO_SEL); diff --git a/board/freescale/corenet_ds/eth_p4080.c b/board/freescale/corenet_ds/eth_p4080.c index d4657f7..208b97a 100644 --- a/board/freescale/corenet_ds/eth_p4080.c +++ b/board/freescale/corenet_ds/eth_p4080.c @@ -295,7 +295,6 @@ int board_eth_init(bd_t *bis) { #ifdef CONFIG_FMAN_ENET ccsr_gpio_t *pgpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR); - struct dtsec *tsec = (void *)CONFIG_SYS_FSL_FM1_DTSEC1_ADDR; int i; struct fsl_pq_mdio_info dtsec_mdio_info; struct tgec_mdio_info tgec_mdio_info; @@ -321,13 +320,6 @@ int board_eth_init(bd_t *bis) SLOT5, /* 17 - Bank 3:D */ }; - /* - * Set TBIPA on FM1@DTSEC1. This is needed for configurations - * where FM1@DTSEC1 isn't used directly, since it provides - * MDIO for other ports. - */ - out_be32(&tsec->tbipa, CONFIG_SYS_TBIPA_VALUE); - /* Initialize the mdio_mux array so we can recognize empty elements */ for (i = 0; i < NUM_FM_PORTS; i++) mdio_mux[i] = EMI_NONE; diff --git a/board/freescale/p2041rdb/eth.c b/board/freescale/p2041rdb/eth.c index 0a1dfa7..4b0d577 100644 --- a/board/freescale/p2041rdb/eth.c +++ b/board/freescale/p2041rdb/eth.c @@ -139,7 +139,6 @@ void board_ft_fman_fixup_port(void *fdt, char *compat, phys_addr_t addr, int board_eth_init(bd_t *bis) { #ifdef CONFIG_FMAN_ENET - struct dtsec *tsec = (void *)CONFIG_SYS_FSL_FM1_DTSEC1_ADDR; struct fsl_pq_mdio_info dtsec_mdio_info; struct tgec_mdio_info tgec_mdio_info; unsigned int i, slot; @@ -149,13 +148,6 @@ int board_eth_init(bd_t *bis) initialize_lane_to_slot(); - /* - * Set TBIPA on FM1@DTSEC1. This is needed for configurations - * where FM1@DTSEC1 isn't used directly, since it provides - * MDIO for other ports. - */ - out_be32(&tsec->tbipa, CONFIG_SYS_TBIPA_VALUE); - dtsec_mdio_info.regs = (struct tsec_mii_mng *)CONFIG_SYS_FM1_DTSEC1_MDIO_ADDR; dtsec_mdio_info.name = DEFAULT_FM_MDIO_NAME;
TBIPA has been set in dtsec_init_phy () funciton in drivers/net/fm/eth.c So remove the duplicate code on platform Ethernet code. Signed-off-by: Roy Zang <tie-fei.zang@freescale.com> Cc: Andy Fleming <afleming@freescale.com> Cc: Kumar Gala <galak@kernel.crashing.org> --- Tested on P5020DS board/freescale/corenet_ds/eth_hydra.c | 8 -------- board/freescale/corenet_ds/eth_p4080.c | 8 -------- board/freescale/p2041rdb/eth.c | 8 -------- 3 files changed, 0 insertions(+), 24 deletions(-)