From patchwork Fri Dec 13 09:55:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1209061 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-515860-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="SvfobKU2"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Z5gz5PNcz9sPT for ; Fri, 13 Dec 2019 20:57:51 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=HthHMnk9CHEUUQDBZ7ZhCEwAkx+xNvtHNvTZhe/zzVpOeVfg4E enZwyPZzaJ01Xdca33MT5DTADvUVqAYYOZuJgdRIFQEFTDFyBUxAeAfrUkn9uscn qGghfhaIik5kQVGPwV6ypge/iZ9f6DwOcuvtzZS1AJf2qYJVMwSs9A36M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=U++ql5DYqFXarbHmfR1V0zkd9mI=; b=SvfobKU2eaE+Qmh5+mBf 1BVJ/qA1aPAbAjL5gSFTrf9Jzj5CAV9vvgOw0Gs3bJam2ec0Tk97JhskUNy5NeqT N94gbDKNeKY8lztIXg4f0Pza0wpP9A/zEyASuYEvQfEIqSn4B7yLaCqhQYIbbpkG G/EpfDejGZoMpOfo4gOZvIc= Received: (qmail 37328 invoked by alias); 13 Dec 2019 09:55:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 37029 invoked by uid 89); 13 Dec 2019 09:55:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_NEUTRAL autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 09:55:11 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifhf9-0006RN-KI for gcc-patches@gcc.gnu.org; Fri, 13 Dec 2019 04:55:08 -0500 Received: from rock.gnat.com ([205.232.38.15]:60350) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifhf9-0006Q2-Ek for gcc-patches@gcc.gnu.org; Fri, 13 Dec 2019 04:55:07 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6C4B6560AD; Fri, 13 Dec 2019 04:55:02 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Xcwcj4hdX34q; Fri, 13 Dec 2019 04:55:02 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 11D24560D8; Fri, 13 Dec 2019 04:55:02 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4862) id 10E3A157; Fri, 13 Dec 2019 04:55:02 -0500 (EST) Date: Fri, 13 Dec 2019 04:55:02 -0500 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Eric Botcazou Subject: [Ada] Better error message for aliased formal and atomic actual Message-ID: <20191213095502.GA14067@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 205.232.38.15 X-IsSubscribed: yes The C.6 (12/3) clause makes it illegal to pass an atomic actual parameter in a call corresponding to an aliased formal with a nonatomic type. This illegal case had been accepted up recently and started only to be rejected as a by-product of the implementation of the C.6 (19) clause, but the error message is confusing. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-12-13 Eric Botcazou gcc/ada/ * sem_res.adb (Resolve_Actuals): Give canonical error for illegal case of atomic/volatile parameter also if the formal is aliased. --- gcc/ada/sem_res.adb +++ gcc/ada/sem_res.adb @@ -4717,7 +4717,7 @@ package body Sem_Res is -- Check bad case of atomic/volatile argument (RM C.6(12)) - if Is_By_Reference_Type (Etype (F)) + if (Is_By_Reference_Type (Etype (F)) or else Is_Aliased (F)) and then Comes_From_Source (N) then if Is_Atomic_Object (A)