From patchwork Fri Dec 13 08:12:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bibby Hsieh X-Patchwork-Id: 1208998 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-i2c-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mediatek.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.b="FMXvUrhT"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47Z3hd0p5yz9sNH for ; Fri, 13 Dec 2019 19:28:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726004AbfLMI2P (ORCPT ); Fri, 13 Dec 2019 03:28:15 -0500 Received: from mailgw01.mediatek.com ([216.200.240.184]:43114 "EHLO mailgw01.mediatek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfLMI2P (ORCPT ); Fri, 13 Dec 2019 03:28:15 -0500 X-UUID: e0fdef530b6f45f58233cc8956b986da-20191213 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=lKkeV3nCw5x6HxCAnKmQgdARAs1uYQI7FXqXaG/LuYg=; b=FMXvUrhTvIUhrKND2zJ0B85UJTAG5U3vPQEOedZiDtxWgASTI0/p8jb4mAID9/LoSZdw6TpUys1cbe5hZuV0YzdySl4c6uwYGvKrh6fD20UtKY82GyiQSD61EcaSKENRDrP1HCSRQurq3BR867Z81ney3Rl8KohWoCrytOU+/Yw=; X-UUID: e0fdef530b6f45f58233cc8956b986da-20191213 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1985132200; Fri, 13 Dec 2019 00:23:11 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Dec 2019 16:12:07 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Dec 2019 16:11:59 +0800 From: Bibby Hsieh To: Bartosz Golaszewski , CC: , , , , , , Bibby Hsieh Subject: [PATCH v8 4/4] i2c: core: support bus regulator controlling in adapter Date: Fri, 13 Dec 2019 16:12:30 +0800 Message-ID: <20191213081230.23494-5-bibby.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20191213081230.23494-1-bibby.hsieh@mediatek.com> References: <20191213081230.23494-1-bibby.hsieh@mediatek.com> MIME-Version: 1.0 X-MTK: N Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Although in the most platforms, the bus power of i2c are alway on, some platforms disable the i2c bus power in order to meet low power request. We get and enable bulk regulator in i2c adapter device. Signed-off-by: Bibby Hsieh --- drivers/i2c/i2c-core-base.c | 66 +++++++++++++++++++++++++++++++++++++ include/linux/i2c.h | 3 ++ 2 files changed, 69 insertions(+) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 9333c865d4a9..75f609d37ef3 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -306,6 +306,7 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client) static int i2c_device_probe(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; struct i2c_driver *driver; int status; @@ -371,6 +372,12 @@ static int i2c_device_probe(struct device *dev) dev_dbg(dev, "probe\n"); + status = regulator_enable(adap->bus_reg); + if (status != 0) { + dev_err(&adap->dev, "Failed to enable power regulator\n"); + goto err_clear_wakeup_irq; + } + status = of_clk_set_defaults(dev->of_node, false); if (status < 0) goto err_clear_wakeup_irq; @@ -407,6 +414,7 @@ static int i2c_device_probe(struct device *dev) static int i2c_device_remove(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; struct i2c_driver *driver; int status = 0; @@ -420,6 +428,8 @@ static int i2c_device_remove(struct device *dev) } dev_pm_domain_detach(&client->dev, true); + if (pm_runtime_status_suspended(&adap->dev)) + regulator_disable(adap->bus_reg); dev_pm_clear_wake_irq(&client->dev); device_init_wakeup(&client->dev, false); @@ -431,6 +441,54 @@ static int i2c_device_remove(struct device *dev) return status; } +#ifdef CONFIG_PM_SLEEP +static int i2c_resume(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; + + return pm_generic_resume(&adap->dev); +} + +static int i2c_suspend(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; + + return pm_generic_suspend(&adap->dev); +} +#endif + +#ifdef CONFIG_PM +static int i2c_runtime_resume(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; + + pm_generic_runtime_resume(&adap->dev); + + return regulator_enable(adap->bus_reg); +} + +static int i2c_runtime_suspend(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap = client->adapter; + + pm_generic_runtime_suspend(&adap->dev); + + if (pm_runtime_status_suspended(&adap->dev)) + return regulator_disable(client->adapter->bus_reg); + + return 0; +} +#endif + +static const struct dev_pm_ops i2c_device_pm = { + SET_SYSTEM_SLEEP_PM_OPS(i2c_suspend, i2c_resume) + SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL) +}; + static void i2c_device_shutdown(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); @@ -488,6 +546,7 @@ struct bus_type i2c_bus_type = { .probe = i2c_device_probe, .remove = i2c_device_remove, .shutdown = i2c_device_shutdown, + .pm = &i2c_device_pm, }; EXPORT_SYMBOL_GPL(i2c_bus_type); @@ -1351,6 +1410,12 @@ static int i2c_register_adapter(struct i2c_adapter *adap) goto out_reg; dev_dbg(&adap->dev, "adapter [%s] registered\n", adap->name); + adap->bus_reg = devm_regulator_get(&adap->dev, "bus"); + if (IS_ERR(adap->bus_reg)) { + dev_err(&adap->dev, "failed to get adapter bus regulator\n"); + res = PTR_ERR(adap->bus_reg); + goto out_reg; + } pm_runtime_no_callbacks(&adap->dev); pm_suspend_ignore_children(&adap->dev, true); @@ -1580,6 +1645,7 @@ void i2c_del_adapter(struct i2c_adapter *adap) dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name); pm_runtime_disable(&adap->dev); + devm_regulator_put(adap->bus_reg); i2c_host_notify_irq_teardown(adap); diff --git a/include/linux/i2c.h b/include/linux/i2c.h index d2f786706657..833b81a680da 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -15,6 +15,7 @@ #include /* for struct device */ #include /* for completion */ #include +#include #include #include /* for Host Notify IRQ */ #include /* for struct device_node */ @@ -330,6 +331,7 @@ struct i2c_client { int init_irq; /* irq set at initialization */ int irq; /* irq issued by device */ struct list_head detected; + #if IS_ENABLED(CONFIG_I2C_SLAVE) i2c_slave_cb_t slave_cb; /* callback for slave mode */ #endif @@ -723,6 +725,7 @@ struct i2c_adapter { const struct i2c_adapter_quirks *quirks; struct irq_domain *host_notify_domain; + struct regulator *bus_reg; }; #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)