| Message ID | 0b095b65496073a2ddf9de120f7809619b42cd1c.1576211720.git.saiprakash.ranjan@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Convert QCOM watchdog timer bindings to YAML | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 2 warnings, 47 lines checked" |
| robh/dt-meta-schema | fail | build log |
On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote: > Convert QCOM watchdog timer bindings to DT schema format using > json-schema. > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > --- > .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ----------- > .../bindings/watchdog/qcom-wdt.yaml | 47 +++++++++++++++++++ > 2 files changed, 47 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > new file mode 100644 > index 000000000000..4a42f4261322 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer > + > +maintainers: > + - Andy Gross <agross@kernel.org> > + > +properties: > + compatible: > + oneOf: > + - const: qcom,kpss-timer > + - const: qcom,kpss-wdt > + - const: qcom,kpss-wdt-apq8064 > + - const: qcom,kpss-wdt-ipq4019 > + - const: qcom,kpss-wdt-ipq8064 > + - const: qcom,kpss-wdt-msm8960 > + - const: qcom,scss-timer An 'enum' is better than oneOf+const. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + timeout-sec: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Contains the watchdog timeout in seconds. If unset, the > + default timeout is 30 seconds. Include watchdog.yaml and don't redefine this. > + > +required: > + - compatible > + - reg > + - clocks > + > +examples: > + - | > + watchdog@208a038 { > + compatible = "qcom,kpss-wdt-ipq8064"; > + reg = <0x0208a038 0x40>; > + clocks = <&sleep_clk>; > + timeout-sec = <10>; > + }; > --- > > I have added Andy as the maintainer here since the get_maintainer script > showed him. If he is not happy, then I can change it to Bjorn probably and > again if he is not happy ;-) then I will add myself or whoever they suggest. Add yourself. Rob
On 2019-12-20 04:56, Rob Herring wrote: > On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote: >> Convert QCOM watchdog timer bindings to DT schema format using >> json-schema. >> >> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> >> --- >> .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ----------- >> .../bindings/watchdog/qcom-wdt.yaml | 47 >> +++++++++++++++++++ >> 2 files changed, 47 insertions(+), 28 deletions(-) >> delete mode 100644 >> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt >> create mode 100644 >> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > > >> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml >> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml >> new file mode 100644 >> index 000000000000..4a42f4261322 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml >> @@ -0,0 +1,47 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer >> + >> +maintainers: >> + - Andy Gross <agross@kernel.org> >> + >> +properties: >> + compatible: >> + oneOf: >> + - const: qcom,kpss-timer >> + - const: qcom,kpss-wdt >> + - const: qcom,kpss-wdt-apq8064 >> + - const: qcom,kpss-wdt-ipq4019 >> + - const: qcom,kpss-wdt-ipq8064 >> + - const: qcom,kpss-wdt-msm8960 >> + - const: qcom,scss-timer > > An 'enum' is better than oneOf+const. > Will change. >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + timeout-sec: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + Contains the watchdog timeout in seconds. If unset, the >> + default timeout is 30 seconds. > > Include watchdog.yaml and don't redefine this. > Ok >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + >> +examples: >> + - | >> + watchdog@208a038 { >> + compatible = "qcom,kpss-wdt-ipq8064"; >> + reg = <0x0208a038 0x40>; >> + clocks = <&sleep_clk>; >> + timeout-sec = <10>; >> + }; >> --- >> >> I have added Andy as the maintainer here since the get_maintainer >> script >> showed him. If he is not happy, then I can change it to Bjorn probably >> and >> again if he is not happy ;-) then I will add myself or whoever they >> suggest. > > Add yourself. > Sure will add myself. Thanks, Sai
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt deleted file mode 100644 index 41aeaa2ff0f8..000000000000 --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt +++ /dev/null @@ -1,28 +0,0 @@ -Qualcomm Krait Processor Sub-system (KPSS) Watchdog ---------------------------------------------------- - -Required properties : -- compatible : shall contain only one of the following: - - "qcom,kpss-wdt-msm8960" - "qcom,kpss-wdt-apq8064" - "qcom,kpss-wdt-ipq8064" - "qcom,kpss-wdt-ipq4019" - "qcom,kpss-timer" - "qcom,scss-timer" - "qcom,kpss-wdt" - -- reg : shall contain base register location and length -- clocks : shall contain the input clock - -Optional properties : -- timeout-sec : shall contain the default watchdog timeout in seconds, - if unset, the default timeout is 30 seconds - -Example: - watchdog@208a038 { - compatible = "qcom,kpss-wdt-ipq8064"; - reg = <0x0208a038 0x40>; - clocks = <&sleep_clk>; - timeout-sec = <10>; - }; diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml new file mode 100644 index 000000000000..4a42f4261322 --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer + +maintainers: + - Andy Gross <agross@kernel.org> + +properties: + compatible: + oneOf: + - const: qcom,kpss-timer + - const: qcom,kpss-wdt + - const: qcom,kpss-wdt-apq8064 + - const: qcom,kpss-wdt-ipq4019 + - const: qcom,kpss-wdt-ipq8064 + - const: qcom,kpss-wdt-msm8960 + - const: qcom,scss-timer + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + timeout-sec: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Contains the watchdog timeout in seconds. If unset, the + default timeout is 30 seconds. + +required: + - compatible + - reg + - clocks + +examples: + - | + watchdog@208a038 { + compatible = "qcom,kpss-wdt-ipq8064"; + reg = <0x0208a038 0x40>; + clocks = <&sleep_clk>; + timeout-sec = <10>; + };
Convert QCOM watchdog timer bindings to DT schema format using json-schema. Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> --- .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ----------- .../bindings/watchdog/qcom-wdt.yaml | 47 +++++++++++++++++++ 2 files changed, 47 insertions(+), 28 deletions(-) delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml --- I have added Andy as the maintainer here since the get_maintainer script showed him. If he is not happy, then I can change it to Bjorn probably and again if he is not happy ;-) then I will add myself or whoever they suggest. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation