From patchwork Thu Oct 20 16:17:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 120836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CC4EFB70C5 for ; Fri, 21 Oct 2011 03:19:21 +1100 (EST) Received: from localhost ([::1]:35123 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGvKr-0004zZ-Mc for incoming@patchwork.ozlabs.org; Thu, 20 Oct 2011 12:19:13 -0400 Received: from eggs.gnu.org ([140.186.70.92]:49602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGvKf-0004yY-Mu for qemu-devel@nongnu.org; Thu, 20 Oct 2011 12:19:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGvKe-0003Mp-IN for qemu-devel@nongnu.org; Thu, 20 Oct 2011 12:19:01 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:57076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGvKd-0003LC-Na for qemu-devel@nongnu.org; Thu, 20 Oct 2011 12:19:00 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp06.au.ibm.com (8.14.4/8.13.1) with ESMTP id p9KGHVlK004065 for ; Fri, 21 Oct 2011 03:17:31 +1100 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9KGIjmB2253016 for ; Fri, 21 Oct 2011 03:18:45 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9KGIjj0022588 for ; Fri, 21 Oct 2011 03:18:45 +1100 Received: from skywalker.ibm.com ([9.124.88.106]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p9KGIdIx021047; Fri, 21 Oct 2011 03:18:43 +1100 From: "Aneesh Kumar K.V" To: qemu-devel@nongnu.org Date: Thu, 20 Oct 2011 21:47:34 +0530 Message-Id: <1319127460-5181-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1319127460-5181-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> References: <1319127460-5181-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 202.81.31.148 Cc: aliguori@us.ibm.com, "Aneesh Kumar K.V" Subject: [Qemu-devel] [PATCH 2/8] configure: Update configure so that open_by_handle_at check returns correct value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "Aneesh Kumar K.V" According to David Gibson for some compiler/libc combinations, open_by_handle_at test in configure isn't quite right: because the file_handle pointer is never dereferenced, gcc doesn't complain even if it is undefined. Change the test as suggested by him. Signed-off-by: Aneesh Kumar K.V --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index 4f87e0a..19e8394 100755 --- a/configure +++ b/configure @@ -2562,7 +2562,7 @@ fi open_by_hande_at=no cat > $TMPC << EOF #include -int main(void) { struct file_handle *fh; open_by_handle_at(0, fh, 0); } +int main(void) { struct file_handle fh; open_by_handle_at(0, &fh, 0); } EOF if compile_prog "" "" ; then open_by_handle_at=yes