[testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX

Message ID	201110201614.p9KGEic20374@adlwrk05.cce.hp.com
State	New
Headers	show Return-Path: <gcc-patches-return-305090-incoming=patchwork.ozlabs.org@gcc.gnu.org> Date: Thu, 20 Oct 2011 09:14:44 -0700 (PDT) From: Steve Ellcey <sje@cup.hp.com> Message-Id: <201110201614.p9KGEic20374@adlwrk05.cce.hp.com> To: gcc-patches@gcc.gnu.org Subject: [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX Reply-to: sje@cup.hp.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org

Message ID

201110201614.p9KGEic20374@adlwrk05.cce.hp.com

State

New

Headers

Date: Thu, 20 Oct 2011 09:14:44 -0700 (PDT)
From: Steve Ellcey <sje@cup.hp.com>
Message-Id: <201110201614.p9KGEic20374@adlwrk05.cce.hp.com>
To: gcc-patches@gcc.gnu.org
Subject: [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX
Reply-to: sje@cup.hp.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org

Commit Message

Steve Ellcey Oct. 20, 2011, 4:14 p.m. UTC

I am going to check this change in as obvious later today if there are
no objections,  the test gives warnings on HP-UX because it calls
__builtin_return_address with arguments of 0 through 5 but the value 0
is the only valid argument to __builtin_return_address on HP-UX.

Tested on IA64 and PA HP-UX.

Steve Ellcey
sje@cup.hp.com



2011-10-20  Steve Ellcey  <sje@cup.hp.com>

	PR testsuite/50722
	* gcc.dg/pr49994-3.c: Skip on HP-UX.

Comments

Rainer Orth Oct. 20, 2011, 4:23 p.m. UTC | #1

Steve Ellcey <sje@cup.hp.com> writes:

> Index: gcc.dg/pr49994-3.c
> ===================================================================
> --- gcc.dg/pr49994-3.c	(revision 180233)
> +++ gcc.dg/pr49994-3.c	(working copy)
> @@ -2,6 +2,7 @@
>  /* { dg-options "-O2 -fsched2-use-superblocks -g" } */
>  /* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
>  /* { dg-require-effective-target scheduling } */
> +/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */

Would you please include either an explanation or a PR reference in the
dg-skip-if?  Having to search the archives for an explanation is tedious.

Btw., you should be able to omit both the "*" and "".

Thanks.
        Rainer

Steve Ellcey Oct. 20, 2011, 9:27 p.m. UTC | #2

On Thu, 2011-10-20 at 18:23 +0200, Rainer Orth wrote:
> Steve Ellcey <sje@cup.hp.com> writes:
> 
> > Index: gcc.dg/pr49994-3.c
> > ===================================================================
> > --- gcc.dg/pr49994-3.c	(revision 180233)
> > +++ gcc.dg/pr49994-3.c	(working copy)
> > @@ -2,6 +2,7 @@
> >  /* { dg-options "-O2 -fsched2-use-superblocks -g" } */
> >  /* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
> >  /* { dg-require-effective-target scheduling } */
> > +/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */
> 
> Would you please include either an explanation or a PR reference in the
> dg-skip-if?  Having to search the archives for an explanation is tedious.
> 
> Btw., you should be able to omit both the "*" and "".
> 
> Thanks.
>         Rainer

I put "PR testsuite/50722" in the comment section and removed the "*"
and "" after verifying that it works and then checked in the change.

Steve Ellcey
sje@cup.hp.com

Index: gcc.dg/pr49994-3.c
===================================================================
--- gcc.dg/pr49994-3.c	(revision 180233)
+++ gcc.dg/pr49994-3.c	(working copy)
@@ -2,6 +2,7 @@ 
 /* { dg-options "-O2 -fsched2-use-superblocks -g" } */
 /* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
 /* { dg-require-effective-target scheduling } */
+/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */
 
 void *
 foo (int offset)