| Message ID | 20191212091527.35293-1-yuehaibing@huawei.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: Remove unused including <linux/version.h> | expand |
On Thu, Dec 12, 2019 at 10:18 AM YueHaibing <yuehaibing@huawei.com> wrote: > > Remove including <linux/version.h> that don't need it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Thanks. Committed with some wording changes to wireguard-linux.git for staging: https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/wireguard-linux.git/commit/?id=062fd1993cdbf64a57395320c719e58b9a75b767 I'll re-send this to net-next as part of a cleanup series I'm preparing in a few days. Jason
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 12 Dec 2019 09:15:27 +0000 > Remove including <linux/version.h> that don't need it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Appropriate subject line for this should have been: Subject: [PATCH net-next] wireguard: Remove unused include <linux/version.h> 'net' is too broad a subsystem prefix as it basically encompases half of the entire kernel tree. When people look at the git shortlog output you need to be specific enough that people can tell what touches what.
Hi Dave, On Thu, Dec 12, 2019 at 7:53 PM David Miller <davem@davemloft.net> wrote: > > From: YueHaibing <yuehaibing@huawei.com> > Date: Thu, 12 Dec 2019 09:15:27 +0000 > > > Remove including <linux/version.h> that don't need it. > > > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > Appropriate subject line for this should have been: > > Subject: [PATCH net-next] wireguard: Remove unused include <linux/version.h> > > 'net' is too broad a subsystem prefix as it basically encompases half of the > entire kernel tree. When people look at the git shortlog output you need to > be specific enough that people can tell what touches what. I have these fixed up how you like in the wireguard-linux.git repo, and I'll submit these in a series to net-next next week all together. https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/wireguard-linux.git/log Jason
diff --git a/drivers/net/wireguard/main.c b/drivers/net/wireguard/main.c index 10c0a40f6a9e..7a7d5f1a80fc 100644 --- a/drivers/net/wireguard/main.c +++ b/drivers/net/wireguard/main.c @@ -12,7 +12,6 @@ #include <uapi/linux/wireguard.h> -#include <linux/version.h> #include <linux/init.h> #include <linux/module.h> #include <linux/genetlink.h>
Remove including <linux/version.h> that don't need it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/net/wireguard/main.c | 1 - 1 file changed, 1 deletion(-)