| Message ID | 20191211192742.95699-2-brendanhiggins@google.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | uml: add unspecified HAS_IOMEM dependencies | expand |
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins <brendanhiggins@google.com> wrote: > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> We recently fixed a compile error by adding depends on OF and I think OF implies HAS_IOMEM so this should be fixed now. Can you confirm? Yours, Linus Walleij
On Mon, Dec 16, 2019 at 9:42 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > We recently fixed a compile error by adding > depends on OF > and I think OF implies HAS_IOMEM so this should be fixed > now. > > Can you confirm? I'm fairly sure it does not, so both patches are needed. Arnd
On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins <brendanhiggins@google.com> wrote: > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > the following build error: > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Patch applied but I augmented it with the recently added OF dependency so it now says: depends on OF && HAS_IOMEM Yours, Linus Walleij
Sorry for not getting to this before I went on vacation. On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > Patch applied but I augmented it with the recently added > OF dependency so it now says: > depends on OF && HAS_IOMEM Probably too late now to be helpful, but I can confirm that OF does NOT depend on HAS_IOMEM, so this patch was still needed. Thanks regardless!
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 3bfbf2ff6e2bd..2c0b30477f7d0 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -422,6 +422,7 @@ config PINCTRL_TB10X config PINCTRL_EQUILIBRIUM tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC" + depends on HAS_IOMEM select PINMUX select PINCONF select GPIOLIB
Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. Reported-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)