| Message ID | 20191211192742.95699-4-brendanhiggins@google.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | uml: add unspecified HAS_IOMEM dependencies | expand |
> -----Original Message----- > From: Brendan Higgins <brendanhiggins@google.com> > Sent: Thursday, December 12, 2019 12:58 AM > To: jdike@addtoit.com; richard@nod.at; > anton.ivanov@cambridgegreys.com; David S. Miller > <davem@davemloft.net>; Michal Simek <michals@xilinx.com>; Radhey > Shyam Pandey <radheys@xilinx.com> > Cc: linux-um@lists.infradead.org; linux-kernel@vger.kernel.org; > davidgow@google.com; Brendan Higgins <brendanhiggins@google.com>; > netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM > dependency > > Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we > get > the following build error: > > ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function > `axienet_probe': > drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference > to `devm_ioremap_resource' > ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined > reference to `devm_ioremap_resource' > ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined > reference to `devm_ioremap_resource' > > Fix the build error by adding the unspecified dependency. > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> Thanks! > --- > drivers/net/ethernet/xilinx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/xilinx/Kconfig > b/drivers/net/ethernet/xilinx/Kconfig > index 6304ebd8b5c69..b1a285e693756 100644 > --- a/drivers/net/ethernet/xilinx/Kconfig > +++ b/drivers/net/ethernet/xilinx/Kconfig > @@ -25,6 +25,7 @@ config XILINX_EMACLITE > > config XILINX_AXI_EMAC > tristate "Xilinx 10/100/1000 AXI Ethernet support" > + depends on HAS_IOMEM > select PHYLINK > ---help--- > This driver supports the 10/100/1000 Ethernet from Xilinx for the > -- > 2.24.0.525.g8f36a354ae-goog
diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig index 6304ebd8b5c69..b1a285e693756 100644 --- a/drivers/net/ethernet/xilinx/Kconfig +++ b/drivers/net/ethernet/xilinx/Kconfig @@ -25,6 +25,7 @@ config XILINX_EMACLITE config XILINX_AXI_EMAC tristate "Xilinx 10/100/1000 AXI Ethernet support" + depends on HAS_IOMEM select PHYLINK ---help--- This driver supports the 10/100/1000 Ethernet from Xilinx for the
Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe': drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource' ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource' ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins <brendanhiggins@google.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> --- drivers/net/ethernet/xilinx/Kconfig | 1 + 1 file changed, 1 insertion(+)