pinctrl: rza1: reduce printed messages
diff mbox series

Message ID 20191211160638.31853-1-chris.brandt@renesas.com
State New
Headers show
Series
  • pinctrl: rza1: reduce printed messages
Related show

Commit Message

Chris Brandt Dec. 11, 2019, 4:06 p.m. UTC
Since this message is printed for each port, it creates a lot of output
during boot and would serve better only during debugging.

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 drivers/pinctrl/pinctrl-rza1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Dec. 12, 2019, 9:44 a.m. UTC | #1
Hi Chris,

On Wed, Dec 11, 2019 at 11:06:38AM -0500, Chris Brandt wrote:
> Since this message is printed for each port, it creates a lot of output
> during boot and would serve better only during debugging.
>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Seems fair

> ---
>  drivers/pinctrl/pinctrl-rza1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
> index 017fc6b3e27e..86e5bf59bde5 100644
> --- a/drivers/pinctrl/pinctrl-rza1.c
> +++ b/drivers/pinctrl/pinctrl-rza1.c
> @@ -1235,7 +1235,7 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,
>
>  	pinctrl_add_gpio_range(rza1_pctl->pctl, range);
>
> -	dev_info(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
> +	dev_dbg(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
>  		 chip->label, chip->ngpio);

Please align this line to the open ( ... Sorry to bother for such
minor thing.

There are other dev_info which might show up frequently, I'm
looking at line 1054 in example. I think it's fine as they show the
actually enabled groups...

Anway, minor alignement issue apart
Acked-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
   j
>
>  	return 0;
> --
> 2.23.0
>
Chris Brandt Dec. 12, 2019, 1:44 p.m. UTC | #2
Hi Jacopo,

On Thu, Dec 12, 2019, Jacopo Mondi wrote:
> > -	dev_info(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
> > +	dev_dbg(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
> >  		 chip->label, chip->ngpio);
> 
> Please align this line to the open ( ... Sorry to bother for such minor thing.

Fair point!
I'll fix and resend.

> There are other dev_info which might show up frequently, I'm looking at line
> 1054 in example. I think it's fine as they show the actually enabled groups...

Ya, I'm OK that. When checking someone's logs, I can see if they actually enabled
the pins or not.

I was just annoyed by all the text about registering the ports....that comes from
the .dtsi that no one every changes.....and I was scrolling though trying to find
my print debug messages for another driver I was debugging   :o


> Anway, minor alignement issue apart
> Acked-by: Jacopo Mondi <jacopo@jmondi.org>


Thank you.
I'll resend with your ACK


Chris

Patch
diff mbox series

diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index 017fc6b3e27e..86e5bf59bde5 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -1235,7 +1235,7 @@  static int rza1_parse_gpiochip(struct rza1_pinctrl *rza1_pctl,
 
 	pinctrl_add_gpio_range(rza1_pctl->pctl, range);
 
-	dev_info(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
+	dev_dbg(rza1_pctl->dev, "Parsed gpiochip %s with %d pins\n",
 		 chip->label, chip->ngpio);
 
 	return 0;