| Message ID | 1576069760-11473-15-git-send-email-yamonkar@cadence.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | PHY: Update Cadence Torrent PHY driver with reconfiguration | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Wed, Dec 11, 2019 at 02:09:19PM +0100, Yuti Amonkar wrote: > Add a new compatible string used for TI SoCs using Torrent PHY. > > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> > --- > Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > index 8069498..60e024b 100644 > --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > @@ -15,7 +15,9 @@ maintainers: > > properties: > compatible: > - const: cdns,torrent-phy > + anyOf: Should be an enum or if both strings can be present then you need 2 oneOf entries for 1 string and 2 strings. > + - const: cdns,torrent-phy > + - const: ti,j721e-serdes-10g > > clocks: > maxItems: 1 > -- > 2.7.4 >
Hi, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, December 20, 2019 2:56 > To: Yuti Suresh Amonkar <yamonkar@cadence.com> > Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > kishon@ti.com; mark.rutland@arm.com; jsarha@ti.com; > tomi.valkeinen@ti.com; praneeth@ti.com; Milind Parab > <mparab@cadence.com>; Swapnil Kashinath Jakhade > <sjakhade@cadence.com> > Subject: Re: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence- > torrent: Add platform dependent compatible string > > EXTERNAL MAIL > > > On Wed, Dec 11, 2019 at 02:09:19PM +0100, Yuti Amonkar wrote: > > Add a new compatible string used for TI SoCs using Torrent PHY. > > > > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> > > --- > > Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 > > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > index 8069498..60e024b 100644 > > --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > +++ b/Documentation/devicetree/bindings/phy/phy-cadence- > torrent.yaml > > @@ -15,7 +15,9 @@ maintainers: > > > > properties: > > compatible: > > - const: cdns,torrent-phy > > + anyOf: > > Should be an enum or if both strings can be present then you need 2 oneOf > entries for 1 string and 2 strings. > We can have only one compatible string at a time, so should I use like this? compatible: enum: - cdns,torrent-phy - ti,j721e-serdes-10g > > + - const: cdns,torrent-phy > > + - const: ti,j721e-serdes-10g > > > > clocks: > > maxItems: 1 > > -- > > 2.7.4 > > Thanks & Regards, Yuti Amonkar
On Fri, Dec 20, 2019 at 2:43 AM Yuti Suresh Amonkar <yamonkar@cadence.com> wrote: > > Hi, > > > -----Original Message----- > > From: Rob Herring <robh@kernel.org> > > Sent: Friday, December 20, 2019 2:56 > > To: Yuti Suresh Amonkar <yamonkar@cadence.com> > > Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > > kishon@ti.com; mark.rutland@arm.com; jsarha@ti.com; > > tomi.valkeinen@ti.com; praneeth@ti.com; Milind Parab > > <mparab@cadence.com>; Swapnil Kashinath Jakhade > > <sjakhade@cadence.com> > > Subject: Re: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence- > > torrent: Add platform dependent compatible string > > > > EXTERNAL MAIL > > > > > > On Wed, Dec 11, 2019 at 02:09:19PM +0100, Yuti Amonkar wrote: > > > Add a new compatible string used for TI SoCs using Torrent PHY. > > > > > > Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> > > > --- > > > Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 > > > +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > > b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > > index 8069498..60e024b 100644 > > > --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml > > > +++ b/Documentation/devicetree/bindings/phy/phy-cadence- > > torrent.yaml > > > @@ -15,7 +15,9 @@ maintainers: > > > > > > properties: > > > compatible: > > > - const: cdns,torrent-phy > > > + anyOf: > > > > Should be an enum or if both strings can be present then you need 2 oneOf > > entries for 1 string and 2 strings. > > > > We can have only one compatible string at a time, so should I use like this? > > compatible: > enum: > - cdns,torrent-phy > - ti,j721e-serdes-10g Yes.
diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml index 8069498..60e024b 100644 --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml @@ -15,7 +15,9 @@ maintainers: properties: compatible: - const: cdns,torrent-phy + anyOf: + - const: cdns,torrent-phy + - const: ti,j721e-serdes-10g clocks: maxItems: 1
Add a new compatible string used for TI SoCs using Torrent PHY. Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> --- Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)