diff mbox series

[committed] libgomp – spelling fixes, incl. omp_lib.h.in

Message ID 3d793b85-e7f8-f1e3-a49c-74ac85249574@codesourcery.com
State New
Headers show
Series [committed] libgomp – spelling fixes, incl. omp_lib.h.in | expand

Commit Message

Tobias Burnus Dec. 11, 2019, 11:48 a.m. UTC
This patch fixes various comment typos – and:

* omp_lib.h.in (Fortran): omp_get_cancell(l)ation – this typo could 
break user code; the test suite has 'use omp_lib' (i.e. the module) and 
not the #include file; hence, it didn't fail there.

* libgomp.texi: This one is also user visible.

Committed as Rev. 279218.

Tobias

Comments

Jakub Jelinek Dec. 11, 2019, 11:53 a.m. UTC | #1
On Wed, Dec 11, 2019 at 12:48:10PM +0100, Tobias Burnus wrote:
> --- libgomp/ChangeLog	(revision 279217)
> +++ libgomp/ChangeLog	(revision 279218)
> @@ -1,5 +1,25 @@
>  2019-12-11  Tobias Burnus  <tobias@codesourcery.com>
>  
> +	* omp_lib.h.in: Fix spelling of function declaration
> +	omp_get_cancell(l)ation.

> --- libgomp/omp_lib.h.in	(revision 279217)
> +++ libgomp/omp_lib.h.in	(revision 279218)
> @@ -102,8 +102,8 @@
>        external omp_in_final
>        logical(4) omp_in_final
>  
> -      external omp_get_cancelllation
> -      logical(4) omp_get_cancelllation
> +      external omp_get_cancellation
> +      logical(4) omp_get_cancellation
>  
>        external omp_get_proc_bind
>        integer(omp_proc_bind_kind) omp_get_proc_bind

Could you please backport this to 9 and 8 branches?  The other changes
aren't needed there.

Thanks.

	Jakub
diff mbox series

Patch

Index: libgomp/team.c
===================================================================
--- libgomp/team.c	(revision 279217)
+++ libgomp/team.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles the maintainence of threads in response to team
+/* This file handles the maintenance of threads in response to team
    creation and termination.  */
 
 #include "libgomp.h"
Index: libgomp/ChangeLog
===================================================================
--- libgomp/ChangeLog	(revision 279217)
+++ libgomp/ChangeLog	(revision 279218)
@@ -1,5 +1,25 @@ 
 2019-12-11  Tobias Burnus  <tobias@codesourcery.com>
 
+	* omp_lib.h.in: Fix spelling of function declaration
+	omp_get_cancell(l)ation.
+	* libgomp.texi (acc_is_present, acc_async_test, acc_async_test_all):
+	Fix typos.
+	* env.c: Fix comment typos.
+	* oacc-host.c: Likewise.
+	* ordered.c: Likewise.
+	* task.c: Likewise.
+	* team.c: Likewise.
+	* config/gcn/task.c: Likewise.
+	* config/gcn/team.c: Likewise.
+	* config/nvptx/task.c: Likewise.
+	* config/nvptx/team.c: Likewise.
+	* plugin/plugin-gcn.c: Likewise.
+	* testsuite/libgomp.fortran/jacobi.f: Likewise.
+	* testsuite/libgomp.hsa.c/tiling-2.c: Likewise.
+	* testsuite/libgomp.oacc-c-c++-common/enter_exit-lib.c: Likewise.
+
+2019-12-11  Tobias Burnus  <tobias@codesourcery.com>
+
 	* testsuite/libgomp.oacc-fortran/optional-cache.f95: Add 'dg-do run'.
 	* testsuite/libgomp.oacc-fortran/optional-reduction.f90: Remove
 	unnecessary 'dg-additional-options "-w"'.
@@ -1235,7 +1255,7 @@ 
 	(host_openacc_async_construct): New function.
 	(host_openacc_async_destruct): New function.
 	(struct gomp_device_descr host_dispatch): Remove initialization of old
-	interface, add intialization of new async sub-struct.
+	interface, add initialization of new async sub-struct.
 	* oacc-init.c (acc_shutdown_1): Adjust to use gomp_fini_device.
 	(goacc_attach_host_thread_to_device): Remove old async code usage.
 	* oacc-int.h (goacc_init_asyncqueues): New declaration.
@@ -6373,7 +6393,7 @@ 
 	* libgomp_g.h (GOACC_parallel): Remove.
 	(GOACC_parallel_keyed): Declare.
 	* plugin/plugin-nvptx.c (struct targ_fn_launch): New struct.
-	(stuct targ_gn_descriptor): Replace name field with launch field.
+	(struct targ_gn_descriptor): Replace name field with launch field.
 	(nvptx_exec): Lose separate geometry args, take array.  Process
 	dynamic dimensions and adjust.
 	(struct nvptx_tdata): Replace fn_names field with fn_descs.
@@ -6394,7 +6414,7 @@ 
 2015-09-08  Aditya Kumar  <hiraditya@msn.com>
 	    Sebastian Pop  <s.pop@samsung.com>
 
-	* testsuite/libgomp.graphite/bounds.c (int foo): Modifed test case to
+	* testsuite/libgomp.graphite/bounds.c (int foo): Modified test case to
 	match o/p.
 	* testsuite/libgomp.graphite/force-parallel-1.c (void parloop): Same.
 	* testsuite/libgomp.graphite/force-parallel-4.c: Same.
@@ -6671,7 +6691,7 @@ 
 	* target.c (struct offload_image_descr): Constify target_data.
 	(gomp_offload_image_to_device): Likewise.
 	(GOMP_offload_register): Likewise.
-	(GOMP_offload_unrefister): Likewise.
+	(GOMP_offload_unregister): Likewise.
 	* plugin/plugin-host.c (GOMP_OFFLOAD_load_image,
 	GOMP_OFFLOAD_unload_image): Constify target data.
 	* plugin/plugin-nvptx.c (struct ptx_image_data): Constify target data.
@@ -7997,7 +8017,7 @@ 
 2014-12-12  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
 
 	* testsuite/lib/libgomp.exp: Load target-utils.exp.
-	Move load of target-supportes.exp earlier.
+	Move load of target-supports.exp earlier.
 
 2014-12-10  Ilya Verbin  <ilya.verbin@intel.com>
 
@@ -8484,7 +8504,7 @@ 
 
 2013-12-17  Andreas Tobler  <andreast@gcc.gnu.org>
 
-	* testsuite/libgomp.c/affinity-1.c: Remove alloca.h inlcude. Replace
+	* testsuite/libgomp.c/affinity-1.c: Remove alloca.h include. Replace
 	alloca () with __builtin_alloca ().
 	* testsuite/libgomp.c/icv-2.c: Add FreeBSD coverage.
 	* testsuite/libgomp.c/lock-3.c: Likewise.
@@ -8644,7 +8664,7 @@ 
 	(gomp_team_end): Use gomp_managed_threads_lock instead of
 	gomp_remaining_threads_lock.  Use gomp_team_barrier_wait_final instead
 	of gomp_team_barrier_wait.  If team->team_cancelled, call
-	gomp_fini_worshare on ws chain starting at team->work_shares_to_free
+	gomp_fini_workshare on ws chain starting at team->work_shares_to_free
 	rather than thr->ts.work_share.
 	(initialize_team): Don't call gomp_sem_init here.
 	* sections.c (GOMP_parallel_sections_start): Adjust gomp_team_start
@@ -12019,7 +12039,7 @@ 
 
 	* configure.ac: Determine whether -pthread or -lpthread is needed.
 	* Makefile.am (libgomp_la_LDFLAGS): Remove explicit -lpthread.
-	* Makefine.in, configure: Rebuild.
+	* Makefile.in, configure: Rebuild.
 
 2005-09-28  Richard Henderson  <rth@redhat.com>
 
Index: libgomp/testsuite/libgomp.fortran/jacobi.f
===================================================================
--- libgomp/testsuite/libgomp.fortran/jacobi.f	(revision 279217)
+++ libgomp/testsuite/libgomp.fortran/jacobi.f	(revision 279218)
@@ -11,7 +11,7 @@ 
 * Author:   Joseph Robicheaux, Kuck and Associates, Inc. (KAI), 1998
 * 
 * Directives are used in this code to achieve paralleism. 
-* All do loops are parallized with default 'static' scheduling.
+* All do loops are parallelized with default 'static' scheduling.
 * 
 * Input :  n - grid dimension in x direction 
 *          m - grid dimension in y direction
@@ -70,7 +70,7 @@ 
       subroutine driver ( ) 
 *************************************************************
 * Subroutine driver () 
-* This is where the arrays are allocated and initialzed. 
+* This is where the arrays are allocated and initialized.
 *
 * Working varaibles/arrays 
 *     dx  - grid spacing in x direction 
@@ -119,7 +119,7 @@ 
       dx = 2.0 / (n-1)
       dy = 2.0 / (m-1)
 
-* Initilize initial condition and RHS
+* Initialize initial condition and RHS
 
 !$omp parallel do private(xx,yy)
       do j = 1,m
Index: libgomp/testsuite/libgomp.hsa.c/tiling-2.c
===================================================================
--- libgomp/testsuite/libgomp.hsa.c/tiling-2.c	(revision 279217)
+++ libgomp/testsuite/libgomp.hsa.c/tiling-2.c	(revision 279218)
@@ -167,7 +167,7 @@ 
 
 // -------------------------------------------------------------------
 //      The rest of this code forms the HSAIL kernel with the
-//      pairs of "paralell for collapse(2)" loops repalced with a barrier.
+//      pairs of "parallel for collapse(2)" loops replaced with a barrier.
 //      The kernel initializes these values
 //      C_row_start = get_group_id(0) * BLOCK_SIZE
 //      C_col_start = get_group_id(1) * BLOCK_SIZE
Index: libgomp/testsuite/libgomp.oacc-c-c++-common/enter_exit-lib.c
===================================================================
--- libgomp/testsuite/libgomp.oacc-c-c++-common/enter_exit-lib.c	(revision 279217)
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/enter_exit-lib.c	(revision 279218)
@@ -1,4 +1,4 @@ 
-/* Verify enter/exit data interoperablilty between pragmas and
+/* Verify enter/exit data interoperability between pragmas and
    acc library calls.  */
 
 /* { dg-do run } */
Index: libgomp/oacc-host.c
===================================================================
--- libgomp/oacc-host.c	(revision 279217)
+++ libgomp/oacc-host.c	(revision 279218)
@@ -260,7 +260,7 @@ 
     .run_func = host_run,
 
     .mem_map = { NULL },
-    /* .lock initilized in goacc_host_init.  */
+    /* .lock initialized in goacc_host_init.  */
     .state = GOMP_DEVICE_UNINITIALIZED,
 
     .openacc = {
Index: libgomp/config/nvptx/task.c
===================================================================
--- libgomp/config/nvptx/task.c	(revision 279217)
+++ libgomp/config/nvptx/task.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles the maintainence of tasks in response to task
+/* This file handles the maintenance of tasks in response to task
    creation and termination.  */
 
 #ifdef __nvptx_softstack__
Index: libgomp/config/nvptx/team.c
===================================================================
--- libgomp/config/nvptx/team.c	(revision 279217)
+++ libgomp/config/nvptx/team.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles maintainance of threads on NVPTX.  */
+/* This file handles maintenance of threads on NVPTX.  */
 
 #if defined __nvptx_softstack__ && defined __nvptx_unisimt__
 
Index: libgomp/config/gcn/task.c
===================================================================
--- libgomp/config/gcn/task.c	(revision 279217)
+++ libgomp/config/gcn/task.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles the maintainence of tasks in response to task
+/* This file handles the maintenance of tasks in response to task
    creation and termination.  */
 
 #include "libgomp.h"
Index: libgomp/config/gcn/team.c
===================================================================
--- libgomp/config/gcn/team.c	(revision 279217)
+++ libgomp/config/gcn/team.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles maintainance of threads on AMD GCN.  */
+/* This file handles maintenance of threads on AMD GCN.  */
 
 #include "libgomp.h"
 #include <stdlib.h>
@@ -74,7 +74,7 @@ 
 						      * numthreads);
       set_gcn_thrs (thrs);
 
-      /* Allocate and initailize a pool of threads in the team.
+      /* Allocate and initialize a pool of threads in the team.
          The threads are already running, of course, we just need to manage
          the communication between them.  */
       struct gomp_thread_pool *pool = team_malloc (sizeof (*pool));
Index: libgomp/plugin/plugin-gcn.c
===================================================================
--- libgomp/plugin/plugin-gcn.c	(revision 279217)
+++ libgomp/plugin/plugin-gcn.c	(revision 279218)
@@ -107,7 +107,7 @@ 
 /* }}}  */
 /* {{{ Types  */
 
-/* GCN-specific implmentation of the GOMP_PLUGIN_acc_thread data.  */
+/* GCN-specific implementation of the GOMP_PLUGIN_acc_thread data.  */
 
 struct gcn_thread
 {
@@ -408,7 +408,7 @@ 
   /* Whether the agent has been initialized.  The fields below are usable only
      if it has been.  */
   bool initialized;
-  /* Precomuted check for problem architectures.  */
+  /* Precomputed check for problem architectures.  */
   bool gfx900_p;
 
   /* Command queues of the agent.  */
@@ -3858,7 +3858,7 @@ 
   return aq;
 }
 
-/* Destroy an exisiting asynchronous thread and queue.  Waits for any
+/* Destroy an existing asynchronous thread and queue.  Waits for any
    currently-running task to complete, but cancels any queued tasks.  */
 
 bool
Index: libgomp/env.c
===================================================================
--- libgomp/env.c	(revision 279217)
+++ libgomp/env.c	(revision 279218)
@@ -1337,7 +1337,7 @@ 
     ignore = true;
   /* Make sure OMP_PLACES and GOMP_CPU_AFFINITY env vars are always
      parsed if present in the environment.  If OMP_PROC_BIND was set
-     explictly to false, don't populate places list though.  If places
+     explicitly to false, don't populate places list though.  If places
      list was successfully set from OMP_PLACES, only parse but don't process
      GOMP_CPU_AFFINITY.  If OMP_PROC_BIND was not set in the environment,
      default to OMP_PROC_BIND=true if OMP_PLACES or GOMP_CPU_AFFINITY
Index: libgomp/task.c
===================================================================
--- libgomp/task.c	(revision 279217)
+++ libgomp/task.c	(revision 279218)
@@ -23,7 +23,7 @@ 
    see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
    <http://www.gnu.org/licenses/>.  */
 
-/* This file handles the maintainence of tasks in response to task
+/* This file handles the maintenance of tasks in response to task
    creation and termination.  */
 
 #include "libgomp.h"
@@ -1157,7 +1157,7 @@ 
 
       /* CHILD_TASK satisfies a dependency for TASK.  Keep track of
 	 TASK's remaining dependencies.  Once TASK has no other
-	 depenencies, put it into the various queues so it will get
+	 dependencies, put it into the various queues so it will get
 	 scheduled for execution.  */
       if (--task->num_dependees != 0)
 	continue;
@@ -1674,7 +1674,7 @@ 
 	      {
 		tsk->parent_depends_on = true;
 		++num_awaited;
-		/* If depenency TSK itself has no dependencies and is
+		/* If dependency TSK itself has no dependencies and is
 		   ready to run, move it up front so that we run it as
 		   soon as possible.  */
 		if (tsk->num_dependees == 0 && tsk->kind == GOMP_TASK_WAITING)
Index: libgomp/libgomp.texi
===================================================================
--- libgomp/libgomp.texi	(revision 279217)
+++ libgomp/libgomp.texi	(revision 279218)
@@ -1887,7 +1887,7 @@ 
                                 host address.
 * acc_hostptr::                 Get host pointer associated with specific
                                 device address.
-* acc_is_present::              Indiciate whether host variable / array is
+* acc_is_present::              Indicate whether host variable / array is
                                 present on device.
 * acc_memcpy_to_device::        Copy host memory to device memory.
 * acc_memcpy_from_device::      Copy device memory to host memory.
@@ -2042,10 +2042,10 @@ 
 @section @code{acc_async_test} -- Test for completion of a specific asynchronous operation.
 @table @asis
 @item @emph{Description}
-This function tests for completion of the asynchrounous operation specified
+This function tests for completion of the asynchronous operation specified
 in @var{arg}. In C/C++, a non-zero value will be returned to indicate
 the specified asynchronous operation has completed. While Fortran will return
-a @code{true}. If the asynchrounous operation has not completed, C/C++ returns
+a @code{true}. If the asynchronous operation has not completed, C/C++ returns
 a zero and Fortran returns a @code{false}.
 
 @item @emph{C/C++}:
@@ -2071,7 +2071,7 @@ 
 @section @code{acc_async_test_all} -- Tests for completion of all asynchronous operations.
 @table @asis
 @item @emph{Description}
-This function tests for completion of all asynchrounous operations.
+This function tests for completion of all asynchronous operations.
 In C/C++, a non-zero value will be returned to indicate all asynchronous
 operations have completed. While Fortran will return a @code{true}. If
 any asynchronous operation has not completed, C/C++ returns a zero and
@@ -2255,7 +2255,7 @@ 
 @item @emph{Description}:
 This function returns whether the program is executing on a particular
 device specified in @var{devicetype}. In C/C++ a non-zero value is
-returned to indicate the device is execiting on the specified device type.
+returned to indicate the device is executing on the specified device type.
 In Fortran, @code{true} will be returned. If the program is not executing
 on the specified device type C/C++ will return a zero, while Fortran will
 return @code{false}.
Index: libgomp/ordered.c
===================================================================
--- libgomp/ordered.c	(revision 279217)
+++ libgomp/ordered.c	(revision 279218)
@@ -214,7 +214,7 @@ 
      Either way we get correct results.
      However, there is an implicit flush on entry to an ordered region,
      so we do need to have a barrier here.  If we were taking a lock
-     this could be MEMMODEL_RELEASE since the acquire would be coverd
+     this could be MEMMODEL_RELEASE since the acquire would be covered
      by the lock.  */
 
   __atomic_thread_fence (MEMMODEL_ACQ_REL);
@@ -246,7 +246,7 @@ 
 
    However, the current implementation has a flaw in that it does not allow
    the next thread into the ORDERED section immediately after the current
-   thread exits the ORDERED section in its last iteration.  The existance
+   thread exits the ORDERED section in its last iteration.  The existence
    of this function allows the implementation to change.  */
 
 void
Index: libgomp/omp_lib.h.in
===================================================================
--- libgomp/omp_lib.h.in	(revision 279217)
+++ libgomp/omp_lib.h.in	(revision 279218)
@@ -102,8 +102,8 @@ 
       external omp_in_final
       logical(4) omp_in_final
 
-      external omp_get_cancelllation
-      logical(4) omp_get_cancelllation
+      external omp_get_cancellation
+      logical(4) omp_get_cancellation
 
       external omp_get_proc_bind
       integer(omp_proc_bind_kind) omp_get_proc_bind