Patchwork [PR50572] Tune loop alignment for Atom

login
register
mail settings
Submitter Sergey Ostanevich
Date Oct. 20, 2011, 8:05 a.m.
Message ID <CAGYS_T+K4f23ks0o5bk+gbDcR7uWfdU0pxs=zHaAEV7FCE9MWQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/120754/
State New
Headers show

Comments

Sergey Ostanevich - Oct. 20, 2011, 8:05 a.m.
> Please provide a patch which can be applied.  Cut/paste doesn't create
> a working patch.  Please attach it.
>
> --
> H.J.
>

Will that works?
Sergos.

 static const char *const cpu_names[TARGET_CPU_DEFAULT_max] =
H.J. Lu - Oct. 20, 2011, 7:34 p.m.
On Thu, Oct 20, 2011 at 1:05 AM, Sergey Ostanevich <sergos.gnu@gmail.com> wrote:
>> Please provide a patch which can be applied.  Cut/paste doesn't create
>> a working patch.  Please attach it.
>>
>> --
>> H.J.
>>
>
> Will that works?
> Sergos.
>
> diff --git a/gcc/ChangeLog b/gcc/ChangeLog
> index 6c73404..e21cf86 100644
> --- a/gcc/ChangeLog
> +++ b/gcc/ChangeLog
> @@ -1,3 +1,8 @@
> +2011-10-20  Sergey Ostanevich  <sergos.gnu@gmail.com>
> +
> +       * config/i386/i386.c (processor_target_table): Change Atom
> +       align_loops_max_skip to 15.
> +
>  2011-10-17  Michael Spertus  <mike_spertus@symantec.com>
>
>        * gcc/c-family/c-common.c (c_common_reswords): Add __bases,
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index 2c53423..8c60086 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -2596,7 +2596,7 @@ static const struct ptt
> processor_target_table[PROCESSOR_max] =
>   {&bdver1_cost, 32, 24, 32, 7, 32},
>   {&bdver2_cost, 32, 24, 32, 7, 32},
>   {&btver1_cost, 32, 24, 32, 7, 32},
> -  {&atom_cost, 16, 7, 16, 7, 16}
> +  {&atom_cost, 16, 15, 16, 7, 16}
>  };
>
>  static const char *const cpu_names[TARGET_CPU_DEFAULT_max] =
>

No, it doesn't work.  I had to apply it by hand for you.

1. You have to use attachment for patches to be applied by other
people when you are sending them in gmail.
2. Please don't use diff on ChangeLog unless you are the only person
who changes it.   Such patch  rarely applies.
3. You should add PR target/50572 in ChangeLog entry.

Patch

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 6c73404..e21cf86 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@ 
+2011-10-20  Sergey Ostanevich  <sergos.gnu@gmail.com>
+
+       * config/i386/i386.c (processor_target_table): Change Atom
+       align_loops_max_skip to 15.
+
 2011-10-17  Michael Spertus  <mike_spertus@symantec.com>

        * gcc/c-family/c-common.c (c_common_reswords): Add __bases,
diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index 2c53423..8c60086 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -2596,7 +2596,7 @@  static const struct ptt
processor_target_table[PROCESSOR_max] =
   {&bdver1_cost, 32, 24, 32, 7, 32},
   {&bdver2_cost, 32, 24, 32, 7, 32},
   {&btver1_cost, 32, 24, 32, 7, 32},
-  {&atom_cost, 16, 7, 16, 7, 16}
+  {&atom_cost, 16, 15, 16, 7, 16}
 };