| Message ID | 20191211010308.1525-2-dan@dlrobertson.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | iio: add driver for Bosch BMA400 accelerometer | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
Hi Dan, thanks for your patch! On Wed, Dec 11, 2019 at 2:20 AM Dan Robertson <dan@dlrobertson.com> wrote: > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power > accelerometer sensor. > > Signed-off-by: Dan Robertson <dan@dlrobertson.com> (...) > + Specifications about the sensor can be found at: > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf As can be seen in page 113 in the manual this component has VDD and VDDIO supplies and sooner or later someone is going to have to model that so I'd say add vdd-supply and vddio-supply regulator phandles as optional to the component already from start. Thanks! Linus Walleij
On Thu, Dec 12, 2019 at 11:16:47AM +0100, Linus Walleij wrote: > Hi Dan, > > thanks for your patch! > > On Wed, Dec 11, 2019 at 2:20 AM Dan Robertson <dan@dlrobertson.com> wrote: > > > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power > > accelerometer sensor. > > > > Signed-off-by: Dan Robertson <dan@dlrobertson.com> > (...) > > > + Specifications about the sensor can be found at: > > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf > > As can be seen in page 113 in the manual this component > has VDD and VDDIO supplies and sooner or later someone > is going to have to model that so I'd say add vdd-supply and > vddio-supply regulator phandles as optional to the component > already from start. And interrupts too. Doesn't matter what the driver currently uses. Rob
On Wed, Dec 11, 2019 at 01:03:07AM +0000, Dan Robertson wrote: > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power > accelerometer sensor. > > Signed-off-by: Dan Robertson <dan@dlrobertson.com> > --- > .../bindings/iio/accel/bosch,bma400.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml > new file mode 100644 > index 000000000000..03b7ad345523 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings please: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bosch BMA400 triaxial acceleration sensor > + > +maintainers: > + - Dan Robertson <dan@dlrobertson.com> > + > +description: | > + Acceleration and temerature iio sensors with an i2c interface > + > + Specifications about the sensor can be found at: > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf > + > +properties: > + compatible: > + enum: > + - bosch,bma400 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + accelerometer@14 { > + compatible = "bosch,bma400"; > + reg = <0x14>; > + }; > + }; > >
On Wed, Dec 18, 2019 at 11:05:15AM -0600, Rob Herring wrote: > On Thu, Dec 12, 2019 at 11:16:47AM +0100, Linus Walleij wrote: > > Hi Dan, > > > > thanks for your patch! > > > > On Wed, Dec 11, 2019 at 2:20 AM Dan Robertson <dan@dlrobertson.com> wrote: > > > > > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power > > > accelerometer sensor. > > > > > > Signed-off-by: Dan Robertson <dan@dlrobertson.com> > > (...) > > > > > + Specifications about the sensor can be found at: > > > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf > > > > As can be seen in page 113 in the manual this component > > has VDD and VDDIO supplies and sooner or later someone > > is going to have to model that so I'd say add vdd-supply and > > vddio-supply regulator phandles as optional to the component > > already from start. > > And interrupts too. Doesn't matter what the driver currently uses. Will do. I plan to work on adding support for interrupts in a follow-up patchset, but I'll add this to the devicetree documentation. Cheers, - Dan
diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml new file mode 100644 index 000000000000..03b7ad345523 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/accel/bosch,bma400.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bosch BMA400 triaxial acceleration sensor + +maintainers: + - Dan Robertson <dan@dlrobertson.com> + +description: | + Acceleration and temerature iio sensors with an i2c interface + + Specifications about the sensor can be found at: + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf + +properties: + compatible: + enum: + - bosch,bma400 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + accelerometer@14 { + compatible = "bosch,bma400"; + reg = <0x14>; + }; + };
Add devicetree binding for the Bosch BMA400 3-axes ultra-low power accelerometer sensor. Signed-off-by: Dan Robertson <dan@dlrobertson.com> --- .../bindings/iio/accel/bosch,bma400.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml