| Message ID | 20191210195903.24127-2-f.fainelli@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | reset: Add Broadcom STB RESCAL reset controller | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Dec 10, 2019 at 11:59:02AM -0800, Florian Fainelli wrote: > From: Jim Quinlan <jim2101024@gmail.com> > > BCM7216 has a special purpose RESCAL reset controller for its SATA and > PCIe0/1 instances. This is a simple reset controller with #reset-cells > set to 0. > > Signed-off-by: Jim Quinlan <jim2101024@gmail.com> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > .../reset/brcm,bcm7216-pcie-sata-rescal.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.txt Can you make this DT schema format.
On 12/19/19 12:40 PM, Rob Herring wrote: > On Tue, Dec 10, 2019 at 11:59:02AM -0800, Florian Fainelli wrote: >> From: Jim Quinlan <jim2101024@gmail.com> >> >> BCM7216 has a special purpose RESCAL reset controller for its SATA and >> PCIe0/1 instances. This is a simple reset controller with #reset-cells >> set to 0. >> >> Signed-off-by: Jim Quinlan <jim2101024@gmail.com> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> >> --- >> .../reset/brcm,bcm7216-pcie-sata-rescal.txt | 26 +++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.txt > > Can you make this DT schema format. Yes, most certainly, I need to re-spin the reset driver as well. Thanks!
diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.txt b/Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.txt new file mode 100644 index 000000000000..ceaf7ee58726 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/brcm,bcm7216-pcie-sata-rescal.txt @@ -0,0 +1,26 @@ +BCM7216 RESCAL reset controller +=============================== + +This document describes the BCM7216 RESCAL reset controller which is +responsible for controlling the reset of the SATA and PCIe0/1 instances on +BCM7216. + +Please also refer to reset.txt in this directory for common reset controller +binding usage. + +Required properties: +- compatible: should be brcm,bcm7216-pcie-sata-rescal +- reg: register base and length +- #reset-cells: must be set to 0 + +Example: + +rescal: reset { + compatible = "brcm,bcm7216-pcie-sata-rescal"; + reg = <0x8b2c800>; + #reset-cells = <0>; +}; + +&pcie0 { + resets = <&rescal>; +};