| Message ID | 20191210195648.811120-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | ptp: clockmatrix: add I2C dependency | expand |
On Tue, Dec 10, 2019 at 02:56:34PM EST, Arnd Bergmann wrote: >Without I2C, we get a link failure: > >drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3': >ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer' >drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init': >ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver' >drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit': >ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver' > >Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.") >Signed-off-by: Arnd Bergmann <arnd@arndb.de> >--- > drivers/ptp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig >index dc3d8ecb4231..e37797c0a85c 100644 >--- a/drivers/ptp/Kconfig >+++ b/drivers/ptp/Kconfig >@@ -107,7 +107,7 @@ config PTP_1588_CLOCK_KVM > > config PTP_1588_CLOCK_IDTCM > tristate "IDT CLOCKMATRIX as PTP clock" >- depends on PTP_1588_CLOCK >+ depends on PTP_1588_CLOCK && I2C > default n > help > This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP >-- Sorry, that was flagged by "kbuild test robot" Nov 25. I was in the process of creating a patch series with other updates, but you beat me to the punch. Thank-you. Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com> Regards, Vincent
On Tue, 10 Dec 2019 20:56:34 +0100, Arnd Bergmann wrote: > Without I2C, we get a link failure: > > drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3': > ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer' > drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init': > ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver' > drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit': > ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver' > > Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied to net, thank you!
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig index dc3d8ecb4231..e37797c0a85c 100644 --- a/drivers/ptp/Kconfig +++ b/drivers/ptp/Kconfig @@ -107,7 +107,7 @@ config PTP_1588_CLOCK_KVM config PTP_1588_CLOCK_IDTCM tristate "IDT CLOCKMATRIX as PTP clock" - depends on PTP_1588_CLOCK + depends on PTP_1588_CLOCK && I2C default n help This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
Without I2C, we get a link failure: drivers/ptp/ptp_clockmatrix.o: In function `idtcm_xfer.isra.3': ptp_clockmatrix.c:(.text+0xcc): undefined reference to `i2c_transfer' drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_init': ptp_clockmatrix.c:(.init.text+0x14): undefined reference to `i2c_register_driver' drivers/ptp/ptp_clockmatrix.o: In function `idtcm_driver_exit': ptp_clockmatrix.c:(.exit.text+0x10): undefined reference to `i2c_del_driver' Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/ptp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)