Patchwork Avoid -mno-accumulate-outgoing-args in tests on Windows target

login
register
mail settings
Submitter Joseph S. Myers
Date Oct. 20, 2011, 12:03 a.m.
Message ID <Pine.LNX.4.64.1110200002130.9439@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/120710/
State New
Headers show

Comments

Joseph S. Myers - Oct. 20, 2011, 12:03 a.m.
The -mno-accumulate-outgoing-args option does not work with the stack
probing used on Windows targets, giving a warning and so causing tests
using that option to fail.  This patch makes three tests not use that
option on affected targets, like sse-10.c (see
<http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00180.html> for the
introduction of the warning and the sse-10.c change).

Tested with cross to i686-mingw32.  OK to commit?

2011-10-19  Joseph Myers  <joseph@codesourcery.com>

	* gcc.target/i386/pr40906-1.c, gcc.target/i386/pr40906-2.c,
	gcc.target/i386/pr46226.c: Do not use
	-mno-accumulate-outgoing-args.
Richard Guenther - Oct. 20, 2011, 8:35 a.m.
On Thu, Oct 20, 2011 at 2:03 AM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> The -mno-accumulate-outgoing-args option does not work with the stack
> probing used on Windows targets, giving a warning and so causing tests
> using that option to fail.  This patch makes three tests not use that
> option on affected targets, like sse-10.c (see
> <http://gcc.gnu.org/ml/gcc-patches/2008-03/msg00180.html> for the
> introduction of the warning and the sse-10.c change).
>
> Tested with cross to i686-mingw32.  OK to commit?

Ok.

Thanks,
Richard.

> 2011-10-19  Joseph Myers  <joseph@codesourcery.com>
>
>        * gcc.target/i386/pr40906-1.c, gcc.target/i386/pr40906-2.c,
>        gcc.target/i386/pr46226.c: Do not use
>        -mno-accumulate-outgoing-args.
>
> Index: gcc/testsuite/gcc.target/i386/pr40906-2.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/pr40906-2.c   (revision 180200)
> +++ gcc/testsuite/gcc.target/i386/pr40906-2.c   (working copy)
> @@ -1,6 +1,7 @@
>  /* { dg-do run } */
>  /* { dg-require-effective-target ia32 } */
>  /* { dg-options "-O2 -Wno-psabi -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -mno-accumulate-outgoing-args -m128bit-long-double" } */
> +/* { dg-options "-O2 -Wno-psabi -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -m128bit-long-double" { target *-*-mingw* *-*-cygwin* } } */
>
>  void abort (void);
>
> Index: gcc/testsuite/gcc.target/i386/pr46226.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/pr46226.c     (revision 180200)
> +++ gcc/testsuite/gcc.target/i386/pr46226.c     (working copy)
> @@ -1,5 +1,6 @@
>  /* { dg-do run } */
>  /* { dg-options "-Os -fomit-frame-pointer -mno-accumulate-outgoing-args -fno-asynchronous-unwind-tables" } */
> +/* { dg-options "-Os -fomit-frame-pointer -fno-asynchronous-unwind-tables" { target *-*-mingw* *-*-cygwin* } } */
>
>  extern void abort(void);
>
> Index: gcc/testsuite/gcc.target/i386/pr40906-1.c
> ===================================================================
> --- gcc/testsuite/gcc.target/i386/pr40906-1.c   (revision 180200)
> +++ gcc/testsuite/gcc.target/i386/pr40906-1.c   (working copy)
> @@ -1,6 +1,7 @@
>  /* { dg-do run } */
>  /* { dg-require-effective-target ia32 } */
>  /* { dg-options "-O2 -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -mno-accumulate-outgoing-args" } */
> +/* { dg-options "-O2 -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args" { target *-*-mingw* *-*-cygwin* } } */
>
>  void abort (void);
>
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
>

Patch

Index: gcc/testsuite/gcc.target/i386/pr40906-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/pr40906-2.c	(revision 180200)
+++ gcc/testsuite/gcc.target/i386/pr40906-2.c	(working copy)
@@ -1,6 +1,7 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target ia32 } */
 /* { dg-options "-O2 -Wno-psabi -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -mno-accumulate-outgoing-args -m128bit-long-double" } */
+/* { dg-options "-O2 -Wno-psabi -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -m128bit-long-double" { target *-*-mingw* *-*-cygwin* } } */
 
 void abort (void);
 
Index: gcc/testsuite/gcc.target/i386/pr46226.c
===================================================================
--- gcc/testsuite/gcc.target/i386/pr46226.c	(revision 180200)
+++ gcc/testsuite/gcc.target/i386/pr46226.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do run } */
 /* { dg-options "-Os -fomit-frame-pointer -mno-accumulate-outgoing-args -fno-asynchronous-unwind-tables" } */
+/* { dg-options "-Os -fomit-frame-pointer -fno-asynchronous-unwind-tables" { target *-*-mingw* *-*-cygwin* } } */
 
 extern void abort(void);
 
Index: gcc/testsuite/gcc.target/i386/pr40906-1.c
===================================================================
--- gcc/testsuite/gcc.target/i386/pr40906-1.c	(revision 180200)
+++ gcc/testsuite/gcc.target/i386/pr40906-1.c	(working copy)
@@ -1,6 +1,7 @@ 
 /* { dg-do run } */
 /* { dg-require-effective-target ia32 } */
 /* { dg-options "-O2 -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args -mno-accumulate-outgoing-args" } */
+/* { dg-options "-O2 -fomit-frame-pointer -fno-asynchronous-unwind-tables -mpush-args" { target *-*-mingw* *-*-cygwin* } } */
 
 void abort (void);