Patchwork [testsuite] : Require non_strict_align effective target for gcc.dg/ipa/ipa-sra-[26].c

login
register
mail settings
Submitter Uros Bizjak
Date Oct. 19, 2011, 7:50 p.m.
Message ID <CAFULd4aia8Jme4vbrR=ad1BAnuLZpsnZ_Wru2C_izj1A=wX-eA@mail.gmail.com>
Download mbox | patch
Permalink /patch/120689/
State New
Headers show

Comments

Uros Bizjak - Oct. 19, 2011, 7:50 p.m.
Hello!

These two tests require non_strict_aligned effective target, since IPA
fails in tree_non_mode_aligned_mem_p () for "cow" and "calf"
candidates for STRICT_ALIGNMENT targets. Mode alignment requires 32
bytes, while data is aligned to 8 bytes.

2011-10-19  Uros Bizjak  <ubizjak@gmail.com>

	* gcc.dg/ipa/ipa-sra-2.c: Add dg-require-effective-target
	non_strict_align.
	* gcc.dg/ipa/ipa-sra-6.c: Ditto.

Tested on x86_64-pc-linux-gnu and alphaev68-pc-linux-gnu, where the
patch "fixes":

FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
expr cow_.*D.->red with \\*ISRA"
FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
expr cow_.*D.->green with ISRA"
FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
expr calf_.*D.->red with \\*ISRA"
FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
expr calf_.*D.->green with ISRA"
FAIL: gcc.dg/ipa/ipa-sra-6.c scan-tree-dump-times eipa_sra "foo " 1

OK for mainline and 4.6 branch?

Uros.
David Miller - Oct. 19, 2011, 7:54 p.m.
From: Uros Bizjak <ubizjak@gmail.com>
Date: Wed, 19 Oct 2011 21:50:14 +0200

> Hello!
> 
> These two tests require non_strict_aligned effective target, since IPA
> fails in tree_non_mode_aligned_mem_p () for "cow" and "calf"
> candidates for STRICT_ALIGNMENT targets. Mode alignment requires 32
> bytes, while data is aligned to 8 bytes.
> 
> 2011-10-19  Uros Bizjak  <ubizjak@gmail.com>
> 
> 	* gcc.dg/ipa/ipa-sra-2.c: Add dg-require-effective-target
> 	non_strict_align.
> 	* gcc.dg/ipa/ipa-sra-6.c: Ditto.
> 
> Tested on x86_64-pc-linux-gnu and alphaev68-pc-linux-gnu, where the
> patch "fixes":

Thanks for taking care of this, I've been seeing these on sparc as well.
Uros Bizjak - Oct. 20, 2011, 3:24 p.m.
On Wed, Oct 19, 2011 at 9:50 PM, Uros Bizjak <ubizjak@gmail.com> wrote:

> These two tests require non_strict_aligned effective target, since IPA
> fails in tree_non_mode_aligned_mem_p () for "cow" and "calf"
> candidates for STRICT_ALIGNMENT targets. Mode alignment requires 32
> bytes, while data is aligned to 8 bytes.
>
> 2011-10-19  Uros Bizjak  <ubizjak@gmail.com>
>
>        * gcc.dg/ipa/ipa-sra-2.c: Add dg-require-effective-target
>        non_strict_align.
>        * gcc.dg/ipa/ipa-sra-6.c: Ditto.
>
> Tested on x86_64-pc-linux-gnu and alphaev68-pc-linux-gnu, where the
> patch "fixes":
>
> FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
> expr cow_.*D.->red with \\*ISRA"
> FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
> expr cow_.*D.->green with ISRA"
> FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
> expr calf_.*D.->red with \\*ISRA"
> FAIL: gcc.dg/ipa/ipa-sra-2.c scan-tree-dump eipa_sra "About to replace
> expr calf_.*D.->green with ISRA"
> FAIL: gcc.dg/ipa/ipa-sra-6.c scan-tree-dump-times eipa_sra "foo " 1

So, comitted to SVN mainline and 4.6 branch under obvious rule.

Uros.

Patch

Index: gcc.dg/ipa/ipa-sra-2.c
===================================================================
--- gcc.dg/ipa/ipa-sra-2.c	(revision 180193)
+++ gcc.dg/ipa/ipa-sra-2.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
 /* { dg-options "-O2 -fipa-sra -fdump-tree-eipa_sra-details"  } */
+/* { dg-require-effective-target non_strict_align } */
 
 struct bovid
 {
Index: gcc.dg/ipa/ipa-sra-6.c
===================================================================
--- gcc.dg/ipa/ipa-sra-6.c	(revision 180193)
+++ gcc.dg/ipa/ipa-sra-6.c	(working copy)
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
 /* { dg-options "-O2 -fipa-sra -fdump-tree-eipa_sra-slim"  } */
+/* { dg-require-effective-target non_strict_align } */
 
 struct bovid
 {