From patchwork Wed Oct 19 13:56:46 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 120636 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E3A39B71D4 for ; Thu, 20 Oct 2011 01:03:54 +1100 (EST) Received: from localhost ([::1]:59675 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGWf6-0003Ns-PA for incoming@patchwork.ozlabs.org; Wed, 19 Oct 2011 09:58:28 -0400 Received: from eggs.gnu.org ([140.186.70.92]:37672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGWeg-0003Au-KS for qemu-devel@nongnu.org; Wed, 19 Oct 2011 09:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGWec-0007UQ-3R for qemu-devel@nongnu.org; Wed, 19 Oct 2011 09:58:02 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:9610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGWeb-0007Tx-OZ for qemu-devel@nongnu.org; Wed, 19 Oct 2011 09:57:57 -0400 X-IronPort-AV: E=Sophos;i="4.69,372,1315195200"; d="scan'208";a="167426157" Received: from ftlpmailmx02.citrite.net ([10.13.107.66]) by FTLPIPO02.CITRIX.COM with ESMTP/TLS/RC4-MD5; 19 Oct 2011 09:57:56 -0400 Received: from smtp01.ad.xensource.com (10.219.128.104) by smtprelay.citrix.com (10.13.107.66) with Microsoft SMTP Server id 8.3.137.0; Wed, 19 Oct 2011 09:57:56 -0400 Received: from perard.uk.xensource.com (dhcp-3-28.uk.xensource.com [10.80.3.28] (may be forged)) by smtp01.ad.xensource.com (8.13.1/8.13.1) with ESMTP id p9JDvj1i019274; Wed, 19 Oct 2011 06:57:53 -0700 From: Anthony PERARD To: QEMU-devel Date: Wed, 19 Oct 2011 14:56:46 +0100 Message-ID: <1319032613-10560-4-git-send-email-anthony.perard@citrix.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1319032613-10560-1-git-send-email-anthony.perard@citrix.com> References: <1319032613-10560-1-git-send-email-anthony.perard@citrix.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.63 Cc: Anthony PERARD , Yuji Shimada , Alex Williamson , Xen Devel , Stefano Stabellini Subject: [Qemu-devel] [PATCH V2 03/10] pci.c: Add pci_check_bar_overlap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Yuji Shimada This function help Xen PCI Passthrough device to check for overlap. Signed-off-by: Yuji Shimada Signed-off-by: Anthony PERARD --- hw/pci.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ hw/pci.h | 3 +++ 2 files changed, 50 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 749e8d8..d85ceca 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -2129,3 +2129,50 @@ MemoryRegion *pci_address_space_io(PCIDevice *dev) { return dev->bus->address_space_io; } + +int pci_check_bar_overlap(PCIDevice *dev, + pcibus_t addr, pcibus_t size, uint8_t type) +{ + PCIBus *bus = dev->bus; + PCIDevice *devices = NULL; + PCIIORegion *r; + int i, j; + int rc = 0; + + /* check Overlapped to Base Address */ + for (i = 0; i < ARRAY_SIZE(bus->devices); i++) { + devices = bus->devices[i]; + if (!devices) { + continue; + } + + /* skip itself */ + if (devices->devfn == dev->devfn) { + continue; + } + + for (j = 0; j < PCI_NUM_REGIONS; j++) { + r = &devices->io_regions[j]; + + /* skip different resource type, but don't skip when + * prefetch and non-prefetch memory are compared. + */ + if (type != r->type) { + if (type == PCI_BASE_ADDRESS_SPACE_IO || + r->type == PCI_BASE_ADDRESS_SPACE_IO) { + continue; + } + } + + if ((addr < (r->addr + r->size)) && ((addr + size) > r->addr)) { + printf("Overlapped to device[%02x:%02x.%x][Region:%d]" + "[Address:%"PRIx64"h][Size:%"PRIx64"h]\n", + pci_bus_num(bus), PCI_SLOT(devices->devfn), + PCI_FUNC(devices->devfn), j, r->addr, r->size); + rc = 1; + } + } + } + + return rc; +} diff --git a/hw/pci.h b/hw/pci.h index 86a81c8..0e1a07d 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -487,4 +487,7 @@ static inline uint32_t pci_config_size(const PCIDevice *d) return pci_is_express(d) ? PCIE_CONFIG_SPACE_SIZE : PCI_CONFIG_SPACE_SIZE; } +int pci_check_bar_overlap(PCIDevice *dev, + pcibus_t addr, pcibus_t size, uint8_t type); + #endif