| Message ID | 20191209145016.227784-2-hsinyi@chromium.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | drm: bridge: anx7688 and an optional feature | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Hsin-Yi, Thank you for the patch. On Mon, Dec 09, 2019 at 10:50:13PM +0800, Hsin-Yi Wang wrote: > From: Nicolas Boichat <drinkcat@chromium.org> > > Add support for analogix,anx7688 > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > .../bindings/display/bridge/anx7688.txt | 32 +++++++++++++++++++ How about converting this to yaml bindings already ? It's fairly simple and gives you DT validation. > 1 file changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.txt b/Documentation/devicetree/bindings/display/bridge/anx7688.txt > new file mode 100644 > index 000000000000..78b55bdb18f7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.txt > @@ -0,0 +1,32 @@ > +Analogix ANX7688 SlimPort (Single-Chip Transmitter for DP over USB-C) > +--------------------------------------------------------------------- > + > +The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per > +second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video > +resolution from a smartphone or tablet with full function USB-C. > + > +This binding only describes the HDMI to DP display bridge. > + > +Required properties: > + > + - compatible : "analogix,anx7688" > + - reg : I2C address of the device (fixed at 0x2c) > + > +Optional properties: > + > + - Video port for HDMI input, using the DT bindings defined in [1]. > + > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + > + anx7688: anx7688@2c { > + compatible = "analogix,anx7688"; > + reg = <0x2c>; > + > + port { > + anx7688_in: endpoint { > + remote-endpoint = <&hdmi0_out>; > + }; > + }; > + }; > -- > 2.24.0.393.g34dc348eaf-goog >
On Mon, Dec 9, 2019 at 10:53 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: Hi Laurent, > How about converting this to yaml bindings already ? It's fairly simple > and gives you DT validation. > Added in https://lore.kernel.org/lkml/20191211061911.238393-1-hsinyi@chromium.org/T/#m183b3822bf60101666436b0244b27275c6765d20 Thanks
diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.txt b/Documentation/devicetree/bindings/display/bridge/anx7688.txt new file mode 100644 index 000000000000..78b55bdb18f7 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.txt @@ -0,0 +1,32 @@ +Analogix ANX7688 SlimPort (Single-Chip Transmitter for DP over USB-C) +--------------------------------------------------------------------- + +The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per +second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video +resolution from a smartphone or tablet with full function USB-C. + +This binding only describes the HDMI to DP display bridge. + +Required properties: + + - compatible : "analogix,anx7688" + - reg : I2C address of the device (fixed at 0x2c) + +Optional properties: + + - Video port for HDMI input, using the DT bindings defined in [1]. + +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + + anx7688: anx7688@2c { + compatible = "analogix,anx7688"; + reg = <0x2c>; + + port { + anx7688_in: endpoint { + remote-endpoint = <&hdmi0_out>; + }; + }; + };