[v2] gpio: pca953x: Don't hardcode irq trigger type
diff mbox series

Message ID 20191209062749.26429-1-vigneshr@ti.com
State New
Headers show
Series
  • [v2] gpio: pca953x: Don't hardcode irq trigger type
Related show

Commit Message

Vignesh Raghavendra Dec. 9, 2019, 6:27 a.m. UTC
Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
handler. IRQ/platform core will take care of setting appropriate trigger
type.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
v2:
Drop explicit call to irq_get_trigger_type() as this is take care of in core
code.

 drivers/gpio/gpio-pca953x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bartosz Golaszewski Dec. 11, 2019, 9:47 a.m. UTC | #1
pon., 9 gru 2019 o 07:27 Vignesh Raghavendra <vigneshr@ti.com> napisaƂ(a):
>
> Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
> handler. IRQ/platform core will take care of setting appropriate trigger
> type.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> v2:
> Drop explicit call to irq_get_trigger_type() as this is take care of in core
> code.
>
>  drivers/gpio/gpio-pca953x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..40e48f7d83bb 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
>
>         ret = devm_request_threaded_irq(&client->dev, client->irq,
>                                         NULL, pca953x_irq_handler,
> -                                       IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> -                                       IRQF_SHARED,
> +                                       IRQF_ONESHOT | IRQF_SHARED,
>                                         dev_name(&client->dev), chip);
>         if (ret) {
>                 dev_err(&client->dev, "failed to request irq %d\n",
> --
> 2.24.0
>

Patch applied, thanks!

Bartosz

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 6652bee01966..40e48f7d83bb 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -770,8 +770,7 @@  static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
 
 	ret = devm_request_threaded_irq(&client->dev, client->irq,
 					NULL, pca953x_irq_handler,
-					IRQF_TRIGGER_LOW | IRQF_ONESHOT |
-					IRQF_SHARED,
+					IRQF_ONESHOT | IRQF_SHARED,
 					dev_name(&client->dev), chip);
 	if (ret) {
 		dev_err(&client->dev, "failed to request irq %d\n",