diff mbox series

[v38,18/22] target/avr: Add machine none test

Message ID 20191208183922.13757-19-mrolnik@gmail.com
State New
Headers show
Series QEMU AVR 8 bit cores | expand

Commit Message

Michael Rolnik Dec. 8, 2019, 6:39 p.m. UTC 
Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
 tests/machine-none-test.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Aleksandar Markovic Dec. 9, 2019, 6:13 p.m. UTC | #1 
On Sunday, December 8, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:

> Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
>  tests/machine-none-test.c | 1 +
>  1 file changed, 1 insertion(+)
>
>
You need to add a commit message explaining how adding a test is achieved
with this single line.



> diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
> index 5953d31755..3e5c74e73e 100644
> --- a/tests/machine-none-test.c
> +++ b/tests/machine-none-test.c
> @@ -27,6 +27,7 @@ static struct arch2cpu cpus_map[] = {
>      /* tested targets list */
>      { "arm", "cortex-a15" },
>      { "aarch64", "cortex-a57" },
> +    { "avr", "avr6-avr-cpu" },
>      { "x86_64", "qemu64,apic-id=0" },
>      { "i386", "qemu32,apic-id=0" },
>      { "alpha", "ev67" },
> --
> 2.17.2 (Apple Git-113)
>
>
Michael Rolnik Dec. 9, 2019, 6:28 p.m. UTC | #2 
:)

no idea. all other machines / CPUs have it, so I added as well

On Mon, Dec 9, 2019 at 8:13 PM Aleksandar Markovic <
aleksandar.m.mail@gmail.com> wrote:

>
>
> On Sunday, December 8, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:
>
>> Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
>> ---
>>  tests/machine-none-test.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>>
> You need to add a commit message explaining how adding a test is achieved
> with this single line.
>
>
>
>> diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
>> index 5953d31755..3e5c74e73e 100644
>> --- a/tests/machine-none-test.c
>> +++ b/tests/machine-none-test.c
>> @@ -27,6 +27,7 @@ static struct arch2cpu cpus_map[] = {
>>      /* tested targets list */
>>      { "arm", "cortex-a15" },
>>      { "aarch64", "cortex-a57" },
>> +    { "avr", "avr6-avr-cpu" },
>>      { "x86_64", "qemu64,apic-id=0" },
>>      { "i386", "qemu32,apic-id=0" },
>>      { "alpha", "ev67" },
>> --
>> 2.17.2 (Apple Git-113)
>>
>>
Aleksandar Markovic Dec. 9, 2019, 6:46 p.m. UTC | #3 
On Monday, December 9, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:

> :)
>
> no idea. all other machines / CPUs have it, so I added as well
>
>>
>>
lol


> On Mon, Dec 9, 2019 at 8:13 PM Aleksandar Markovic <
> aleksandar.m.mail@gmail.com> wrote:
>
>>
>>
>> On Sunday, December 8, 2019, Michael Rolnik <mrolnik@gmail.com> wrote:
>>
>>> Signed-off-by: Michael Rolnik <mrolnik@gmail.com>
>>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
>>> ---
>>>  tests/machine-none-test.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>>
>> You need to add a commit message explaining how adding a test is achieved
>> with this single line.
>>
>>
>>
>>> diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
>>> index 5953d31755..3e5c74e73e 100644
>>> --- a/tests/machine-none-test.c
>>> +++ b/tests/machine-none-test.c
>>> @@ -27,6 +27,7 @@ static struct arch2cpu cpus_map[] = {
>>>      /* tested targets list */
>>>      { "arm", "cortex-a15" },
>>>      { "aarch64", "cortex-a57" },
>>> +    { "avr", "avr6-avr-cpu" },
>>>      { "x86_64", "qemu64,apic-id=0" },
>>>      { "i386", "qemu32,apic-id=0" },
>>>      { "alpha", "ev67" },
>>> --
>>> 2.17.2 (Apple Git-113)
>>>
>>>
>
> --
> Best Regards,
> Michael Rolnik
>
diff mbox series

Patch

diff --git a/tests/machine-none-test.c b/tests/machine-none-test.c
index 5953d31755..3e5c74e73e 100644
--- a/tests/machine-none-test.c
+++ b/tests/machine-none-test.c
@@ -27,6 +27,7 @@  static struct arch2cpu cpus_map[] = {
     /* tested targets list */
     { "arm", "cortex-a15" },
     { "aarch64", "cortex-a57" },
+    { "avr", "avr6-avr-cpu" },
     { "x86_64", "qemu64,apic-id=0" },
     { "i386", "qemu32,apic-id=0" },
     { "alpha", "ev67" },