| Message ID | 20191208132304.15521-5-elibr@mellanox.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | netdev datapath actions offload | expand |
On 08.12.2019 14:22, Eli Britstein wrote: > Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") > Signed-off-by: Eli Britstein <elibr@mellanox.com> > Reviewed-by: Oz Shlomo <ozsh@mellanox.com> > --- > lib/netdev-offload-dpdk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c > index e48ac3b63..041b72d53 100644 > --- a/lib/netdev-offload-dpdk.c > +++ b/lib/netdev-offload-dpdk.c > @@ -656,7 +656,7 @@ netdev_offload_dpdk_add_flow(struct netdev *netdev, > actions.actions, &error); > > if (!flow) { > - VLOG_ERR("%s: rte flow creat error: %u : message : %s\n", > + VLOG_ERR("%s: rte flow create error: %u : message : %s\n", I don't think that we need to backport this and you're changing/touching this line several (three?) times over the series. So, I think, it's better to drop this patch and update along with later changes. Or keep it and drop later changes (reviews for next patches are coming). > netdev_get_name(netdev), error.type, error.message); > ret = -1; > goto out; >
On 12/10/2019 4:22 PM, Ilya Maximets wrote: > On 08.12.2019 14:22, Eli Britstein wrote: >> Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") >> Signed-off-by: Eli Britstein <elibr@mellanox.com> >> Reviewed-by: Oz Shlomo <ozsh@mellanox.com> >> --- >> lib/netdev-offload-dpdk.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c >> index e48ac3b63..041b72d53 100644 >> --- a/lib/netdev-offload-dpdk.c >> +++ b/lib/netdev-offload-dpdk.c >> @@ -656,7 +656,7 @@ netdev_offload_dpdk_add_flow(struct netdev *netdev, >> actions.actions, &error); >> >> if (!flow) { >> - VLOG_ERR("%s: rte flow creat error: %u : message : %s\n", >> + VLOG_ERR("%s: rte flow create error: %u : message : %s\n", > I don't think that we need to backport this and you're changing/touching > this line several (three?) times over the series. So, I think, it's better > to drop this patch and update along with later changes. Or keep it and > drop later changes (reviews for next patches are coming). OK. will drop it. > >> netdev_get_name(netdev), error.type, error.message); >> ret = -1; >> goto out; >>
diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index e48ac3b63..041b72d53 100644 --- a/lib/netdev-offload-dpdk.c +++ b/lib/netdev-offload-dpdk.c @@ -656,7 +656,7 @@ netdev_offload_dpdk_add_flow(struct netdev *netdev, actions.actions, &error); if (!flow) { - VLOG_ERR("%s: rte flow creat error: %u : message : %s\n", + VLOG_ERR("%s: rte flow create error: %u : message : %s\n", netdev_get_name(netdev), error.type, error.message); ret = -1; goto out;
Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Eli Britstein <elibr@mellanox.com> Reviewed-by: Oz Shlomo <ozsh@mellanox.com> --- lib/netdev-offload-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)