fwts_wakealarm: remove unused function fwts_wakealarm_exits
diff mbox series

Message ID 20191207155448.130547-1-colin.king@canonical.com
State Accepted
Headers show
Series
  • fwts_wakealarm: remove unused function fwts_wakealarm_exits
Related show

Commit Message

Colin King Dec. 7, 2019, 3:54 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Function fwts_wakealarm_exits is not used, remove it. Minor
code cleanup.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/include/fwts_wakealarm.h |  1 -
 src/lib/src/fwts_wakealarm.c     | 11 -----------
 2 files changed, 12 deletions(-)

Comments

Alex Hung Dec. 7, 2019, 4:17 p.m. UTC | #1
On 2019-12-07 8:54 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Function fwts_wakealarm_exits is not used, remove it. Minor
> code cleanup.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/include/fwts_wakealarm.h |  1 -
>  src/lib/src/fwts_wakealarm.c     | 11 -----------
>  2 files changed, 12 deletions(-)
> 
> diff --git a/src/lib/include/fwts_wakealarm.h b/src/lib/include/fwts_wakealarm.h
> index 84bc9247..c3db5767 100644
> --- a/src/lib/include/fwts_wakealarm.h
> +++ b/src/lib/include/fwts_wakealarm.h
> @@ -24,7 +24,6 @@
>  
>  #include "fwts_framework.h"
>  
> -int fwts_wakealarm_exits(fwts_framework *fw);
>  int fwts_wakealarm_test_firing(fwts_framework *fw, const uint32_t sleep);
>  int fwts_wakealarm_trigger(fwts_framework *fw, const uint32_t seconds);
>  int fwts_wakealarm_cancel(fwts_framework *fw);
> diff --git a/src/lib/src/fwts_wakealarm.c b/src/lib/src/fwts_wakealarm.c
> index ed43ceda..273e4020 100644
> --- a/src/lib/src/fwts_wakealarm.c
> +++ b/src/lib/src/fwts_wakealarm.c
> @@ -78,17 +78,6 @@ int fwts_wakealarm_set(fwts_framework *fw, struct rtc_time *rtc_tm)
>  	return ret;
>  }
>  
> -/*
> - *  fwts_wakealarm_exits()
> - *	check that a RTC exists that supports minimal RTC alarm ioctl
> - */
> -int fwts_wakealarm_exits(fwts_framework *fw)
> -{
> -	struct rtc_time rtc_tm;
> -
> -	return fwts_wakealarm_get(fw, &rtc_tm);
> -}
> -
>  /*
>   *  fwts_wakealarm_trigger()
>   *	trigger the RTC wakealarm to fire in 'seconds' seconds from now.
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
ivanhu Dec. 9, 2019, 3:32 a.m. UTC | #2
在 2019年12月7日 下午11:54 於 下午11:54,Colin King <colin.king@canonical.com>曾寫:
>From: Colin Ian King <colin.king@canonical.com>
>
>Function fwts_wakealarm_exits is not used, remove it. Minor
>code cleanup.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> src/lib/include/fwts_wakealarm.h |  1 -
> src/lib/src/fwts_wakealarm.c     | 11 -----------
> 2 files changed, 12 deletions(-)
>
>diff --git a/src/lib/include/fwts_wakealarm.h
>b/src/lib/include/fwts_wakealarm.h
>index 84bc9247..c3db5767 100644
>--- a/src/lib/include/fwts_wakealarm.h
>+++ b/src/lib/include/fwts_wakealarm.h
>@@ -24,7 +24,6 @@
> 
> #include "fwts_framework.h"
> 
>-int fwts_wakealarm_exits(fwts_framework *fw);
>int fwts_wakealarm_test_firing(fwts_framework *fw, const uint32_t
>sleep);
>int fwts_wakealarm_trigger(fwts_framework *fw, const uint32_t seconds);
> int fwts_wakealarm_cancel(fwts_framework *fw);
>diff --git a/src/lib/src/fwts_wakealarm.c
>b/src/lib/src/fwts_wakealarm.c
>index ed43ceda..273e4020 100644
>--- a/src/lib/src/fwts_wakealarm.c
>+++ b/src/lib/src/fwts_wakealarm.c
>@@ -78,17 +78,6 @@ int fwts_wakealarm_set(fwts_framework *fw, struct
>rtc_time *rtc_tm)
> 	return ret;
> }
> 
>-/*
>- *  fwts_wakealarm_exits()
>- *	check that a RTC exists that supports minimal RTC alarm ioctl
>- */
>-int fwts_wakealarm_exits(fwts_framework *fw)
>-{
>-	struct rtc_time rtc_tm;
>-
>-	return fwts_wakealarm_get(fw, &rtc_tm);
>-}
>-
> /*
>  *  fwts_wakealarm_trigger()
>  *	trigger the RTC wakealarm to fire in 'seconds' seconds from now.
>-- 
>2.24.0
>
>
>-- 
>fwts-devel mailing list
>fwts-devel@lists.ubuntu.com
>Modify settings or unsubscribe at:
>https://lists.ubuntu.com/mailman/listinfo/fwts-devel

Patch
diff mbox series

diff --git a/src/lib/include/fwts_wakealarm.h b/src/lib/include/fwts_wakealarm.h
index 84bc9247..c3db5767 100644
--- a/src/lib/include/fwts_wakealarm.h
+++ b/src/lib/include/fwts_wakealarm.h
@@ -24,7 +24,6 @@ 
 
 #include "fwts_framework.h"
 
-int fwts_wakealarm_exits(fwts_framework *fw);
 int fwts_wakealarm_test_firing(fwts_framework *fw, const uint32_t sleep);
 int fwts_wakealarm_trigger(fwts_framework *fw, const uint32_t seconds);
 int fwts_wakealarm_cancel(fwts_framework *fw);
diff --git a/src/lib/src/fwts_wakealarm.c b/src/lib/src/fwts_wakealarm.c
index ed43ceda..273e4020 100644
--- a/src/lib/src/fwts_wakealarm.c
+++ b/src/lib/src/fwts_wakealarm.c
@@ -78,17 +78,6 @@  int fwts_wakealarm_set(fwts_framework *fw, struct rtc_time *rtc_tm)
 	return ret;
 }
 
-/*
- *  fwts_wakealarm_exits()
- *	check that a RTC exists that supports minimal RTC alarm ioctl
- */
-int fwts_wakealarm_exits(fwts_framework *fw)
-{
-	struct rtc_time rtc_tm;
-
-	return fwts_wakealarm_get(fw, &rtc_tm);
-}
-
 /*
  *  fwts_wakealarm_trigger()
  *	trigger the RTC wakealarm to fire in 'seconds' seconds from now.