[1/1] arm: -march=armv5t for ARM11
diff mbox series

Message ID 20191207081450.3888-1-xypron.glpk@gmx.de
State Accepted
Commit 0c5c3f293554614416a188d16a8c05e0a6c5bfbb
Delegated to: Tom Rini
Headers show
Series
  • [1/1] arm: -march=armv5t for ARM11
Related show

Commit Message

Heinrich Schuchardt Dec. 7, 2019, 8:14 a.m. UTC
In GCC 9 support for the Armv5 and Armv5E architectures (which have no
known implementations) has been removed, cf.
https://gcc.gnu.org/gcc-9/changes.html

Commit 16540d07fd62 ("arm: fix -march for ARM11") changed the value of the
compiler flag from -march=armv5 and -march=armv5t into -march=armv6 for
ARM11.

The values prior to this patch were:

    arch-$(CONFIG_CPU_ARM1136)     =-march=armv5
    arch-$(CONFIG_CPU_ARM1176)     =-march=armv5t

The change lead to a regression with the Raspberry Pi Zero W not booting
anymore.

Use -march=armv5t both for ARM1136 and ARM1176.

Fixes: 16540d07fd62 ("arm: fix -march for ARM11")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
I do not possess an ARM1136 board for testing. It would be great, if
anybody could test on real hardware.
---
 arch/arm/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.24.0

Comments

Joris Offouga Dec. 7, 2019, 11:16 a.m. UTC | #1
HI Heinrich

I test on my Raspberry Pi Zero W

You can see raw log :

U-Boot 2020.01-rc4-00123-g067f56dac4 (Dec 07 2019 - 11:52:01 +0100)

DRAM:  448 MiB
RPI Zero W (0x9000c1)
MMC:   mmc@7e202000: 0, sdhci@7e300000: 1
Loading Environment from FAT... *** Warning - bad CRC, using default 
environment

In:    serial
Out:   vidconsole
Err:   vidconsole
Net:   No ethernet found.
starting USB...
Bus usb@7e980000: scanning bus usb@7e980000 for devices... 1 USB 
Device(s) found
        scanning usb for storage devices... 0 Storage Device(s) found
Hit any key to stop autoboot:  0
U-Boot>

Tested-by: Joris Offouga <offougajoris@gmail.com>

Best Regards,

Joris

Le 07/12/2019 à 09:14, Heinrich Schuchardt a écrit :
> In GCC 9 support for the Armv5 and Armv5E architectures (which have no
> known implementations) has been removed, cf.
> https://gcc.gnu.org/gcc-9/changes.html
>
> Commit 16540d07fd62 ("arm: fix -march for ARM11") changed the value of the
> compiler flag from -march=armv5 and -march=armv5t into -march=armv6 for
> ARM11.
>
> The values prior to this patch were:
>
>      arch-$(CONFIG_CPU_ARM1136)     =-march=armv5
>      arch-$(CONFIG_CPU_ARM1176)     =-march=armv5t
>
> The change lead to a regression with the Raspberry Pi Zero W not booting
> anymore.
>
> Use -march=armv5t both for ARM1136 and ARM1176.
>
> Fixes: 16540d07fd62 ("arm: fix -march for ARM11")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> I do not possess an ARM1136 board for testing. It would be great, if
> anybody could test on real hardware.
> ---
>   arch/arm/Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 60af7e3199..856f2d8608 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -12,8 +12,8 @@ arch-$(CONFIG_CPU_ARM926EJS)	=-march=armv5te
>   arch-$(CONFIG_CPU_ARM946ES)	=-march=armv5te
>   arch-$(CONFIG_CPU_SA1100)	=-march=armv4
>   arch-$(CONFIG_CPU_PXA)		=
> -arch-$(CONFIG_CPU_ARM1136)	=-march=armv6
> -arch-$(CONFIG_CPU_ARM1176)	=-march=armv6
> +arch-$(CONFIG_CPU_ARM1136)	=-march=armv5t
> +arch-$(CONFIG_CPU_ARM1176)	=-march=armv5t
>   arch-$(CONFIG_CPU_V7A)		=$(call cc-option, -march=armv7-a, \
>   				 $(call cc-option, -march=armv7))
>   arch-$(CONFIG_CPU_V7M)		=-march=armv7-m
> --
> 2.24.0
>
Tom Rini Dec. 9, 2019, 6:48 p.m. UTC | #2
On Sat, Dec 07, 2019 at 09:14:50AM +0100, Heinrich Schuchardt wrote:

> In GCC 9 support for the Armv5 and Armv5E architectures (which have no
> known implementations) has been removed, cf.
> https://gcc.gnu.org/gcc-9/changes.html
> 
> Commit 16540d07fd62 ("arm: fix -march for ARM11") changed the value of the
> compiler flag from -march=armv5 and -march=armv5t into -march=armv6 for
> ARM11.
> 
> The values prior to this patch were:
> 
>     arch-$(CONFIG_CPU_ARM1136)     =-march=armv5
>     arch-$(CONFIG_CPU_ARM1176)     =-march=armv5t
> 
> The change lead to a regression with the Raspberry Pi Zero W not booting
> anymore.
> 
> Use -march=armv5t both for ARM1136 and ARM1176.
> 
> Fixes: 16540d07fd62 ("arm: fix -march for ARM11")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Tested-by: Joris Offouga <offougajoris@gmail.com>

Applied to u-boot/master, thanks!

Patch
diff mbox series

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 60af7e3199..856f2d8608 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -12,8 +12,8 @@  arch-$(CONFIG_CPU_ARM926EJS)	=-march=armv5te
 arch-$(CONFIG_CPU_ARM946ES)	=-march=armv5te
 arch-$(CONFIG_CPU_SA1100)	=-march=armv4
 arch-$(CONFIG_CPU_PXA)		=
-arch-$(CONFIG_CPU_ARM1136)	=-march=armv6
-arch-$(CONFIG_CPU_ARM1176)	=-march=armv6
+arch-$(CONFIG_CPU_ARM1136)	=-march=armv5t
+arch-$(CONFIG_CPU_ARM1176)	=-march=armv5t
 arch-$(CONFIG_CPU_V7A)		=$(call cc-option, -march=armv7-a, \
 				 $(call cc-option, -march=armv7))
 arch-$(CONFIG_CPU_V7M)		=-march=armv7-m