Patchwork tc: fix parallel build file with lex/yacc

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 18, 2011, 9:38 p.m.
Message ID <1318973888-29496-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/120524/
State Accepted
Delegated to: stephen hemminger
Headers show

Comments

Mike Frysinger - Oct. 18, 2011, 9:38 p.m.
Building iproute2 in parallel might hit the race failure:
	emp_ematch.l:2:30: fatal error: emp_ematch.yacc.h:
		No such file or directory
	make[1]: *** [emp_ematch.lex.o] Error 1

This is because we currently allow the yacc/lex files to generate and
compile in parallel.  So add a simple dependency to make sure yacc has
finished before we attempt to compile the lex output.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 tc/Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
stephen hemminger - Oct. 18, 2011, 10:02 p.m.
On Tue, 18 Oct 2011 17:38:08 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> Building iproute2 in parallel might hit the race failure:
> 	emp_ematch.l:2:30: fatal error: emp_ematch.yacc.h:
> 		No such file or directory
> 	make[1]: *** [emp_ematch.lex.o] Error 1
> 
> This is because we currently allow the yacc/lex files to generate and
> compile in parallel.  So add a simple dependency to make sure yacc has
> finished before we attempt to compile the lex output.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

applied
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/tc/Makefile b/tc/Makefile
index 08aa4ce..b2ca165 100644
--- a/tc/Makefile
+++ b/tc/Makefile
@@ -136,6 +136,11 @@  m_xt_old.so: m_xt_old.c
 %.lex.c: %.l
 	$(LEX) $(LEXFLAGS) -o$@ $<
 
+# our lexer includes the header from yacc, so make sure
+# we don't attempt to compile it before the header has
+# been generated as part of the yacc step.
+emp_ematch.lex.o: emp_ematch.yacc.c
+
 ifneq ($(SHARED_LIBS),y)
 
 tc: static-syms.o