Patchwork [U-Boot,1/1] devkit8000: Add malloc space for SPL

login
register
mail settings
Submitter Tom Rini
Date Oct. 18, 2011, 7:54 p.m.
Message ID <1318967677-11143-2-git-send-email-trini@ti.com>
Download mbox | patch
Permalink /patch/120500/
State Accepted
Commit ba75a81a7ab8a9be21cfcf4a78306d831465913f
Headers show

Comments

Tom Rini - Oct. 18, 2011, 7:54 p.m.
With malloc support being a new requirement for all ARM SPL
implementations, define a small area for use on devkit8000.

Cc: Frederik Kriewitz <frederik@kriewitz.eu>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Simon Schwarz <simonschwarzcor@googlemail.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
 include/configs/devkit8000.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Albert ARIBAUD - Oct. 18, 2011, 8:06 p.m.
Hi Tom,

Le 18/10/2011 21:54, Tom Rini a écrit :
> With malloc support being a new requirement for all ARM SPL
> implementations, define a small area for use on devkit8000.
>
> Cc: Frederik Kriewitz<frederik@kriewitz.eu>
> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
> Cc: Simon Schwarz<simonschwarzcor@googlemail.com>
> Signed-off-by: Tom Rini<trini@ti.com>
> ---
>   include/configs/devkit8000.h |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index ba0d23e..dc884e9 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -353,4 +353,7 @@
>   #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
>   #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
>
> +#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
> +
>   #endif /* __CONFIG_H */

Hadn't you submitted this already twelve minutes before?

Amicalement,
Tom Rini - Oct. 18, 2011, 8:16 p.m.
On 10/18/2011 01:06 PM, Albert ARIBAUD wrote:
> Hi Tom,
> 
> Le 18/10/2011 21:54, Tom Rini a écrit :
>> With malloc support being a new requirement for all ARM SPL
>> implementations, define a small area for use on devkit8000.
>>
>> Cc: Frederik Kriewitz<frederik@kriewitz.eu>
>> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
>> Cc: Simon Schwarz<simonschwarzcor@googlemail.com>
>> Signed-off-by: Tom Rini<trini@ti.com>
>> ---
>>   include/configs/devkit8000.h |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
>> index ba0d23e..dc884e9 100644
>> --- a/include/configs/devkit8000.h
>> +++ b/include/configs/devkit8000.h
>> @@ -353,4 +353,7 @@
>>   #define CONFIG_SYS_NAND_U_BOOT_OFFS    0x80000
>>   #define CONFIG_SYS_NAND_U_BOOT_SIZE    0x200000
>>
>> +#define CONFIG_SYS_SPL_MALLOC_START    0x80108000
>> +#define CONFIG_SYS_SPL_MALLOC_SIZE    0x100000    /* 1 MB */
>> +
>>   #endif /* __CONFIG_H */
> 
> Hadn't you submitted this already twelve minutes before?

Yes, but not to the ML, sorry for the duplicates to the CC'd folks.
Simon Schwarz - Oct. 21, 2011, 5:38 p.m.
On 10/18/2011 09:54 PM, Tom Rini wrote:
> With malloc support being a new requirement for all ARM SPL
> implementations, define a small area for use on devkit8000.
>
> Cc: Frederik Kriewitz<frederik@kriewitz.eu>
> Cc: Albert ARIBAUD<albert.u.boot@aribaud.net>
> Cc: Simon Schwarz<simonschwarzcor@googlemail.com>
> Signed-off-by: Tom Rini<trini@ti.com>
> ---
>   include/configs/devkit8000.h |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
> index ba0d23e..dc884e9 100644
> --- a/include/configs/devkit8000.h
> +++ b/include/configs/devkit8000.h
> @@ -353,4 +353,7 @@
>   #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
>   #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
>
> +#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
> +
>   #endif /* __CONFIG_H */

With NAND it works fine.

But with MMC there seems to be another problem with u-boot-arm. (is not 
booting at all) so:
Tested-by: Simon Schwarz <simonschwarzcor@gmail.com>

Presumably I won't have the time to look into the MMC problem until next 
week - volunteers? ;)

Regards
Simon

Patch

diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h
index ba0d23e..dc884e9 100644
--- a/include/configs/devkit8000.h
+++ b/include/configs/devkit8000.h
@@ -353,4 +353,7 @@ 
 #define CONFIG_SYS_NAND_U_BOOT_OFFS	0x80000
 #define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200000
 
+#define CONFIG_SYS_SPL_MALLOC_START	0x80108000
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
+
 #endif /* __CONFIG_H */