diff mbox series

[2/4] package/python-twisted: add config for TLS support

Message ID 20191205221515.3121562-2-aduskett@gmail.com
State Accepted
Headers show
Series [1/4] package/python-twisted: bump to version 19.10.0 | expand

Commit Message

Adam Duskett Dec. 5, 2019, 10:15 p.m. UTC 
From: Adam Duskett <Aduskett@gmail.com>

Add an option that selects all of the necessary python packages to ensure that
twisted has TLS support.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/python-twisted/Config.in | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Thomas Petazzoni Dec. 6, 2019, 10:19 p.m. UTC | #1 
On Thu,  5 Dec 2019 14:15:13 -0800
aduskett@gmail.com wrote:

> +if BR2_PACKAGE_PYTHON_TWISTED
> +
> +config BR2_PACKAGE_PYTHON_TWISTED_TLS
> +	bool "TLS support"
> +	depends on BR2_INSTALL_LIBSTDCPP # python-pyopenssl, python-cryptography

We don't really care about python-cryptography here, since it's not a
direct dependencies. However, python-service-identify does have a C++
dependency, so it made more sense to list that here.

> +	select BR2_PACKAGE_PYTHON_PYOPENSSL # runtime
> +	select BR2_PACKAGE_PYTHON_SERVICE_IDENTITY # runtime
> +	select BR2_PACKAGE_PYTHON_IDNA # runtime

Alphabetic ordering was not good.

I fixed up both issues and applied. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python-twisted/Config.in b/package/python-twisted/Config.in
index b72952f979..f3d94c544e 100644
--- a/package/python-twisted/Config.in
+++ b/package/python-twisted/Config.in
@@ -12,3 +12,17 @@  config BR2_PACKAGE_PYTHON_TWISTED
 	  Python.
 
 	  https://twistedmatrix.com/trac/
+
+if BR2_PACKAGE_PYTHON_TWISTED
+
+config BR2_PACKAGE_PYTHON_TWISTED_TLS
+	bool "TLS support"
+	depends on BR2_INSTALL_LIBSTDCPP # python-pyopenssl, python-cryptography
+	select BR2_PACKAGE_PYTHON_PYOPENSSL # runtime
+	select BR2_PACKAGE_PYTHON_SERVICE_IDENTITY # runtime
+	select BR2_PACKAGE_PYTHON_IDNA # runtime
+
+comment "TLS support needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
+
+endif