[v8,17/21] hw/usb: rename Error ** parameter to more common errp
diff mbox series

Message ID 20191205174635.18758-18-vsementsov@virtuozzo.com
State New
Headers show
Series
  • error: prepare for auto propagated local_err
Related show

Commit Message

Vladimir Sementsov-Ogievskiy Dec. 5, 2019, 5:46 p.m. UTC
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 hw/usb/dev-network.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Dec. 6, 2019, 7:38 a.m. UTC | #1
On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   hw/usb/dev-network.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
> index 5de6213cc4..b81a8abe83 100644
> --- a/hw/usb/dev-network.c
> +++ b/hw/usb/dev-network.c
> @@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
>       .cleanup = usbnet_cleanup,
>   };
>   
> -static void usb_net_realize(USBDevice *dev, Error **errrp)

Funny one.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> +static void usb_net_realize(USBDevice *dev, Error **errp)
>   {
>       USBNetState *s = USB_NET(dev);
>   
>
Vladimir Sementsov-Ogievskiy Dec. 6, 2019, 10:19 a.m. UTC | #2
06.12.2019 10:38, Philippe Mathieu-Daudé wrote:
> On 12/5/19 6:46 PM, Vladimir Sementsov-Ogievskiy wrote:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   hw/usb/dev-network.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
>> index 5de6213cc4..b81a8abe83 100644
>> --- a/hw/usb/dev-network.c
>> +++ b/hw/usb/dev-network.c
>> @@ -1342,7 +1342,7 @@ static NetClientInfo net_usbnet_info = {
>>       .cleanup = usbnet_cleanup,
>>   };
>> -static void usb_net_realize(USBDevice *dev, Error **errrp)
> 
> Funny one.
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Thanks a lot for reviewing!

Patch
diff mbox series

diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c
index 5de6213cc4..b81a8abe83 100644
--- a/hw/usb/dev-network.c
+++ b/hw/usb/dev-network.c
@@ -1342,7 +1342,7 @@  static NetClientInfo net_usbnet_info = {
     .cleanup = usbnet_cleanup,
 };
 
-static void usb_net_realize(USBDevice *dev, Error **errrp)
+static void usb_net_realize(USBDevice *dev, Error **errp)
 {
     USBNetState *s = USB_NET(dev);