[1/1] pinctrl: Modify Kconfig to fix linker error
diff mbox series

Message ID ba937f271d1a2173828a2325990d62cb36d61595.1575514110.git.rahul.tanwar@linux.intel.com
State New
Headers show
Series
  • pinctrl: pinctrl-v5.5-2: Fix linker error
Related show

Commit Message

Tanwar, Rahul Dec. 5, 2019, 3:01 a.m. UTC
Fix below linker error

    ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
    `pinconf_generic_dt_node_to_map_all':
    pinctrl-equilibrium.c:(.text+0xb): undefined reference
    to `pinconf_generic_dt_node_to_map'

Caused by below commit

    1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

by adding 'depends on OF' in Kconfig driver entry.

Reported-by: Randy Dunlap <rdunlap@infradead.org>>
Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap Dec. 5, 2019, 3:42 a.m. UTC | #1
On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
> 
>     ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
>     `pinconf_generic_dt_node_to_map_all':
>     pinctrl-equilibrium.c:(.text+0xb): undefined reference
>     to `pinconf_generic_dt_node_to_map'
> 
> Caused by below commit
> 
>     1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> 
> by adding 'depends on OF' in Kconfig driver entry.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested


Thanks.

> ---
>  drivers/pinctrl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>  
>  config PINCTRL_EQUILIBRIUM
>  	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> +	depends on OF
>  	select PINMUX
>  	select PINCONF
>  	select GPIOLIB
>
Linus Walleij Dec. 13, 2019, 10:05 a.m. UTC | #2
On Thu, Dec 5, 2019 at 4:01 AM Rahul Tanwar
<rahul.tanwar@linux.intel.com> wrote:

> Fix below linker error
>
>     ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
>     `pinconf_generic_dt_node_to_map_all':
>     pinctrl-equilibrium.c:(.text+0xb): undefined reference
>     to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
>     1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>

Patch applied for fixes, thanks!

Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 3bfbf2ff6e2b..ba0cad4bd072 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -422,6 +422,7 @@  config PINCTRL_TB10X
 
 config PINCTRL_EQUILIBRIUM
 	tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+	depends on OF
 	select PINMUX
 	select PINCONF
 	select GPIOLIB