[PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface
diff mbox series

Message ID 20191204233918.6073-1-philmd@redhat.com
State New
Headers show
Series
  • [PATCH-for-5.0] hw/alpha/dp264: Use the DECchip Tulip network interface
Related show

Commit Message

Philippe Mathieu-Daudé Dec. 4, 2019, 11:39 p.m. UTC
Commit 34ea023d4b9 introduced the Tulip PCI NIC.
Since this better models the DP264 hardware, use it.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/alpha/dp264.c | 4 ++--
 hw/alpha/Kconfig | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Richard Henderson Dec. 5, 2019, 8:38 p.m. UTC | #1
On 12/4/19 3:39 PM, Philippe Mathieu-Daudé wrote:
> Commit 34ea023d4b9 introduced the Tulip PCI NIC.
> Since this better models the DP264 hardware, use it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/alpha/dp264.c | 4 ++--
>  hw/alpha/Kconfig | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

I've tested that a 5.4 kernel built for alpha is able to communicate via this
driver model.


r~

Patch
diff mbox series

diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c
index 51b3cf7a61..4424551ba1 100644
--- a/hw/alpha/dp264.c
+++ b/hw/alpha/dp264.c
@@ -85,9 +85,9 @@  static void clipper_init(MachineState *machine)
     /* VGA setup.  Don't bother loading the bios.  */
     pci_vga_init(pci_bus);
 
-    /* Network setup.  e1000 is good enough, failing Tulip support.  */
+    /* Network setup */
     for (i = 0; i < nb_nics; i++) {
-        pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL);
+        pci_nic_init_nofail(&nd_table[i], pci_bus, "tulip", NULL);
     }
 
     /* 2 82C37 (dma) */
diff --git a/hw/alpha/Kconfig b/hw/alpha/Kconfig
index 15c59ff264..552e6a4c23 100644
--- a/hw/alpha/Kconfig
+++ b/hw/alpha/Kconfig
@@ -2,7 +2,7 @@  config DP264
     bool
     imply PCI_DEVICES
     imply TEST_DEVICES
-    imply E1000_PCI
+    imply TULIP
     select I82374
     select I8254
     select I8259