[1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio
diff mbox series

Message ID 20191204175112.7308-1-dmurphy@ti.com
State Not Applicable
Headers show
Series
  • [1/2] dt-bindings: tcan4x5x: Make wake-gpio an optional gpio
Related show

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 14 lines checked"

Commit Message

Dan Murphy Dec. 4, 2019, 5:51 p.m. UTC
The wake-up of the device can be configured as an optional
feature of the device.  Move the wake-up gpio from a requried
property to an optional property.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
CC: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Nyekjaer Dec. 5, 2019, 7:36 a.m. UTC | #1
On 04/12/2019 18.51, Dan Murphy wrote:
> The wake-up of the device can be configured as an optional
> feature of the device.  Move the wake-up gpio from a requried
> property to an optional property.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Rob Herring <robh@kernel.org>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---
>   Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index 27e1b4cebfbd..7cf5ef7acba4 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -10,7 +10,6 @@ Required properties:
>   	- #size-cells: 0
>   	- spi-max-frequency: Maximum frequency of the SPI bus the chip can
>   			     operate at should be less than or equal to 18 MHz.
> -	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>   	- interrupt-parent: the phandle to the interrupt controller which provides
>                       the interrupt.
>   	- interrupts: interrupt specification for data-ready.
> @@ -23,6 +22,7 @@ Optional properties:
>   		       reset.
>   	- device-state-gpios: Input GPIO that indicates if the device is in
>   			      a sleep state or if the device is active.
> +	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>   
>   Example:
>   tcan4x5x: tcan4x5x@0 {
>
Sean Nyekjaer Dec. 5, 2019, 7:39 a.m. UTC | #2
On 04/12/2019 18.51, Dan Murphy wrote:
> The device has the ability to disable the wake-up pin option.
> The wake-up pin can be either force to GND or Vsup and does not have to
> be tied to a GPIO.  In order for the device to not use the wake-up feature
> write the register to disable the WAKE_CONFIG option.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Sean Nyekjaer <sean@geanix.com>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
> ---


Hi Dan,

I would add tcan4x5x to the subject of this patch ->
"net: m_can: tcan4x5x Make wake-up gpio an optional"

Will be testing this during this or the next week...

/Sean
Dan Murphy Dec. 5, 2019, 1:26 p.m. UTC | #3
Marc

On 12/5/19 1:39 AM, Sean Nyekjaer wrote:
>
>
> On 04/12/2019 18.51, Dan Murphy wrote:
>> The device has the ability to disable the wake-up pin option.
>> The wake-up pin can be either force to GND or Vsup and does not have to
>> be tied to a GPIO.  In order for the device to not use the wake-up 
>> feature
>> write the register to disable the WAKE_CONFIG option.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Sean Nyekjaer <sean@geanix.com>
> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>
>
> Hi Dan,
>
> I would add tcan4x5x to the subject of this patch ->
> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>
Do you want me to submit v2 with the $subject change?

Or would you fix it up when committing it?

Dan
Marc Kleine-Budde Dec. 5, 2019, 2:39 p.m. UTC | #4
On 12/5/19 2:26 PM, Dan Murphy wrote:
> On 12/5/19 1:39 AM, Sean Nyekjaer wrote:
>>
>>
>> On 04/12/2019 18.51, Dan Murphy wrote:
>>> The device has the ability to disable the wake-up pin option.
>>> The wake-up pin can be either force to GND or Vsup and does not have to
>>> be tied to a GPIO.  In order for the device to not use the wake-up 
>>> feature
>>> write the register to disable the WAKE_CONFIG option.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>> CC: Sean Nyekjaer <sean@geanix.com>
>> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
>>> ---
>>
>>
>> Hi Dan,
>>
>> I would add tcan4x5x to the subject of this patch ->
>> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>>
> Do you want me to submit v2 with the $subject change?
> 
> Or would you fix it up when committing it?

I'll change the subject while applying.

Dan, what about maintainerchip of the tcan4x5?

regards,
Marc
Dan Murphy Dec. 5, 2019, 3:01 p.m. UTC | #5
Marc

On 12/5/19 8:39 AM, Marc Kleine-Budde wrote:
> On 12/5/19 2:26 PM, Dan Murphy wrote:
>> On 12/5/19 1:39 AM, Sean Nyekjaer wrote:
>>>
>>> On 04/12/2019 18.51, Dan Murphy wrote:
>>>> The device has the ability to disable the wake-up pin option.
>>>> The wake-up pin can be either force to GND or Vsup and does not have to
>>>> be tied to a GPIO.  In order for the device to not use the wake-up
>>>> feature
>>>> write the register to disable the WAKE_CONFIG option.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>> CC: Sean Nyekjaer <sean@geanix.com>
>>> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
>>>> ---
>>>
>>> Hi Dan,
>>>
>>> I would add tcan4x5x to the subject of this patch ->
>>> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>>>
>> Do you want me to submit v2 with the $subject change?
>>
>> Or would you fix it up when committing it?
> I'll change the subject while applying.
>
> Dan, what about maintainerchip of the tcan4x5?

Ooops that was buried in my inbox.

It only makes sense for someone from TI to take maintainership of the 
TCAN device.

Do I need to submit a patch to the maintainers file or is the authorship 
enough?

As far as a device what country do you reside in?

Dan


> regards,
> Marc
>
Marc Kleine-Budde Dec. 5, 2019, 3:35 p.m. UTC | #6
On 12/5/19 4:01 PM, Dan Murphy wrote:
>> Dan, what about maintainerchip of the tcan4x5?
> 
> Ooops that was buried in my inbox.
> 
> It only makes sense for someone from TI to take maintainership of the 
> TCAN device.

Sriram Dash (Cc'ed) is maintainer of the MMIO driver:

> +F:     Documentation/devicetree/bindings/net/can/m_can.txt                                                                                                                                                        
> +F:     drivers/net/can/m_can/m_can.c                                                                                                                                                                              
> +F:     drivers/net/can/m_can/m_can.h                                                                                                                                                                              
> +F:     drivers/net/can/m_can/m_can_platform.c                                                                                                                                                                     

See:

> Do I need to submit a patch to the maintainers file or is the authorship 
> enough?

Yes, please send a patch, see Sriram's patch as an example:

> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?h=linux-can-fixes-for-5.5-20191203&id=8c2a58568d6d952f7c7f1dac125b33dc8414627b

> As far as a device what country do you reside in?

Germany, I'll drop you the address in a private Mail.

Marc
Sean Nyekjaer Dec. 6, 2019, 1:49 p.m. UTC | #7
On 04/12/2019 18.51, Dan Murphy wrote:
> The wake-up of the device can be configured as an optional
> feature of the device.  Move the wake-up gpio from a requried
> property to an optional property.
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> CC: Rob Herring <robh@kernel.org>
Tested-by: Sean Nyekjaer <sean@geanix.com>
> ---
>   Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> index 27e1b4cebfbd..7cf5ef7acba4 100644
> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
> @@ -10,7 +10,6 @@ Required properties:
>   	- #size-cells: 0
>   	- spi-max-frequency: Maximum frequency of the SPI bus the chip can
>   			     operate at should be less than or equal to 18 MHz.
> -	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>   	- interrupt-parent: the phandle to the interrupt controller which provides
>                       the interrupt.
>   	- interrupts: interrupt specification for data-ready.
> @@ -23,6 +22,7 @@ Optional properties:
>   		       reset.
>   	- device-state-gpios: Input GPIO that indicates if the device is in
>   			      a sleep state or if the device is active.
> +	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>   
>   Example:
>   tcan4x5x: tcan4x5x@0 {
>
Sean Nyekjaer Dec. 6, 2019, 1:49 p.m. UTC | #8
On 05/12/2019 08.36, Sean Nyekjaer wrote:
> 
> 
> On 04/12/2019 18.51, Dan Murphy wrote:
>> The wake-up of the device can be configured as an optional
>> feature of the device.  Move the wake-up gpio from a requried
>> property to an optional property.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> CC: Rob Herring <robh@kernel.org>
> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
Tested-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>>   Documentation/devicetree/bindings/net/can/tcan4x5x.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt 
>> b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> index 27e1b4cebfbd..7cf5ef7acba4 100644
>> --- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> +++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
>> @@ -10,7 +10,6 @@ Required properties:
>>       - #size-cells: 0
>>       - spi-max-frequency: Maximum frequency of the SPI bus the chip can
>>                    operate at should be less than or equal to 18 MHz.
>> -    - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>>       - interrupt-parent: the phandle to the interrupt controller 
>> which provides
>>                       the interrupt.
>>       - interrupts: interrupt specification for data-ready.
>> @@ -23,6 +22,7 @@ Optional properties:
>>                  reset.
>>       - device-state-gpios: Input GPIO that indicates if the device is in
>>                     a sleep state or if the device is active.
>> +    - device-wake-gpios: Wake up GPIO to wake up the TCAN device.
>>   Example:
>>   tcan4x5x: tcan4x5x@0 {
>>
Dan Murphy Dec. 9, 2019, 9:01 p.m. UTC | #9
Marc

On 12/5/19 8:39 AM, Marc Kleine-Budde wrote:
> On 12/5/19 2:26 PM, Dan Murphy wrote:
>> On 12/5/19 1:39 AM, Sean Nyekjaer wrote:
>>>
>>> On 04/12/2019 18.51, Dan Murphy wrote:
>>>> The device has the ability to disable the wake-up pin option.
>>>> The wake-up pin can be either force to GND or Vsup and does not have to
>>>> be tied to a GPIO.  In order for the device to not use the wake-up
>>>> feature
>>>> write the register to disable the WAKE_CONFIG option.
>>>>
>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>> CC: Sean Nyekjaer <sean@geanix.com>
>>> Reviewed-by: Sean Nyekjaer <sean@geanix.com>
>>>> ---
>>>
>>> Hi Dan,
>>>
>>> I would add tcan4x5x to the subject of this patch ->
>>> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>>>
>> Do you want me to submit v2 with the $subject change?
>>
>> Or would you fix it up when committing it?
> I'll change the subject while applying.
>
> Dan, what about maintainerchip of the tcan4x5?

Do you know when you will be applying these?

I have 2 patches I need to put on top.

Dan

> regards,
> Marc
>
Marc Kleine-Budde Dec. 9, 2019, 9:06 p.m. UTC | #10
On 12/9/19 10:01 PM, Dan Murphy wrote:
>>>> I would add tcan4x5x to the subject of this patch ->
>>>> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>>>>
>>> Do you want me to submit v2 with the $subject change?
>>>
>>> Or would you fix it up when committing it?
>> I'll change the subject while applying.
>>
>> Dan, what about maintainerchip of the tcan4x5?
> 
> Do you know when you will be applying these?

The patch is already upstream. See linux-can/mater:

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?id=2de497356955ce58cd066fb03d2da5235f3c7c23

> I have 2 patches I need to put on top.

Please post them as linux-can/master as base.

regards,
Marc
Dan Murphy Dec. 9, 2019, 9:07 p.m. UTC | #11
Marc

On 12/9/19 3:06 PM, Marc Kleine-Budde wrote:
> On 12/9/19 10:01 PM, Dan Murphy wrote:
>>>>> I would add tcan4x5x to the subject of this patch ->
>>>>> "net: m_can: tcan4x5x Make wake-up gpio an optional"
>>>>>
>>>> Do you want me to submit v2 with the $subject change?
>>>>
>>>> Or would you fix it up when committing it?
>>> I'll change the subject while applying.
>>>
>>> Dan, what about maintainerchip of the tcan4x5?
>> Do you know when you will be applying these?
> The patch is already upstream. See linux-can/mater:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?id=2de497356955ce58cd066fb03d2da5235f3c7c23

Ah I was looking here

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git

>
Marc Kleine-Budde Dec. 9, 2019, 9:10 p.m. UTC | #12
On 12/9/19 10:07 PM, Dan Murphy wrote:
>>> Do you know when you will be applying these?
>> The patch is already upstream. See linux-can/mater:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/commit/?id=2de497356955ce58cd066fb03d2da5235f3c7c23
> 
> Ah I was looking here
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git

Bugfixes go to linux-can. New features to linux-can-next.

Marc

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
index 27e1b4cebfbd..7cf5ef7acba4 100644
--- a/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
+++ b/Documentation/devicetree/bindings/net/can/tcan4x5x.txt
@@ -10,7 +10,6 @@  Required properties:
 	- #size-cells: 0
 	- spi-max-frequency: Maximum frequency of the SPI bus the chip can
 			     operate at should be less than or equal to 18 MHz.
-	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
 	- interrupt-parent: the phandle to the interrupt controller which provides
                     the interrupt.
 	- interrupts: interrupt specification for data-ready.
@@ -23,6 +22,7 @@  Optional properties:
 		       reset.
 	- device-state-gpios: Input GPIO that indicates if the device is in
 			      a sleep state or if the device is active.
+	- device-wake-gpios: Wake up GPIO to wake up the TCAN device.
 
 Example:
 tcan4x5x: tcan4x5x@0 {