Message ID | 20191204083133.6198-1-thuth@redhat.com |
---|---|
State | New |
Headers | show |
Series | [v3] travis.yml: Run tcg tests with tci | expand |
On 12/4/19 12:31 AM, Thomas Huth wrote: > - # We manually include builds which we disable "make check" for > + # Check the TCG interpreter (TCI) > - env: > - - CONFIG="--enable-debug --enable-tcg-interpreter" > - - TEST_CMD="" > + - CONFIG="--enable-debug --enable-tcg-interpreter --disable-kvm While we're changing things, the interpreter will go much faster with optimization enabled. We can change this to --enable-debug-tcg, which leaves the asserts enabled, but compiles with -O2. r~
Thomas Huth <thuth@redhat.com> writes: > So far we only have compile coverage for tci. But since commit > 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation > for INDEX_op_ld16u_i64") has been included now, we can also run the > "tcg" and "qtest" tests with tci, so let's enable them in Travis now. > Since we don't gain much additional test coverage by compiling all > targets, and TCI is broken e.g. with the Sparc targets, we also limit > the target list to a reasonable subset now (which should still get us > test coverage by tests/boot-serial-test for example). Queued to testing/next, thanks. > > Tested-by: Stefan Weil <sw@weilnetz.de> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > v3: > - Add --disable-kvm option since we're only interested in TCG here > > .travis.yml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 445b0646c1..d73e2fb744 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -215,10 +215,11 @@ matrix: > - TEST_CMD="" > > > - # We manually include builds which we disable "make check" for > + # Check the TCG interpreter (TCI) > - env: > - - CONFIG="--enable-debug --enable-tcg-interpreter" > - - TEST_CMD="" > + - CONFIG="--enable-debug --enable-tcg-interpreter --disable-kvm --disable-containers > + --target-list=alpha-softmmu,arm-softmmu,hppa-softmmu,m68k-softmmu,microblaze-softmmu,moxie-softmmu,ppc-softmmu,s390x-softmmu,x86_64-softmmu" > + - TEST_CMD="make check-qtest check-tcg V=1" > > > # We don't need to exercise every backend with every front-end
On 04/12/2019 14.48, Alex Bennée wrote: > > Thomas Huth <thuth@redhat.com> writes: > >> So far we only have compile coverage for tci. But since commit >> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >> for INDEX_op_ld16u_i64") has been included now, we can also run the >> "tcg" and "qtest" tests with tci, so let's enable them in Travis now. >> Since we don't gain much additional test coverage by compiling all >> targets, and TCI is broken e.g. with the Sparc targets, we also limit >> the target list to a reasonable subset now (which should still get us >> test coverage by tests/boot-serial-test for example). > > Queued to testing/next, thanks. Thanks! But could you maybe s/--enable-debug/--enable-debug-tcg/ as Richard just suggested in his mail? Or want me to send a v4? Thomas
Richard Henderson <richard.henderson@linaro.org> writes: > On 12/4/19 12:31 AM, Thomas Huth wrote: >> - # We manually include builds which we disable "make check" for >> + # Check the TCG interpreter (TCI) >> - env: >> - - CONFIG="--enable-debug --enable-tcg-interpreter" >> - - TEST_CMD="" >> + - CONFIG="--enable-debug --enable-tcg-interpreter --disable-kvm > > While we're changing things, the interpreter will go much faster with > optimization enabled. We can change this to --enable-debug-tcg, which leaves > the asserts enabled, but compiles with -O2. I've amended the commit in my tree - no need to resend. > > > r~
Thomas Huth <thuth@redhat.com> writes: > On 04/12/2019 14.48, Alex Bennée wrote: >> >> Thomas Huth <thuth@redhat.com> writes: >> >>> So far we only have compile coverage for tci. But since commit >>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >>> for INDEX_op_ld16u_i64") has been included now, we can also run the >>> "tcg" and "qtest" tests with tci, so let's enable them in Travis now. >>> Since we don't gain much additional test coverage by compiling all >>> targets, and TCI is broken e.g. with the Sparc targets, we also limit >>> the target list to a reasonable subset now (which should still get us >>> test coverage by tests/boot-serial-test for example). >> >> Queued to testing/next, thanks. > > Thanks! But could you maybe s/--enable-debug/--enable-debug-tcg/ as > Richard just suggested in his mail? Or want me to send a v4? I fixed it in my tree, no need to send v4 > > Thomas
diff --git a/.travis.yml b/.travis.yml index 445b0646c1..d73e2fb744 100644 --- a/.travis.yml +++ b/.travis.yml @@ -215,10 +215,11 @@ matrix: - TEST_CMD="" - # We manually include builds which we disable "make check" for + # Check the TCG interpreter (TCI) - env: - - CONFIG="--enable-debug --enable-tcg-interpreter" - - TEST_CMD="" + - CONFIG="--enable-debug --enable-tcg-interpreter --disable-kvm --disable-containers + --target-list=alpha-softmmu,arm-softmmu,hppa-softmmu,m68k-softmmu,microblaze-softmmu,moxie-softmmu,ppc-softmmu,s390x-softmmu,x86_64-softmmu" + - TEST_CMD="make check-qtest check-tcg V=1" # We don't need to exercise every backend with every front-end