| Message ID | 20191204063717.102854-1-maowenan@huawei.com |
|---|---|
| State | Superseded |
| Delegated to: | David Miller |
| Headers | show |
| Series | [-next] NFC: port100: Convert cpu_to_le16(le16_to_cpu(E1) + E2) to use le16_add_cpu(). | expand |
From: Mao Wenan <maowenan@huawei.com> Date: Wed, 4 Dec 2019 14:37:17 +0800 > It is better to convert cpu_to_le16(le16_to_cpu(frame->datalen) + len) to > use le16_add_cpu(). > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> Please resubmit when the net-next tree is open again, right now it is closed: http://vger.kernel.org/~davem/net-next.html
diff --git a/drivers/nfc/port100.c b/drivers/nfc/port100.c index 604dba4..8e4d355 100644 --- a/drivers/nfc/port100.c +++ b/drivers/nfc/port100.c @@ -565,7 +565,7 @@ static void port100_tx_update_payload_len(void *_frame, int len) { struct port100_frame *frame = _frame; - frame->datalen = cpu_to_le16(le16_to_cpu(frame->datalen) + len); + le16_add_cpu(&frame->datalen, len); } static bool port100_rx_frame_is_valid(void *_frame)
It is better to convert cpu_to_le16(le16_to_cpu(frame->datalen) + len) to use le16_add_cpu(). Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/nfc/port100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)