From patchwork Tue Oct 18 02:06:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: correctly null terminate the process name Date: Mon, 17 Oct 2011 16:06:32 -0000 From: Trevor Saunders X-Patchwork-Id: 120357 Message-Id: <1318903592-4851-1-git-send-email-trev.saunders@gmail.com> To: qemu-devel@nongnu.org Cc: Trevor Saunders strncpy() doesn't garentee the copied string will be null terminated if the original is longer than the length to copy. Signed-off-by: Trevor Saunders Reviewed-by: Stefan Weil --- os-posix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/os-posix.c b/os-posix.c index dbf3b24..92dcc97 100644 --- a/os-posix.c +++ b/os-posix.c @@ -149,8 +149,8 @@ void os_set_proc_name(const char *s) char name[16]; if (!s) return; - name[sizeof(name) - 1] = 0; strncpy(name, s, sizeof(name)); + name[sizeof(name) - 1] = 0; /* Could rewrite argv[0] too, but that's a bit more complicated. This simple way is enough for `top'. */ if (prctl(PR_SET_NAME, name)) {