sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
diff mbox series

Message ID 20191202141138.26194-1-victorien.molle@wifirst.fr
State Accepted
Delegated to: David Miller
Headers show
Series
  • sch_cake: Add missing NLA policy entry TCA_CAKE_SPLIT_GSO
Related show

Commit Message

Victorien Molle Dec. 2, 2019, 2:11 p.m. UTC
This field has never been checked since introduction in mainline kernel

Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"
---
 net/sched/sch_cake.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Toke Høiland-Jørgensen Dec. 2, 2019, 3:18 p.m. UTC | #1
Victorien Molle <victorien.molle@wifirst.fr> writes:

> This field has never been checked since introduction in mainline kernel
>
> Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"

Don't suppose this is likely to break anything by stricter enforcement,
so:

Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
David Miller Dec. 2, 2019, 8:33 p.m. UTC | #2
From: Victorien Molle <victorien.molle@wifirst.fr>
Date: Mon,  2 Dec 2019 15:11:38 +0100

> This field has never been checked since introduction in mainline kernel
> 
> Signed-off-by: Victorien Molle <victorien.molle@wifirst.fr>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
> Fixes: 2db6dc2662ba "sch_cake: Make gso-splitting configurable from userspace"

Applied, thanks.

Patch
diff mbox series

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 53a80bc6b13a..e0f40400f679 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -2184,6 +2184,7 @@  static const struct nla_policy cake_policy[TCA_CAKE_MAX + 1] = {
 	[TCA_CAKE_MPU]		 = { .type = NLA_U32 },
 	[TCA_CAKE_INGRESS]	 = { .type = NLA_U32 },
 	[TCA_CAKE_ACK_FILTER]	 = { .type = NLA_U32 },
+	[TCA_CAKE_SPLIT_GSO]	 = { .type = NLA_U32 },
 	[TCA_CAKE_FWMARK]	 = { .type = NLA_U32 },
 };