Patchwork [Oneiric,SRU/Precise,1/1] Revert "UBUNTU: ubuntu: fsam7400 disable driver"

login
register
mail settings
Submitter Leann Ogasawara
Date Oct. 17, 2011, 6:09 p.m.
Message ID <1318874978.2155.195.camel@adamo>
Download mbox | patch
Permalink /patch/120276/
State New
Headers show

Comments

Leann Ogasawara - Oct. 17, 2011, 6:09 p.m.
BugLink: http://bugs.launchpad.net/bugs/876030

Please consider the following for Oneiric SRU and Precise.

== Oneiric SRU Justification ==
Per the Oneiric Ubuntu Kernel Delta review [1], we purposely decided to
disable the fsam7400 kernel module because it is an out of tree module
which produces an extra maintenance burden and overhead every release.
Should anyone object, it would be re-enabled. If there were no
objections, it would be dropped in the subsequent 12.04 Precise LTS
release. A bug reporter has requested we re-enable this module.  They
have tested and confirmed it provides rfkill switch support on their
Fujitsu laptop.

== Impact ==
Confirmed to affect Fujitsu Siemens Amilo Pro V3505, likely other
Fujitsu models are affected as well.

== Fix ==
Re-enable the fsam7400 module

Thanks,
Leann

[1] https://wiki.ubuntu.com/KernelTeam/Specs/KernelOneiricUbuntuDeltaReview

From 29aa41d8752b4c2fd6d16067f1386749507ff373 Mon Sep 17 00:00:00 2001
From: Leann Ogasawara <leann.ogasawara@canonical.com>
Date: Mon, 17 Oct 2011 07:06:09 -0700
Subject: [PATCH] Revert "UBUNTU: ubuntu: fsam7400 disable driver"

BugLink: http://bugs.launchpad.net/bugs/876030

This reverts commit 2c2ebcbf14a86f4af59ef1d4d420d3f19083472c.

Per the Oneiric Ubuntu Delta Review we purposely disabled the fsam7400
driver with the hopes that we could then completely drop the driver for
Precise 12.04.  However, there are reports that this driver is still in
use.  Re-enable the driver.

Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
---
 ubuntu/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Herton Ronaldo Krzesinski - Oct. 17, 2011, 8:20 p.m.
On Mon, Oct 17, 2011 at 11:09:38AM -0700, Leann Ogasawara wrote:
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> Please consider the following for Oneiric SRU and Precise.
> 
> == Oneiric SRU Justification ==
> Per the Oneiric Ubuntu Kernel Delta review [1], we purposely decided to
> disable the fsam7400 kernel module because it is an out of tree module
> which produces an extra maintenance burden and overhead every release.
> Should anyone object, it would be re-enabled. If there were no
> objections, it would be dropped in the subsequent 12.04 Precise LTS
> release. A bug reporter has requested we re-enable this module.  They
> have tested and confirmed it provides rfkill switch support on their
> Fujitsu laptop.
> 
> == Impact ==
> Confirmed to affect Fujitsu Siemens Amilo Pro V3505, likely other
> Fujitsu models are affected as well.
> 
> == Fix ==
> Re-enable the fsam7400 module
> 
> Thanks,
> Leann
> 
> [1] https://wiki.ubuntu.com/KernelTeam/Specs/KernelOneiricUbuntuDeltaReview
> 
> From 29aa41d8752b4c2fd6d16067f1386749507ff373 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Mon, 17 Oct 2011 07:06:09 -0700
> Subject: [PATCH] Revert "UBUNTU: ubuntu: fsam7400 disable driver"
> 
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> This reverts commit 2c2ebcbf14a86f4af59ef1d4d420d3f19083472c.
> 
> Per the Oneiric Ubuntu Delta Review we purposely disabled the fsam7400
> driver with the hopes that we could then completely drop the driver for
> Precise 12.04.  However, there are reports that this driver is still in
> use.  Re-enable the driver.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> ---
>  ubuntu/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 7ac7805..30b3ded 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_NDISWRAPPER)	+= ndiswrapper/
>  ##
>  ##
>  ##
> -#obj-$(CONFIG_FSAM7400)		+= fsam7400/
> +obj-$(CONFIG_FSAM7400)		+= fsam7400/
>  ##
>  ##
>  ##
> -- 
> 1.7.4.1
> 

Acked-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
Seth Forshee - Oct. 17, 2011, 8:29 p.m.
On Mon, Oct 17, 2011 at 11:09:38AM -0700, Leann Ogasawara wrote:
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> Please consider the following for Oneiric SRU and Precise.
> 
> == Oneiric SRU Justification ==
> Per the Oneiric Ubuntu Kernel Delta review [1], we purposely decided to
> disable the fsam7400 kernel module because it is an out of tree module
> which produces an extra maintenance burden and overhead every release.
> Should anyone object, it would be re-enabled. If there were no
> objections, it would be dropped in the subsequent 12.04 Precise LTS
> release. A bug reporter has requested we re-enable this module.  They
> have tested and confirmed it provides rfkill switch support on their
> Fujitsu laptop.
> 
> == Impact ==
> Confirmed to affect Fujitsu Siemens Amilo Pro V3505, likely other
> Fujitsu models are affected as well.
> 
> == Fix ==
> Re-enable the fsam7400 module
> 
> Thanks,
> Leann
> 
> [1] https://wiki.ubuntu.com/KernelTeam/Specs/KernelOneiricUbuntuDeltaReview
> 
> From 29aa41d8752b4c2fd6d16067f1386749507ff373 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Mon, 17 Oct 2011 07:06:09 -0700
> Subject: [PATCH] Revert "UBUNTU: ubuntu: fsam7400 disable driver"
> 
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> This reverts commit 2c2ebcbf14a86f4af59ef1d4d420d3f19083472c.
> 
> Per the Oneiric Ubuntu Delta Review we purposely disabled the fsam7400
> driver with the hopes that we could then completely drop the driver for
> Precise 12.04.  However, there are reports that this driver is still in
> use.  Re-enable the driver.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>

> ---
>  ubuntu/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 7ac7805..30b3ded 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_NDISWRAPPER)	+= ndiswrapper/
>  ##
>  ##
>  ##
> -#obj-$(CONFIG_FSAM7400)		+= fsam7400/
> +obj-$(CONFIG_FSAM7400)		+= fsam7400/
>  ##
>  ##
>  ##
> -- 
> 1.7.4.1
> 
> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Leann Ogasawara - Oct. 17, 2011, 8:56 p.m.
Applied to Oneiric master-next and Precise master-next.

Thanks,
Leann

On Mon, 2011-10-17 at 11:09 -0700, Leann Ogasawara wrote:
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> Please consider the following for Oneiric SRU and Precise.
> 
> == Oneiric SRU Justification ==
> Per the Oneiric Ubuntu Kernel Delta review [1], we purposely decided to
> disable the fsam7400 kernel module because it is an out of tree module
> which produces an extra maintenance burden and overhead every release.
> Should anyone object, it would be re-enabled. If there were no
> objections, it would be dropped in the subsequent 12.04 Precise LTS
> release. A bug reporter has requested we re-enable this module.  They
> have tested and confirmed it provides rfkill switch support on their
> Fujitsu laptop.
> 
> == Impact ==
> Confirmed to affect Fujitsu Siemens Amilo Pro V3505, likely other
> Fujitsu models are affected as well.
> 
> == Fix ==
> Re-enable the fsam7400 module
> 
> Thanks,
> Leann
> 
> [1] https://wiki.ubuntu.com/KernelTeam/Specs/KernelOneiricUbuntuDeltaReview
> 
> From 29aa41d8752b4c2fd6d16067f1386749507ff373 Mon Sep 17 00:00:00 2001
> From: Leann Ogasawara <leann.ogasawara@canonical.com>
> Date: Mon, 17 Oct 2011 07:06:09 -0700
> Subject: [PATCH] Revert "UBUNTU: ubuntu: fsam7400 disable driver"
> 
> BugLink: http://bugs.launchpad.net/bugs/876030
> 
> This reverts commit 2c2ebcbf14a86f4af59ef1d4d420d3f19083472c.
> 
> Per the Oneiric Ubuntu Delta Review we purposely disabled the fsam7400
> driver with the hopes that we could then completely drop the driver for
> Precise 12.04.  However, there are reports that this driver is still in
> use.  Re-enable the driver.
> 
> Signed-off-by: Leann Ogasawara <leann.ogasawara@canonical.com>
> ---
>  ubuntu/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/Makefile b/ubuntu/Makefile
> index 7ac7805..30b3ded 100644
> --- a/ubuntu/Makefile
> +++ b/ubuntu/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_NDISWRAPPER)	+= ndiswrapper/
>  ##
>  ##
>  ##
> -#obj-$(CONFIG_FSAM7400)		+= fsam7400/
> +obj-$(CONFIG_FSAM7400)		+= fsam7400/
>  ##
>  ##
>  ##
> -- 
> 1.7.4.1
> 
> 
> 
>

Patch

diff --git a/ubuntu/Makefile b/ubuntu/Makefile
index 7ac7805..30b3ded 100644
--- a/ubuntu/Makefile
+++ b/ubuntu/Makefile
@@ -27,7 +27,7 @@  obj-$(CONFIG_NDISWRAPPER)	+= ndiswrapper/
 ##
 ##
 ##
-#obj-$(CONFIG_FSAM7400)		+= fsam7400/
+obj-$(CONFIG_FSAM7400)		+= fsam7400/
 ##
 ##
 ##