[v4,1/3] dt-bindings: net: bluetooth: add DT bindings for Realtek controllers
diff mbox series

Message ID 20191130202314.142096-2-bonstra@bonstra.fr.eu.org
State Changes Requested
Headers show
Series
  • Add Bluetooth support to Teres A64 I
Related show

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch success

Commit Message

Hugo Grostabussiat Nov. 30, 2019, 8:23 p.m. UTC
The rtl_bt driver already supports some Realtek controllers on ACPI
platforms.
This commit adds bindings for DT-only platforms.

Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
---
 .../bindings/net/realtek-bluetooth.yaml       | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml

Comments

Maxime Ripard Dec. 2, 2019, 7:03 p.m. UTC | #1
Hi,

On Sat, Nov 30, 2019 at 09:23:12PM +0100, Hugo Grostabussiat wrote:
> The rtl_bt driver already supports some Realtek controllers on ACPI
> platforms.
> This commit adds bindings for DT-only platforms.
>
> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> new file mode 100644
> index 000000000000..6b62e5132c90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek Bluetooth controllers device tree bindings
> +
> +description: |
> +  Device tree bindings for serial attached Realtek Bluetooth controllers.
> +
> +maintainers:
> +  - Marcel Holtmann <marcel@holtmann.org>
> +  - Johan Hedberg <johan.hedberg@gmail.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: realtek,rt8723bs-bt

This can be
compatible:
  const: realtek,rt8723bs-bt

> +  powerdown-gpios:
> +    description: GPIO line controlling the power down (BT_DIS#) signal
> +    maxItems: 1
> +
> +  device-wake-gpios:
> +    description: GPIO line controlling the device wakeup (BT_WAKE) signal
> +    maxItems: 1
> +
> +  host-wake-gpios:
> +    description: GPIO line sampling the host wakeup (BT_HOST_WAKE) signal
> +    maxItems: 1
> +
> +  firmware-name:
> +    description: |
> +      Name of the configuration file to load in addition to firmware
> +    $ref: http://devicetree.org/schemas/types.yaml#/definitions/string
> +
> +required:
> +  - compatible

Setting additionalProperties to false would be great here too.

Thanks!
Maxime
Rob Herring Dec. 13, 2019, 10:27 p.m. UTC | #2
On Sat, Nov 30, 2019 at 09:23:12PM +0100, Hugo Grostabussiat wrote:
> The rtl_bt driver already supports some Realtek controllers on ACPI
> platforms.
> This commit adds bindings for DT-only platforms.
> 
> Signed-off-by: Hugo Grostabussiat <bonstra@bonstra.fr.eu.org>
> ---
>  .../bindings/net/realtek-bluetooth.yaml       | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> new file mode 100644
> index 000000000000..6b62e5132c90
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek Bluetooth controllers device tree bindings
> +
> +description: |
> +  Device tree bindings for serial attached Realtek Bluetooth controllers.
> +
> +maintainers:
> +  - Marcel Holtmann <marcel@holtmann.org>
> +  - Johan Hedberg <johan.hedberg@gmail.com>
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: realtek,rt8723bs-bt
> +
> +  powerdown-gpios:
> +    description: GPIO line controlling the power down (BT_DIS#) signal
> +    maxItems: 1
> +
> +  device-wake-gpios:
> +    description: GPIO line controlling the device wakeup (BT_WAKE) signal
> +    maxItems: 1
> +
> +  host-wake-gpios:
> +    description: GPIO line sampling the host wakeup (BT_HOST_WAKE) signal
> +    maxItems: 1
> +
> +  firmware-name:
> +    description: |
> +      Name of the configuration file to load in addition to firmware
> +    $ref: http://devicetree.org/schemas/types.yaml#/definitions/string

This should be just:

$ref: /schemas/types.yaml#/definitions/string

> +
> +required:
> +  - compatible
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    uart1 {
> +      bluetooth {
> +        compatible = "realtek,rtl8723bs-bt";
> +        powerdown-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>;
> +        host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>;
> +        device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
> +        firmware-name = "rtl8723bs_config-teres_a64_i.bin";
> +      };
> +    };
> -- 
> 2.24.0
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
new file mode 100644
index 000000000000..6b62e5132c90
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml
@@ -0,0 +1,52 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek Bluetooth controllers device tree bindings
+
+description: |
+  Device tree bindings for serial attached Realtek Bluetooth controllers.
+
+maintainers:
+  - Marcel Holtmann <marcel@holtmann.org>
+  - Johan Hedberg <johan.hedberg@gmail.com>
+
+properties:
+  compatible:
+    items:
+      - const: realtek,rt8723bs-bt
+
+  powerdown-gpios:
+    description: GPIO line controlling the power down (BT_DIS#) signal
+    maxItems: 1
+
+  device-wake-gpios:
+    description: GPIO line controlling the device wakeup (BT_WAKE) signal
+    maxItems: 1
+
+  host-wake-gpios:
+    description: GPIO line sampling the host wakeup (BT_HOST_WAKE) signal
+    maxItems: 1
+
+  firmware-name:
+    description: |
+      Name of the configuration file to load in addition to firmware
+    $ref: http://devicetree.org/schemas/types.yaml#/definitions/string
+
+required:
+  - compatible
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    uart1 {
+      bluetooth {
+        compatible = "realtek,rtl8723bs-bt";
+        powerdown-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>;
+        host-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>;
+        device-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
+        firmware-name = "rtl8723bs_config-teres_a64_i.bin";
+      };
+    };