Patchwork [resend,1/1] ARM: i.MX28: shift frac value in _CLK_SET_RATE

login
register
mail settings
Submitter Matt Burtch
Date Oct. 17, 2011, 4:25 p.m.
Message ID <1318868745-19732-1-git-send-email-matt@grid-net.com>
Download mbox | patch
Permalink /patch/120269/
State New
Headers show

Comments

Matt Burtch - Oct. 17, 2011, 4:25 p.m.
Fixed whitespace formatting per Shawn Guo.

Noticed when setting SSP0 in clk_set_rate, _CLK_SET_RATE attempts to reset the clock divider for the SSP0 parent clock, in this case IO0FRAC. Bits 24-29 of HW_CLKCTRL_FRAC0 are cleared correctly, but when the new frac value is written the value isn't shifted up to write the correct bit-field.  This results in IO0FRAC being set to 0 and CPUFRAC being corrupted.

This should occur when writing IO1FRAC, EMIFRAC in HW_CLKCTRL_FRAC0 and GPMIFRAC, HSADCFRAC in HW_CLKCTRL_FRAC1.

Tested on custom i.MX28 board with SSP0 SPI driver.

Signed-off-by: Matt Burtch <matt@grid-net.com>
---
 arch/arm/mach-mxs/clock-mx28.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Fabio Estevam - Oct. 17, 2011, 4:52 p.m.
On Mon, Oct 17, 2011 at 2:25 PM, Matt Burtch <matt@grid-net.com> wrote:
> Fixed whitespace formatting per Shawn Guo.

You should put this comment below the --- line and mark the patch as
v2 in the Subject.

Regards,

Fabio Estevam
Sascha Hauer - Oct. 19, 2011, 6:54 a.m.
On Mon, Oct 17, 2011 at 09:25:45AM -0700, Matt Burtch wrote:
> Fixed whitespace formatting per Shawn Guo.
> 
> Noticed when setting SSP0 in clk_set_rate, _CLK_SET_RATE attempts to reset the clock divider for the SSP0 parent clock, in this case IO0FRAC. Bits 24-29 of HW_CLKCTRL_FRAC0 are cleared correctly, but when the new frac value is written the value isn't shifted up to write the correct bit-field.  This results in IO0FRAC being set to 0 and CPUFRAC being corrupted.
> 

Please linebreak your commit messages at around 70 characters. Fixed
this myself this time, but please remember for next time.

Sascha

> This should occur when writing IO1FRAC, EMIFRAC in HW_CLKCTRL_FRAC0 and GPMIFRAC, HSADCFRAC in HW_CLKCTRL_FRAC1.
> 
> Tested on custom i.MX28 board with SSP0 SPI driver.
> 
> Signed-off-by: Matt Burtch <matt@grid-net.com>
> ---
>  arch/arm/mach-mxs/clock-mx28.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
> index 5dcc59d..ba53227 100644
> --- a/arch/arm/mach-mxs/clock-mx28.c
> +++ b/arch/arm/mach-mxs/clock-mx28.c
> @@ -349,7 +349,7 @@ static int name##_set_rate(struct clk *clk, unsigned long rate)		\
>  									\
>  		reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
>  		reg &= ~BM_CLKCTRL_##fr##_##fs##FRAC;			\
> -		reg |= frac;						\
> +		reg |= frac << BP_CLKCTRL_##fr##_##fs##FRAC;		\
>  		__raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
>  	}								\
>  									\
> -- 
> 1.7.1
> 
>
Matt Burtch - Oct. 20, 2011, 9:05 p.m.
Thank you Sascha, I'll be sure to double check the formatting next time.

-Matt

On 10/18/2011 11:54 PM, Sascha Hauer wrote:
> On Mon, Oct 17, 2011 at 09:25:45AM -0700, Matt Burtch wrote:
>> Fixed whitespace formatting per Shawn Guo.
>>
>> Noticed when setting SSP0 in clk_set_rate, _CLK_SET_RATE attempts to reset the clock divider for the SSP0 parent clock, in this case IO0FRAC. Bits 24-29 of HW_CLKCTRL_FRAC0 are cleared correctly, but when the new frac value is written the value isn't shifted up to write the correct bit-field.  This results in IO0FRAC being set to 0 and CPUFRAC being corrupted.
>>
> Please linebreak your commit messages at around 70 characters. Fixed
> this myself this time, but please remember for next time.
>
> Sascha
>
>> This should occur when writing IO1FRAC, EMIFRAC in HW_CLKCTRL_FRAC0 and GPMIFRAC, HSADCFRAC in HW_CLKCTRL_FRAC1.
>>
>> Tested on custom i.MX28 board with SSP0 SPI driver.
>>
>> Signed-off-by: Matt Burtch<matt@grid-net.com>
>> ---
>>   arch/arm/mach-mxs/clock-mx28.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
>> index 5dcc59d..ba53227 100644
>> --- a/arch/arm/mach-mxs/clock-mx28.c
>> +++ b/arch/arm/mach-mxs/clock-mx28.c
>> @@ -349,7 +349,7 @@ static int name##_set_rate(struct clk *clk, unsigned long rate)		\
>>   									\
>>   		reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
>>   		reg&= ~BM_CLKCTRL_##fr##_##fs##FRAC;			\
>> -		reg |= frac;						\
>> +		reg |= frac<<  BP_CLKCTRL_##fr##_##fs##FRAC;		\
>>   		__raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
>>   	}								\
>>   									\
>> -- 
>> 1.7.1
>>
>>

Patch

diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c
index 5dcc59d..ba53227 100644
--- a/arch/arm/mach-mxs/clock-mx28.c
+++ b/arch/arm/mach-mxs/clock-mx28.c
@@ -349,7 +349,7 @@  static int name##_set_rate(struct clk *clk, unsigned long rate)		\
 									\
 		reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
 		reg &= ~BM_CLKCTRL_##fr##_##fs##FRAC;			\
-		reg |= frac;						\
+		reg |= frac << BP_CLKCTRL_##fr##_##fs##FRAC;		\
 		__raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_##fr);	\
 	}								\
 									\