| Message ID | 20191129212910.2537303-2-aduskett@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [PATCH/next,1/4] package/python-gitdb2: new package | expand |
On Fri, 29 Nov 2019 13:29:08 -0800 aduskett@gmail.com wrote: > From: Adam Duskett <Aduskett@gmail.com> > > Add a simple test case that imports the module. > > Signed-off-by: Adam Duskett <Aduskett@gmail.com> I've applied to master, after tweaking one thing. > diff --git a/support/testing/tests/package/sample_python_gitdb2.py b/support/testing/tests/package/sample_python_gitdb2.py > new file mode 100644 > index 0000000000..b5c43cd858 > --- /dev/null > +++ b/support/testing/tests/package/sample_python_gitdb2.py > @@ -0,0 +1,4 @@ > +# Taken from smmap/test/test_tutorial.py This really smells like a bad copy/paste from the python-smmap2 test script, so I dropped this line :-) Thanks! Thomas
Hello Adam, On Fri, 29 Nov 2019 13:29:08 -0800 aduskett@gmail.com wrote: > new file mode 100644 > index 0000000000..b5c43cd858 > --- /dev/null > +++ b/support/testing/tests/package/sample_python_gitdb2.py > @@ -0,0 +1,4 @@ > +# Taken from smmap/test/test_tutorial.py > + > +from gitdb import * This causes a flake8 warning: support/testing/tests/package/sample_python_gitdb2.py:1:1: F403 'from gitdb import *' used; unable to detect undefined names See https://lintlyci.github.io/Flake8Rules/rules/F403.html for more details about this, and https://gitlab.com/buildroot.org/buildroot/-/jobs/389451584 for the GitlabCI job that reported this. Could you have a look ? Thanks! Thomas
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 22befa0427..af41a94427 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -448,6 +448,8 @@ tests.package.test_python_constantly.TestPythonPy3Constantly: { extends: .runtim tests.package.test_python_crossbar.TestPythonPy3Crossbar: { extends: .runtime_test } tests.package.test_python_cryptography.TestPythonPy2Cryptography: { extends: .runtime_test } tests.package.test_python_cryptography.TestPythonPy3Cryptography: { extends: .runtime_test } +tests.package.test_python_gitdb2.TestPythonPy2Gitdb2: { extends: .runtime_test } +tests.package.test_python_gitdb2.TestPythonPy3Gitdb2: { extends: .runtime_test } tests.package.test_python_incremental.TestPythonPy2Incremental: { extends: .runtime_test } tests.package.test_python_incremental.TestPythonPy3Incremental: { extends: .runtime_test } tests.package.test_python_passlib.TestPythonPy2Passlib: { extends: .runtime_test } diff --git a/support/testing/tests/package/sample_python_gitdb2.py b/support/testing/tests/package/sample_python_gitdb2.py new file mode 100644 index 0000000000..b5c43cd858 --- /dev/null +++ b/support/testing/tests/package/sample_python_gitdb2.py @@ -0,0 +1,4 @@ +# Taken from smmap/test/test_tutorial.py + +from gitdb import * + diff --git a/support/testing/tests/package/test_python_gitdb2.py b/support/testing/tests/package/test_python_gitdb2.py new file mode 100644 index 0000000000..fc55f20821 --- /dev/null +++ b/support/testing/tests/package/test_python_gitdb2.py @@ -0,0 +1,21 @@ +from tests.package.test_python import TestPythonPackageBase + + +class TestPythonPy2Gitdb2(TestPythonPackageBase): + __test__ = True + config = TestPythonPackageBase.config + \ + """ + BR2_PACKAGE_PYTHON=y + BR2_PACKAGE_PYTHON_GITDB2=y + """ + sample_scripts = ["tests/package/sample_python_gitdb2.py"] + + +class TestPythonPy3Gitdb2(TestPythonPackageBase): + __test__ = True + config = TestPythonPackageBase.config + \ + """ + BR2_PACKAGE_PYTHON3=y + BR2_PACKAGE_PYTHON_GITDB2=y + """ + sample_scripts = ["tests/package/sample_python_gitdb2.py"]