From patchwork Fri Nov 29 09:17:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1202422 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-514820-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="NwNiE83P"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47PTS9331Kz9s3Z for ; Fri, 29 Nov 2019 20:17:45 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=oOv8/ZL2MycPJRuqq5VxeF8JrUvXH18BudBuwS2NCpIrkC1h4bPK/ 4ekUT1OyRFZ5aipAA3IdGYSCxV/J3sExizLzUywpMPvtiCdYVTEE8RK8wiN7dxs2 1PTR2M9XVgeHH3Az1G/D/jMc/Ywxbn/VZ3T+qMYhGTSCg7qSl7nhBk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=XAwxnoRrowmHcdd6sEuoyYlaYS8=; b=NwNiE83P/1TRYrBY0RM4 D1UCz5aSxuAFuC1svbV/HPUq2pqs6WYKoduZpV9sZlOFwM8p0v34LGigTK3vQZd5 2wSqyij8hD2U8noOpkhlSAUU5y5g/d10K+X1pQywy9uOb6/AY02wWp39++P6efu1 78i3kV3SQFDRZmjPQhWvn+M= Received: (qmail 78493 invoked by alias); 29 Nov 2019 09:17:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 78485 invoked by uid 89); 29 Nov 2019 09:17:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, KAM_NUMSUBJECT, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2019 09:17:36 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5FC0DB271 for ; Fri, 29 Nov 2019 09:17:34 +0000 (UTC) Date: Fri, 29 Nov 2019 10:17:34 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix PR92715 Message-ID: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-11-29 Richard Biener PR tree-optimization/92715 * tree-ssa-forwprop.c (simplify_vector_constructor): Bail out for uniform vectors and source vectors with less elements than the destination. * gcc.dg/torture/pr92715.c: New testcase. Index: gcc/tree-ssa-forwprop.c =================================================================== --- gcc/tree-ssa-forwprop.c (revision 278827) +++ gcc/tree-ssa-forwprop.c (working copy) @@ -2038,13 +2038,13 @@ constructor_elt *elt; bool maybe_ident; - gcc_checking_assert (gimple_assign_rhs_code (stmt) == CONSTRUCTOR); - op = gimple_assign_rhs1 (stmt); type = TREE_TYPE (op); - gcc_checking_assert (TREE_CODE (type) == VECTOR_TYPE); + gcc_checking_assert (TREE_CODE (op) == CONSTRUCTOR + && TREE_CODE (type) == VECTOR_TYPE); - if (!TYPE_VECTOR_SUBPARTS (type).is_constant (&nelts)) + if (!TYPE_VECTOR_SUBPARTS (type).is_constant (&nelts) + || uniform_vector_p (op)) return false; elem_type = TREE_TYPE (type); elem_size = TREE_INT_CST_LOW (TYPE_SIZE (elem_type)); @@ -2136,6 +2136,9 @@ || ! VECTOR_TYPE_P (TREE_TYPE (orig[0]))) return false; refnelts = TYPE_VECTOR_SUBPARTS (TREE_TYPE (orig[0])).to_constant (); + /* We currently do not handle larger destination vectors. */ + if (refnelts < nelts) + return false; if (maybe_ident) { Index: gcc/testsuite/gcc.dg/torture/pr92715.c =================================================================== --- gcc/testsuite/gcc.dg/torture/pr92715.c (nonexistent) +++ gcc/testsuite/gcc.dg/torture/pr92715.c (working copy) @@ -0,0 +1,17 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */ + +typedef double v4si __attribute__((vector_size(32))); +typedef double v2si __attribute__((vector_size(16))); + +void foo (v4si *dstp, v2si *srcp) +{ + v2si src = *srcp; + *dstp = (v4si) { src[0], src[1], src[0], src[1] }; +} + +void bar (v4si *dstp, v2si *srcp) +{ + v2si src = *srcp; + *dstp = (v4si) { src[0], src[0], src[0], src[0] }; +}