[Eoan,2/2] Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"
diff mbox series

Message ID 20191128135422.18160-3-cascardo@canonical.com
State New
Headers show
Series
  • Fixes boot problem
Related show

Commit Message

Thadeu Lima de Souza Cascardo Nov. 28, 2019, 1:54 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1852586

This reverts commit f8595e0ab193dcb7840cd74690c6728ac6ca9dc1.

This and the previous revert fix a boot problem reported by different
users. At least, one user has reported that the reverts fix the boot
issue.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 drivers/char/tpm/tpm_tis_core.c | 2 --
 1 file changed, 2 deletions(-)

Patch
diff mbox series

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index ffa9048d8f6c..c3181ea9f271 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -980,7 +980,6 @@  int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
 			goto out_err;
 		}
 
-		tpm_chip_start(chip);
 		if (irq) {
 			tpm_tis_probe_irq_single(chip, intmask, IRQF_SHARED,
 						 irq);
@@ -990,7 +989,6 @@  int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
 		} else {
 			tpm_tis_probe_irq(chip, intmask);
 		}
-		tpm_chip_stop(chip);
 	}
 
 	rc = tpm_chip_register(chip);