[2/3] dt-bindings: auxdisplay: Add JHD1313 bindings
diff mbox series

Message ID 20191128105508.3916-3-kbingham@kernel.org
State Not Applicable
Headers show
Series
  • drivers/auxdisplay: Provide support for JHD1313
Related show

Checks

Context Check Description
robh/dt-meta-schema fail build log
robh/checkpatch warning "total: 0 errors, 1 warnings, 33 lines checked"

Commit Message

Kieran Bingham Nov. 28, 2019, 10:55 a.m. UTC
From: Kieran Bingham <kbingham@kernel.org>

The JHD1313 is used in the Grove RGB LCD controller [0] and provides
an I2C interface to control the LCD.

The implementation is based upon the datasheet for the JHD1214 [1], as
this is the only datasheet referenced by the documentation for the Grove
part.

[0] http://wiki.seeedstudio.com/Grove-LCD_RGB_Backlight/
[1] https://seeeddoc.github.io/Grove-LCD_RGB_Backlight/res/JHD1214Y_YG_1.0.pdf

Signed-off-by: Simon Goda <simon.goda@doulos.com>
Signed-off-by: Kieran Bingham <kbingham@kernel.org>
---
 .../bindings/auxdisplay/jhd,jhd1313.yaml      | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml

Comments

Rob Herring Dec. 13, 2019, 9:03 p.m. UTC | #1
On Thu, Nov 28, 2019 at 10:55:07AM +0000, kbingham@kernel.org wrote:
> From: Kieran Bingham <kbingham@kernel.org>
> 
> The JHD1313 is used in the Grove RGB LCD controller [0] and provides
> an I2C interface to control the LCD.
> 
> The implementation is based upon the datasheet for the JHD1214 [1], as
> this is the only datasheet referenced by the documentation for the Grove
> part.
> 
> [0] http://wiki.seeedstudio.com/Grove-LCD_RGB_Backlight/
> [1] https://seeeddoc.github.io/Grove-LCD_RGB_Backlight/res/JHD1214Y_YG_1.0.pdf
> 
> Signed-off-by: Simon Goda <simon.goda@doulos.com>
> Signed-off-by: Kieran Bingham <kbingham@kernel.org>
> ---
>  .../bindings/auxdisplay/jhd,jhd1313.yaml      | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml
> 
> diff --git a/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml b/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml
> new file mode 100644
> index 000000000000..b799a91846d2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please.

(GPL-2.0-only OR BSD-2-Clause)

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml b/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml
new file mode 100644
index 000000000000..b799a91846d2
--- /dev/null
+++ b/Documentation/devicetree/bindings/auxdisplay/jhd,jhd1313.yaml
@@ -0,0 +1,33 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/auxdisplay/jhd,jhd1313.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: DT bindings for the JHD1313 Character LCD Controller
+
+description:
+  The JHD1313 Character LCD Controller is used by the widely available Grove
+  LCD RGB Backlight display. This currently supports only 16x2 LCD Modules. The
+  reg property specifies the I2C address of the module, and is expected to be
+  0x3e.
+
+maintainers:
+  - Kieran Bingham <kbingham@kernel.org>
+
+properties:
+  compatible:
+    const: jhd,jhd1313
+
+  reg: true
+
+required:
+ - compatible
+ - reg
+
+examples:
+ - |
+    auxdisplay: lcd@3e {
+        compatible = "jhd,jhd1313";
+        reg = <0x3e>;
+    };