[4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
diff mbox series

Message ID 5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com
State New
Headers show
Series
  • pinctrl: Use the correct style for SPDX License Identifier
Related show

Commit Message

Nishad Kamdar Nov. 27, 2019, 4:45 p.m. UTC
This patch corrects the SPDX License Identifier style in
header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.

Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
 drivers/pinctrl/sh-pfc/core.h   | 4 ++--
 drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Geert Uytterhoeven Nov. 27, 2019, 8:37 p.m. UTC | #1
Hi Nishad,

On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.

Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....

> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> ---
>  drivers/pinctrl/sh-pfc/core.h   | 4 ++--
>  drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
>   * SuperH Pin Function Controller support.
>   *
>   * Copyright (C) 2012  Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
>   * SuperH Pin Function Controller Support
>   *
>   * Copyright (c) 2008 Magnus Damm

Gr{oetje,eeting}s,

                        Geert
Andreas Färber Nov. 27, 2019, 8:55 p.m. UTC | #2
Hi Geert,

Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven:
> On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:
>> This patch corrects the SPDX License Identifier style in
>> header files related to Reneses Soc pinctrl driver.
>> It assigns explicit block comment for the SPDX License Identifier.
> 
> Is it incorrect to not have an explicit block comment?

Yes, Greg said so to me. He suggested I provide a patch against the
documentation if the docs are not clear enough, but I didn't get around
to it (and it's not my rule in the first place, so I'd appreciate the
person making that rule to take care of documenting it).

However, if we're touching these lines anyway, shouldn't we be updating
the SPDX Identifier to GPL-2.0-only while at it?

Cheers,
Andreas
Joe Perches Nov. 27, 2019, 8:59 p.m. UTC | #3
On Wed, 2019-11-27 at 21:55 +0100, Andreas Färber wrote:
> However, if we're touching these lines anyway, shouldn't we be updating
> the SPDX Identifier to GPL-2.0-only while at it?

Probably better to do that with a treewide script one day.

https://lkml.org/lkml/2018/8/16/487
Geert Uytterhoeven Nov. 27, 2019, 9:12 p.m. UTC | #4
On Wed, Nov 27, 2019 at 9:59 PM Joe Perches <joe@perches.com> wrote:
> On Wed, 2019-11-27 at 21:55 +0100, Andreas Färber wrote:
> > However, if we're touching these lines anyway, shouldn't we be updating
> > the SPDX Identifier to GPL-2.0-only while at it?
>
> Probably better to do that with a treewide script one day.

Yeah... But it's already more than one year after

> https://lkml.org/lkml/2018/8/16/487

and Documentation/process/license-rules.rst (which is the authoritive
rule?) still hasn't been updated...

Gr{oetje,eeting}s,

                        Geert
Joe Perches Nov. 27, 2019, 9:32 p.m. UTC | #5
On Wed, 2019-11-27 at 22:12 +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 27, 2019 at 9:59 PM Joe Perches <joe@perches.com> wrote:
> > On Wed, 2019-11-27 at 21:55 +0100, Andreas Färber wrote:
> > > However, if we're touching these lines anyway, shouldn't we be updating
> > > the SPDX Identifier to GPL-2.0-only while at it?
> > 
> > Probably better to do that with a treewide script one day.
> 
> Yeah... But it's already more than one year after
> 
> > https://lkml.org/lkml/2018/8/16/487
> 
> and Documentation/process/license-rules.rst (which is the authoritive
> rule?) still hasn't been updated...

The patch still applies today...
Linus Walleij Dec. 12, 2019, 10:32 a.m. UTC | #6
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <nishadkamdar@gmail.com> wrote:

> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>

I leave it to Geert to decide if he wants to pick this up for
sh-pfc or not.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
index b5b1d163e98a..5ad0ab8f9e14 100644
--- a/drivers/pinctrl/sh-pfc/core.h
+++ b/drivers/pinctrl/sh-pfc/core.h
@@ -1,5 +1,5 @@ 
-/* SPDX-License-Identifier: GPL-2.0
- *
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
  * SuperH Pin Function Controller support.
  *
  * Copyright (C) 2012  Renesas Solutions Corp.
diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
index 640d2a4cb838..fff9cbb7a0f8 100644
--- a/drivers/pinctrl/sh-pfc/sh_pfc.h
+++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
@@ -1,5 +1,5 @@ 
-/* SPDX-License-Identifier: GPL-2.0
- *
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
  * SuperH Pin Function Controller Support
  *
  * Copyright (c) 2008 Magnus Damm