dt-bindings: net: ti: cpsw-switch: update to fix comments
diff mbox series

Message ID 20191127155526.22746-1-grygorii.strashko@ti.com
State Accepted
Headers show
Series
  • dt-bindings: net: ti: cpsw-switch: update to fix comments
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Grygorii Strashko Nov. 27, 2019, 3:55 p.m. UTC
After original patch was merged there were additional comments/requests
provided by Rob Herring [1]. Mostly they are related to json-schema usage,
and this patch fixes them. Also SPDX-License-Identifier has been changed to
(GPL-2.0-only OR BSD-2-Clause) as requested.

[1] https://lkml.org/lkml/2019/11/21/875
Fixes: ef63fe72f698 ("dt-bindings: net: ti: add new cpsw switch driver bindings")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 .../bindings/net/ti,cpsw-switch.yaml          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

Comments

Rob Herring Dec. 5, 2019, 9:56 p.m. UTC | #1
On Wed, 27 Nov 2019 17:55:26 +0200, Grygorii Strashko wrote:
> After original patch was merged there were additional comments/requests
> provided by Rob Herring [1]. Mostly they are related to json-schema usage,
> and this patch fixes them. Also SPDX-License-Identifier has been changed to
> (GPL-2.0-only OR BSD-2-Clause) as requested.
> 
> [1] https://lkml.org/lkml/2019/11/21/875
> Fixes: ef63fe72f698 ("dt-bindings: net: ti: add new cpsw switch driver bindings")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  .../bindings/net/ti,cpsw-switch.yaml          | 20 +++++++------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 

Applied, thanks.

Rob

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
index 81ae8cafabc1..4e072a023f3e 100644
--- a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
@@ -1,4 +1,4 @@ 
-# SPDX-License-Identifier: GPL-2.0
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
 $id: http://devicetree.org/schemas/net/ti,cpsw-switch.yaml#
@@ -44,7 +44,6 @@  properties:
     description: CPSW functional clock
 
   clock-names:
-    maxItems: 1
     items:
       - const: fck
 
@@ -70,7 +69,6 @@  properties:
       Phandle to the system control device node which provides access to
       efuse IO range with MAC addresses
 
-
   ethernet-ports:
     type: object
     properties:
@@ -82,8 +80,6 @@  properties:
     patternProperties:
       "^port@[0-9]+$":
           type: object
-          minItems: 1
-          maxItems: 2
           description: CPSW external ports
 
           allOf:
@@ -92,21 +88,20 @@  properties:
           properties:
             reg:
               maxItems: 1
-              enum: [1, 2]
+              items:
+                - enum: [1, 2]
               description: CPSW port number
 
             phys:
-              $ref: /schemas/types.yaml#definitions/phandle-array
               maxItems: 1
               description:  phandle on phy-gmii-sel PHY
 
             label:
-              $ref: /schemas/types.yaml#/definitions/string-array
-              maxItems: 1
               description: label associated with this port
 
             ti,dual-emac-pvid:
-              $ref: /schemas/types.yaml#/definitions/uint32
+              allOf:
+                - $ref: /schemas/types.yaml#/definitions/uint32
               maxItems: 1
               minimum: 1
               maximum: 1024
@@ -136,7 +131,6 @@  properties:
         description: CPTS reference clock
 
       clock-names:
-        maxItems: 1
         items:
           - const: cpts
 
@@ -201,7 +195,7 @@  examples:
                         phys = <&phy_gmii_sel 1>;
                         phy-handle = <&ethphy0_sw>;
                         phy-mode = "rgmii";
-                        ti,dual_emac_pvid = <1>;
+                        ti,dual-emac-pvid = <1>;
                 };
 
                 cpsw_port2: port@2 {
@@ -211,7 +205,7 @@  examples:
                         phys = <&phy_gmii_sel 2>;
                         phy-handle = <&ethphy1_sw>;
                         phy-mode = "rgmii";
-                        ti,dual_emac_pvid = <2>;
+                        ti,dual-emac-pvid = <2>;
                 };
         };