net: inet_is_local_reserved_port() port arg should be unsigned short
diff mbox series

Message ID 20191126224416.23883-1-zenczykowski@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • net: inet_is_local_reserved_port() port arg should be unsigned short
Related show

Commit Message

Maciej Żenczykowski Nov. 26, 2019, 10:44 p.m. UTC
From: Maciej Żenczykowski <maze@google.com>

Any argument outside of that range would result in an out of bound
memory access, since the accessed array is 65536 bits long.

Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 include/net/ip.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Nov. 26, 2019, 11:15 p.m. UTC | #1
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 26 Nov 2019 14:44:16 -0800

> From: Maciej Żenczykowski <maze@google.com>
> 
> Any argument outside of that range would result in an out of bound
> memory access, since the accessed array is 65536 bits long.
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

Applied.

Patch
diff mbox series

diff --git a/include/net/ip.h b/include/net/ip.h
index c823aa279d21..cea69efe5322 100644
--- a/include/net/ip.h
+++ b/include/net/ip.h
@@ -339,7 +339,7 @@  static inline u64 snmp_fold_field64(void __percpu *mib, int offt, size_t syncp_o
 void inet_get_local_port_range(struct net *net, int *low, int *high);
 
 #ifdef CONFIG_SYSCTL
-static inline bool inet_is_local_reserved_port(struct net *net, int port)
+static inline bool inet_is_local_reserved_port(struct net *net, unsigned short port)
 {
 	if (!net->ipv4.sysctl_local_reserved_ports)
 		return false;
@@ -358,7 +358,7 @@  static inline bool inet_port_requires_bind_service(struct net *net, unsigned sho
 }
 
 #else
-static inline bool inet_is_local_reserved_port(struct net *net, int port)
+static inline bool inet_is_local_reserved_port(struct net *net, unsigned short port)
 {
 	return false;
 }