From patchwork Tue Nov 26 18:47:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1201164 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-514627-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ENSM8WDF"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47MtFj6XWnz9sPK for ; Wed, 27 Nov 2019 05:48:07 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=Dik4tKI+IjU5+BRkHI+v0zbgDJBf2kcTqnHC36SydEzvPBq57h 4dbvZyTIIPK59/+jxbSUTFC6moPUPrmG8qdjUzT706NemFBfJzzZKGkCkQq+A/Dk 32WZhBcbDD8aj6dVCErcrDDTp0fuKVyhIRQAJusXnHEekSA/Cvj/4P8Vs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=ysRfd/y86VTz8GWrQ5OrZSa+6tQ=; b=ENSM8WDFK4w9tE+sjBLk ZotpZxokCZl9isbc0P7+Vpb3mfdsj7BawbykBXMmuN6IeuaCSCpNE4gCYEbV29ua 69YcdwSs4Bh7Gjpp5bcW/ihjRxr+ySim3v8WrW1kNhTwz5jz5X7UNSvlnrt664m7 zBejPNO8oIrNWoY0X49yYmI= Received: (qmail 83952 invoked by alias); 26 Nov 2019 18:48:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 83943 invoked by uid 89); 26 Nov 2019 18:48:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, SPF_PASS autolearn=ham version=3.3.1 spammy=fortran, objc, fortranobjc, guessed, IRC X-HELO: esa4.mentor.iphmx.com Received: from esa4.mentor.iphmx.com (HELO esa4.mentor.iphmx.com) (68.232.137.252) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 18:47:53 +0000 IronPort-SDR: 2JM34pm1CKZWmYyFqZwCBJmf+7dFX+rmhEtS9PV4NEAZ4ly2Rk0Nn7A+1RGkg56tifSO01C6E0 pEaSb/WXVmzYuysjDfmV2eAbtT4Z8VafZlh+exYtB1KBBbnJparf5sMsOUchXTiVPCnKuVg956 QCaAS35810ZOdmbK7VO1G14gv8HQnUgfqLDJzkgedjetoyy8L0iK3q9WVLkCuOQurqarUamy6Q CVb+QqSL2ImQeqG/cLuue5mXkLkoXG1lAjRoD2d6cS2rn7FHH6BgLNVkMLfbpfTWKjC/eAmQsA 8dI= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 26 Nov 2019 10:47:51 -0800 IronPort-SDR: 4G48Ij6joWNVW1OeWT/1HZxh4h5Z2Wy//5LfVCNcAAMtPzcqzaUfiIznLCsj0jutqrcRzbHb4z aTPh1rditeepMZ8kqHvD4TASxNzXxA0FDJizUtSuASMp8SPxUg9AcO32kkQ9ibKgJf0Ax4Fiqz akB9rqSbSpi/8SKLjJ/QqEFmLkysW+v7wO+yxieKHjqUG+S+hIY6wQ4d1WjgcLBRJmD4KSh2nC IbAU61tKa+b9Nu7LMeL6MNM1OaU1OCnX9vazFcI6bHA5tW51udD1L5UCLUJyWcdXfcGQx9YZEM ScM= To: gcc-patches From: Tobias Burnus Subject: [Patch, build] Unbreak objc build Message-ID: <03fb27de-b533-a17f-257d-7720029e9503@codesourcery.com> Date: Tue, 26 Nov 2019 19:47:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 X-IsSubscribed: yes When I tried to bootstrap with --enable-languages=default, which includes objc, it failed to build libobj. As Rhy0lite on IRC correctly guessed, the issue is that the cet.m4 file is at a different location. I wonder why no one had the problem before in the last years – the libobjc/Makefile.in change was r254904 on Nov 17, 2017 (!). The config/cet.m4 file itself was also added on 2017-11-17 in r254868. Doing some more archeology, the the Makefile.in was changed by the patch https://gcc.gnu.org/ml/gcc-patches/2017-10/msg02314.html – and one sees that libobjc/aclocal.m4 has /../config/cet.m4 while libobjc/Makefile.in uses /../cet.m4.m4. – Actually, that's not the submitted version (cet.m4.m4) – as the committed version has 'cet.m4'. Approval was: https://gcc.gnu.org/ml/gcc-patches/2017-11/msg00641.html Build on x86-64-gnu-linux. OK for the trunk? Tobias PS: Assuming the build was indeed broken for everyone since 2 years, maybe one should remove 'objc' from the 'default' languages? – Which languages is now nowadays supposed to use when bootstrapping? I usually have 'c,c++,fortran,lto', 'default' seems to be 'c,c++,fortran,objc' (plus 'lto' which is implied by --enable-lto, which is default). libobjc/ * Makefile.in (aclocal_deps): Fix path to cet.m4. diff --git a/libobjc/Makefile.in b/libobjc/Makefile.in index d733fb2606b..f029880265e 100644 --- a/libobjc/Makefile.in +++ b/libobjc/Makefile.in @@ -297,7 +297,7 @@ aclocal_deps = \ $(srcdir)/../ltsugar.m4 \ $(srcdir)/../ltversion.m4 \ $(srcdir)/../lt~obsolete.m4 \ - $(srcdir)/../cet.m4 \ + $(srcdir)/../config/cet.m4 \ $(srcdir)/acinclude.m4 $(srcdir)/configure: @MAINT@ configure.ac $(srcdir)/aclocal.m4