Patchwork [v3,4/4] vga: compile cirrus_vga in hwlib

login
register
mail settings
Submitter Blue Swirl
Date Oct. 16, 2011, 9:23 p.m.
Message ID <CAAu8pHs1eWzbKcqHsiDqqdK5-6dBj6Mzs+m7Bu4KjTm4XW7adw@mail.gmail.com>
Download mbox | patch
Permalink /patch/120077/
State New
Headers show

Comments

Blue Swirl - Oct. 16, 2011, 9:23 p.m.
Remove target dependencies and compile Cirrus VGA in hwlib.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 Makefile.objs   |    1 +
 Makefile.target |    1 -
 hw/cirrus_vga.c |    3 ---
 3 files changed, 1 insertions(+), 4 deletions(-)

     }
@@ -1897,8 +1896,6 @@ static void cirrus_mmio_blt_write(CirrusVGAState
* s, unsigned address,
  *
  *  write mode 4/5
  *
- * assume TARGET_PAGE_SIZE >= 16
- *
  ***************************************/

 static void cirrus_mem_writeb_mode4and5_8bpp(CirrusVGAState * s,

Patch

From 8c158a2836f434393d09a41aa768920fef611c38 Mon Sep 17 00:00:00 2001
Message-Id: <8c158a2836f434393d09a41aa768920fef611c38.1318800015.git.blauwirbel@gmail.com>
In-Reply-To: <1a6e4affe4f24367cd79cdf8ec690d7ddb464321.1318800015.git.blauwirbel@gmail.com>
References: <1a6e4affe4f24367cd79cdf8ec690d7ddb464321.1318800015.git.blauwirbel@gmail.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 9 Oct 2011 09:58:00 +0000
Subject: [PATCH 4/4] vga: compile cirrus_vga in hwlib

Remove target dependencies and compile Cirrus VGA in hwlib.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 Makefile.objs   |    1 +
 Makefile.target |    1 -
 hw/cirrus_vga.c |    3 ---
 3 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/Makefile.objs b/Makefile.objs
index 44d9bb9..e98d74e 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -286,6 +286,7 @@  hw-obj-$(CONFIG_VGA_ISA) += vga-isa.o
 hw-obj-$(CONFIG_VGA_ISA_MM) += vga-isa-mm.o
 hw-obj-$(CONFIG_VMWARE_VGA) += vmware_vga.o
 hw-obj-$(CONFIG_VMMOUSE) += vmmouse.o
+hw-obj-$(CONFIG_VGA_CIRRUS) += cirrus_vga.o
 
 hw-obj-$(CONFIG_RC4030) += rc4030.o
 hw-obj-$(CONFIG_DP8393X) += dp8393x.o
diff --git a/Makefile.target b/Makefile.target
index b948acf..2401951 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -195,7 +195,6 @@  obj-$(CONFIG_KVM) += kvm.o kvm-all.o
 obj-$(CONFIG_NO_KVM) += kvm-stub.o
 obj-y += memory.o
 obj-$(CONFIG_VGA) += vga.o
-obj-$(CONFIG_VGA_CIRRUS) += cirrus_vga.o
 LIBS+=-lz
 
 QEMU_CFLAGS += $(VNC_TLS_CFLAGS)
diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 846c8f5..0c86794 100644
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -618,7 +618,6 @@  static void cirrus_invalidate_region(CirrusVGAState * s, int off_begin,
     for (y = 0; y < lines; y++) {
 	off_cur = off_begin;
 	off_cur_end = (off_cur + bytesperline) & s->cirrus_addr_mask;
-	off_cur &= TARGET_PAGE_MASK;
         memory_region_set_dirty(&s->vga.vram, off_cur, off_cur_end - off_cur);
 	off_begin += off_pitch;
     }
@@ -1897,8 +1896,6 @@  static void cirrus_mmio_blt_write(CirrusVGAState * s, unsigned address,
  *
  *  write mode 4/5
  *
- * assume TARGET_PAGE_SIZE >= 16
- *
  ***************************************/
 
 static void cirrus_mem_writeb_mode4and5_8bpp(CirrusVGAState * s,
-- 
1.7.2.5