[v2] net: Fix a documentation bug wrt. ip_unprivileged_port_start
diff mbox series

Message ID 20191125224800.147072-1-zenczykowski@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series
  • [v2] net: Fix a documentation bug wrt. ip_unprivileged_port_start
Related show

Commit Message

Maciej Żenczykowski Nov. 25, 2019, 10:48 p.m. UTC
From: Maciej Żenczykowski <maze@google.com>

It cannot overlap with the local port range - ie. with autobind selectable
ports - and not with reserved ports.

Indeed 'ip_local_reserved_ports' isn't even a range, it's a (by default
empty) set.

Fixes: 4548b683b781 ("Introduce a sysctl that modifies the value of PROT_SOCK.")
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 Documentation/networking/ip-sysctl.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

David Miller Nov. 26, 2019, 9:18 p.m. UTC | #1
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Mon, 25 Nov 2019 14:48:00 -0800

> From: Maciej Żenczykowski <maze@google.com>
> 
> It cannot overlap with the local port range - ie. with autobind selectable
> ports - and not with reserved ports.
> 
> Indeed 'ip_local_reserved_ports' isn't even a range, it's a (by default
> empty) set.
> 
> Fixes: 4548b683b781 ("Introduce a sysctl that modifies the value of PROT_SOCK.")
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

Applied.

Patch
diff mbox series

diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
index 099a55bd1432..fd26788e8c96 100644
--- a/Documentation/networking/ip-sysctl.txt
+++ b/Documentation/networking/ip-sysctl.txt
@@ -904,8 +904,9 @@  ip_local_port_range - 2 INTEGERS
 	Defines the local port range that is used by TCP and UDP to
 	choose the local port. The first number is the first, the
 	second the last local port number.
-	If possible, it is better these numbers have different parity.
-	(one even and one odd values)
+	If possible, it is better these numbers have different parity
+	(one even and one odd value).
+	Must be greater than or equal to ip_unprivileged_port_start.
 	The default values are 32768 and 60999 respectively.
 
 ip_local_reserved_ports - list of comma separated ranges
@@ -943,8 +944,8 @@  ip_unprivileged_port_start - INTEGER
 	This is a per-namespace sysctl.  It defines the first
 	unprivileged port in the network namespace.  Privileged ports
 	require root or CAP_NET_BIND_SERVICE in order to bind to them.
-	To disable all privileged ports, set this to 0.  It may not
-	overlap with the ip_local_reserved_ports range.
+	To disable all privileged ports, set this to 0.  They must not
+	overlap with the ip_local_port_range.
 
 	Default: 1024